nizhikov commented on PR #15216:
URL: https://github.com/apache/kafka/pull/15216#issuecomment-1940771761
@lucasbru No worries. I wanted to make it clear that class removed by
mistake and didn't broke something.
Will return it in the next PR regarding `Console Group Command`.
--
This is
lucasbru commented on PR #15216:
URL: https://github.com/apache/kafka/pull/15216#issuecomment-1940762063
@nizhikov Sorry, during review I thought @philipnee removed a left-over
class from an earlier PR also called `GroupState`.
https://github.com/apache/kafka/blob/6e164bb9ace3ea7a1a9542904d
nizhikov commented on PR #15216:
URL: https://github.com/apache/kafka/pull/15216#issuecomment-1940488544
Hello @philipnee @lucasbru
Why you remove GroupState class in this commit?
This class will be used in java version of ConsoleGroupCommand when
https://github.com/apache/kafka/pu
lucasbru merged PR #15216:
URL: https://github.com/apache/kafka/pull/15216
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
lucasbru commented on code in PR #15216:
URL: https://github.com/apache/kafka/pull/15216#discussion_r1475807637
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/metrics/HeartbeatMetricsManager.java:
##
@@ -0,0 +1,77 @@
+/*
+ * Licensed to the Apache Software
philipnee commented on code in PR #15216:
URL: https://github.com/apache/kafka/pull/15216#discussion_r1474925331
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/metrics/HeartbeatMetricsManager.java:
##
@@ -0,0 +1,77 @@
+/*
+ * Licensed to the Apache Software
philipnee commented on code in PR #15216:
URL: https://github.com/apache/kafka/pull/15216#discussion_r1474925331
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/metrics/HeartbeatMetricsManager.java:
##
@@ -0,0 +1,77 @@
+/*
+ * Licensed to the Apache Software
lucasbru commented on code in PR #15216:
URL: https://github.com/apache/kafka/pull/15216#discussion_r1474777535
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/metrics/HeartbeatMetricsManager.java:
##
@@ -0,0 +1,77 @@
+/*
+ * Licensed to the Apache Software
philipnee commented on PR #15216:
URL: https://github.com/apache/kafka/pull/15216#issuecomment-1921750518
@lucasbru - Thank you for spending time reviewing the PR. I responded to
your comment about resource closing. It is indeed a bit strange why we need to
do this.
A weird thing I
philipnee commented on code in PR #15216:
URL: https://github.com/apache/kafka/pull/15216#discussion_r1474763839
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/metrics/HeartbeatMetricsManager.java:
##
@@ -0,0 +1,77 @@
+/*
+ * Licensed to the Apache Software
lucasbru commented on PR #15216:
URL: https://github.com/apache/kafka/pull/15216#issuecomment-1921566239
I have one last comment, otherwise the PR looks good to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
U
lucasbru commented on code in PR #15216:
URL: https://github.com/apache/kafka/pull/15216#discussion_r1474644032
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/metrics/AbstractConsumerMetricsManager.java:
##
@@ -0,0 +1,94 @@
+/*
+ * Licensed to the Apache So
lucasbru commented on code in PR #15216:
URL: https://github.com/apache/kafka/pull/15216#discussion_r1474642551
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/metrics/HeartbeatMetricsManager.java:
##
@@ -0,0 +1,77 @@
+/*
+ * Licensed to the Apache Software
philipnee commented on code in PR #15216:
URL: https://github.com/apache/kafka/pull/15216#discussion_r1473330427
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/metrics/AbstractConsumerMetricsManager.java:
##
@@ -0,0 +1,94 @@
+/*
+ * Licensed to the Apache S
philipnee commented on code in PR #15216:
URL: https://github.com/apache/kafka/pull/15216#discussion_r1473160823
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/metrics/AbstractConsumerMetricsManager.java:
##
@@ -0,0 +1,94 @@
+/*
+ * Licensed to the Apache S
lucasbru commented on code in PR #15216:
URL: https://github.com/apache/kafka/pull/15216#discussion_r1472657940
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java:
##
@@ -108,6 +110,7 @@ public class HeartbeatRequestManager implemen
lucasbru commented on PR #15216:
URL: https://github.com/apache/kafka/pull/15216#issuecomment-1917073495
Thanks, @philipnee. I will not get to it today, but I will review it
tomorrow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
philipnee commented on PR #15216:
URL: https://github.com/apache/kafka/pull/15216#issuecomment-1915374713
Hi @lucasbru - This PR is ready for review. I did a bit of refactor in this
PR so not everything here is in the scope. Let me know what do you think!
--
This is an automated message
philipnee commented on code in PR #15216:
URL: https://github.com/apache/kafka/pull/15216#discussion_r1470063334
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManagerTest.java:
##
@@ -671,18 +718,8 @@ private ConsumerConfig config() {
philipnee commented on code in PR #15216:
URL: https://github.com/apache/kafka/pull/15216#discussion_r1470058217
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/metrics/KafkaConsumerMetrics.java:
##
@@ -26,20 +26,20 @@
import java.util.concurrent.TimeUnit
philipnee opened a new pull request, #15216:
URL: https://github.com/apache/kafka/pull/15216
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-
21 matches
Mail list logo
