jolshan merged PR #16183:
URL: https://github.com/apache/kafka/pull/16183
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.
jolshan commented on PR #16183:
URL: https://github.com/apache/kafka/pull/16183#issuecomment-2249007740
Some of the gradle task executors failed so I will run again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
jolshan commented on code in PR #16183:
URL: https://github.com/apache/kafka/pull/16183#discussion_r1688658774
##
metadata/src/test/java/org/apache/kafka/controller/QuorumFeaturesTest.java:
##
@@ -58,10 +61,13 @@ public void testDefaultFeatureMap() {
MetadataVersion
junrao commented on code in PR #16183:
URL: https://github.com/apache/kafka/pull/16183#discussion_r1688638549
##
metadata/src/test/java/org/apache/kafka/controller/QuorumFeaturesTest.java:
##
@@ -58,10 +61,13 @@ public void testDefaultFeatureMap() {
MetadataVersion.
junrao commented on PR #16183:
URL: https://github.com/apache/kafka/pull/16183#issuecomment-2245675058
@jolshan : Thanks for the updated PR. The following test failure seems
related to the PR.
```
[2024-07-23T02:46:53.731Z]
[2024-07-23T02:46:53.731Z] Gradle Test Run :metadata:t
jolshan commented on code in PR #16183:
URL: https://github.com/apache/kafka/pull/16183#discussion_r1685037958
##
core/src/main/scala/kafka/server/BrokerLifecycleManager.scala:
##
@@ -381,10 +381,12 @@ class BrokerLifecycleManager(
private def sendBrokerRegistration(): Unit =
cmccabe commented on code in PR #16183:
URL: https://github.com/apache/kafka/pull/16183#discussion_r1685017655
##
core/src/main/scala/kafka/server/BrokerLifecycleManager.scala:
##
@@ -381,10 +381,12 @@ class BrokerLifecycleManager(
private def sendBrokerRegistration(): Unit =
jolshan commented on code in PR #16183:
URL: https://github.com/apache/kafka/pull/16183#discussion_r1684962284
##
core/src/test/scala/unit/kafka/server/BrokerFeaturesTest.scala:
##
@@ -95,10 +97,20 @@ class BrokerFeaturesTest {
val expectedFeatures = Map[String, Short](
junrao commented on code in PR #16183:
URL: https://github.com/apache/kafka/pull/16183#discussion_r1684941966
##
server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java:
##
@@ -217,9 +217,10 @@ public enum MetadataVersion {
// Add ELR related support
jolshan commented on code in PR #16183:
URL: https://github.com/apache/kafka/pull/16183#discussion_r1684885144
##
core/src/main/scala/kafka/server/BrokerLifecycleManager.scala:
##
@@ -381,10 +381,12 @@ class BrokerLifecycleManager(
private def sendBrokerRegistration(): Unit =
jolshan commented on code in PR #16183:
URL: https://github.com/apache/kafka/pull/16183#discussion_r1684718844
##
core/src/main/scala/kafka/server/BrokerLifecycleManager.scala:
##
@@ -381,10 +381,12 @@ class BrokerLifecycleManager(
private def sendBrokerRegistration(): Unit =
jolshan commented on code in PR #16183:
URL: https://github.com/apache/kafka/pull/16183#discussion_r1684712684
##
core/src/main/scala/kafka/server/BrokerLifecycleManager.scala:
##
@@ -381,10 +381,12 @@ class BrokerLifecycleManager(
private def sendBrokerRegistration(): Unit =
jolshan commented on code in PR #16183:
URL: https://github.com/apache/kafka/pull/16183#discussion_r1684712684
##
core/src/main/scala/kafka/server/BrokerLifecycleManager.scala:
##
@@ -381,10 +381,12 @@ class BrokerLifecycleManager(
private def sendBrokerRegistration(): Unit =
cmccabe commented on code in PR #16183:
URL: https://github.com/apache/kafka/pull/16183#discussion_r1684705617
##
core/src/main/scala/kafka/server/BrokerLifecycleManager.scala:
##
@@ -381,10 +381,12 @@ class BrokerLifecycleManager(
private def sendBrokerRegistration(): Unit =
cmccabe commented on code in PR #16183:
URL: https://github.com/apache/kafka/pull/16183#discussion_r1684705617
##
core/src/main/scala/kafka/server/BrokerLifecycleManager.scala:
##
@@ -381,10 +381,12 @@ class BrokerLifecycleManager(
private def sendBrokerRegistration(): Unit =
junrao commented on code in PR #16183:
URL: https://github.com/apache/kafka/pull/16183#discussion_r1684690411
##
core/src/main/scala/kafka/server/BrokerLifecycleManager.scala:
##
@@ -381,10 +381,12 @@ class BrokerLifecycleManager(
private def sendBrokerRegistration(): Unit =
junrao commented on code in PR #16183:
URL: https://github.com/apache/kafka/pull/16183#discussion_r1684690411
##
core/src/main/scala/kafka/server/BrokerLifecycleManager.scala:
##
@@ -381,10 +381,12 @@ class BrokerLifecycleManager(
private def sendBrokerRegistration(): Unit =
jolshan commented on code in PR #16183:
URL: https://github.com/apache/kafka/pull/16183#discussion_r1684693402
##
core/src/main/scala/kafka/server/BrokerLifecycleManager.scala:
##
@@ -381,10 +381,12 @@ class BrokerLifecycleManager(
private def sendBrokerRegistration(): Unit =
junrao commented on code in PR #16183:
URL: https://github.com/apache/kafka/pull/16183#discussion_r1684690411
##
core/src/main/scala/kafka/server/BrokerLifecycleManager.scala:
##
@@ -381,10 +381,12 @@ class BrokerLifecycleManager(
private def sendBrokerRegistration(): Unit =
jolshan commented on PR #16183:
URL: https://github.com/apache/kafka/pull/16183#issuecomment-2239635110
Given that Kraft version starts at 0, I guess we should have all versions
start a zero for consistency. I also noticed one test asserts all features with
version zero bootstrap with minim
jolshan commented on code in PR #16183:
URL: https://github.com/apache/kafka/pull/16183#discussion_r1684645307
##
core/src/main/scala/kafka/server/BrokerLifecycleManager.scala:
##
@@ -381,10 +381,12 @@ class BrokerLifecycleManager(
private def sendBrokerRegistration(): Unit =
jolshan commented on code in PR #16183:
URL: https://github.com/apache/kafka/pull/16183#discussion_r1684642190
##
server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java:
##
@@ -217,8 +217,12 @@ public enum MetadataVersion {
// Add ELR related suppor
junrao commented on code in PR #16183:
URL: https://github.com/apache/kafka/pull/16183#discussion_r1684620247
##
core/src/main/scala/kafka/server/BrokerLifecycleManager.scala:
##
@@ -381,10 +381,12 @@ class BrokerLifecycleManager(
private def sendBrokerRegistration(): Unit =
jolshan commented on PR #16183:
URL: https://github.com/apache/kafka/pull/16183#issuecomment-2239559725
Will look at the apiversions test failures 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
jolshan commented on code in PR #16183:
URL: https://github.com/apache/kafka/pull/16183#discussion_r1683614145
##
server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java:
##
@@ -217,8 +217,11 @@ public enum MetadataVersion {
// Add ELR related suppor
jolshan commented on code in PR #16183:
URL: https://github.com/apache/kafka/pull/16183#discussion_r1683529869
##
server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java:
##
@@ -217,8 +217,11 @@ public enum MetadataVersion {
// Add ELR related suppor
junrao commented on code in PR #16183:
URL: https://github.com/apache/kafka/pull/16183#discussion_r1683517785
##
server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java:
##
@@ -217,8 +217,11 @@ public enum MetadataVersion {
// Add ELR related support
jolshan commented on code in PR #16183:
URL: https://github.com/apache/kafka/pull/16183#discussion_r1683242528
##
server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java:
##
@@ -217,8 +217,11 @@ public enum MetadataVersion {
// Add ELR related suppor
jolshan commented on code in PR #16183:
URL: https://github.com/apache/kafka/pull/16183#discussion_r1674310171
##
server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java:
##
@@ -217,8 +217,11 @@ public enum MetadataVersion {
// Add ELR related suppor
junrao commented on code in PR #16183:
URL: https://github.com/apache/kafka/pull/16183#discussion_r1674294082
##
server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java:
##
@@ -217,8 +217,11 @@ public enum MetadataVersion {
// Add ELR related support
jolshan commented on code in PR #16183:
URL: https://github.com/apache/kafka/pull/16183#discussion_r1673242703
##
server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java:
##
@@ -217,8 +217,11 @@ public enum MetadataVersion {
// Add ELR related suppor
junrao commented on code in PR #16183:
URL: https://github.com/apache/kafka/pull/16183#discussion_r1673162688
##
server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java:
##
@@ -217,8 +217,11 @@ public enum MetadataVersion {
// Add ELR related support
jolshan commented on PR #16183:
URL: https://github.com/apache/kafka/pull/16183#issuecomment-2221692444
I think I also need to fix the case where max version is 0 as well. 🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
jolshan commented on PR #16183:
URL: https://github.com/apache/kafka/pull/16183#issuecomment-2221688829
Yeehaw time to rebase
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comm
jolshan commented on code in PR #16183:
URL: https://github.com/apache/kafka/pull/16183#discussion_r1639981075
##
core/src/main/scala/kafka/coordinator/transaction/TransactionStateManager.scala:
##
@@ -618,7 +624,7 @@ class TransactionStateManager(brokerId: Int,
// genera
dajac commented on code in PR #16183:
URL: https://github.com/apache/kafka/pull/16183#discussion_r1639511150
##
core/src/main/scala/kafka/coordinator/transaction/TransactionStateManager.scala:
##
@@ -618,7 +624,7 @@ class TransactionStateManager(brokerId: Int,
// generate
artemlivshits commented on code in PR #16183:
URL: https://github.com/apache/kafka/pull/16183#discussion_r1638849949
##
server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java:
##
@@ -205,7 +205,10 @@ public enum MetadataVersion {
IBP_3_8_IV0(20, "3.
jolshan commented on code in PR #16183:
URL: https://github.com/apache/kafka/pull/16183#discussion_r1638510363
##
server-common/src/main/java/org/apache/kafka/server/common/TransactionVersion.java:
##
@@ -0,0 +1,64 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) unde
jolshan commented on code in PR #16183:
URL: https://github.com/apache/kafka/pull/16183#discussion_r1638509930
##
server-common/src/main/java/org/apache/kafka/server/common/TransactionVersion.java:
##
@@ -0,0 +1,64 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) unde
dajac commented on code in PR #16183:
URL: https://github.com/apache/kafka/pull/16183#discussion_r1638158613
##
server-common/src/main/java/org/apache/kafka/server/common/TransactionVersion.java:
##
@@ -0,0 +1,64 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
jolshan commented on code in PR #16183:
URL: https://github.com/apache/kafka/pull/16183#discussion_r1631735975
##
server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java:
##
@@ -205,7 +205,10 @@ public enum MetadataVersion {
IBP_3_8_IV0(20, "3.8", "I
jolshan commented on code in PR #16183:
URL: https://github.com/apache/kafka/pull/16183#discussion_r1631735975
##
server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java:
##
@@ -205,7 +205,10 @@ public enum MetadataVersion {
IBP_3_8_IV0(20, "3.8", "I
artemlivshits commented on code in PR #16183:
URL: https://github.com/apache/kafka/pull/16183#discussion_r1631716436
##
server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java:
##
@@ -205,7 +205,10 @@ public enum MetadataVersion {
IBP_3_8_IV0(20, "3.
jolshan commented on code in PR #16183:
URL: https://github.com/apache/kafka/pull/16183#discussion_r1629730668
##
server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java:
##
@@ -205,7 +205,10 @@ public enum MetadataVersion {
IBP_3_8_IV0(20, "3.8", "I
jolshan commented on code in PR #16183:
URL: https://github.com/apache/kafka/pull/16183#discussion_r1629730197
##
server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java:
##
@@ -205,7 +205,10 @@ public enum MetadataVersion {
IBP_3_8_IV0(20, "3.8", "I
artemlivshits commented on code in PR #16183:
URL: https://github.com/apache/kafka/pull/16183#discussion_r1628482592
##
core/src/main/scala/kafka/coordinator/transaction/TransactionLog.scala:
##
@@ -75,9 +76,9 @@ object TransactionLog {
.setPartitionIds(partitions.m
46 matches
Mail list logo
