Re: [PR] KAFKA-16394: Fix null propagation in foreign key join result [kafka]

2024-09-26 Thread via GitHub
mjsax commented on PR #15607: URL: https://github.com/apache/kafka/pull/15607#issuecomment-2378187158 Thanks for the ping -- I have this PR on my mind, but just don't find time to review... The 3.9 ship did sail. I hope (but cannot promise) to get this into 4.0 release... :( Kafka is

Re: [PR] KAFKA-16394: Fix null propagation in foreign key join result [kafka]

2024-09-26 Thread via GitHub
wrwksexahatvani commented on PR #15607: URL: https://github.com/apache/kafka/pull/15607#issuecomment-2376945505 @mjsax @wcarlson5 @gongxuanzhang This is a major blocker as it leads to data loss as happened in dozens of my projects. When will the fix for this be integrated? -- This is an

Re: [PR] KAFKA-16394: Fix null propagation in foreign key join result [kafka]

2024-05-07 Thread via GitHub
AyoubOm commented on code in PR #15607: URL: https://github.com/apache/kafka/pull/15607#discussion_r1592389047 ## streams/src/test/java/org/apache/kafka/streams/integration/KTableKTableForeignKeyJoinIntegrationTest.java: ## @@ -244,21 +248,21 @@ public void doJoinFromLeftThenDel

Re: [PR] KAFKA-16394: Fix null propagation in foreign key join result [kafka]

2024-05-07 Thread via GitHub
AyoubOm commented on code in PR #15607: URL: https://github.com/apache/kafka/pull/15607#discussion_r1592386867 ## streams/src/test/java/org/apache/kafka/streams/integration/KTableKTableForeignKeyJoinIntegrationTest.java: ## @@ -244,21 +248,21 @@ public void doJoinFromLeftThenDel

Re: [PR] KAFKA-16394: Fix null propagation in foreign key join result [kafka]

2024-05-07 Thread via GitHub
AyoubOm commented on code in PR #15607: URL: https://github.com/apache/kafka/pull/15607#discussion_r1592386867 ## streams/src/test/java/org/apache/kafka/streams/integration/KTableKTableForeignKeyJoinIntegrationTest.java: ## @@ -244,21 +248,21 @@ public void doJoinFromLeftThenDel

Re: [PR] KAFKA-16394: Fix null propagation in foreign key join result [kafka]

2024-05-01 Thread via GitHub
AyoubOm commented on PR #15607: URL: https://github.com/apache/kafka/pull/15607#issuecomment-2088456658 > Can we update existing test to not use `Map` but `List` (as I mentioned on the duplicate ticket https://issues.apache.org/jira/browse/KAFKA-16644) which should expose the bug? >

Re: [PR] KAFKA-16394: Fix null propagation in foreign key join result [kafka]

2024-04-30 Thread via GitHub
mjsax commented on PR #15607: URL: https://github.com/apache/kafka/pull/15607#issuecomment-2088000194 Can we update existing test to not use `Map` but `List` (as I mentioned on the duplicate ticket https://issues.apache.org/jira/browse/KAFKA-16644) which should expose the bug? Need t

Re: [PR] KAFKA-16394: Fix null propagation in foreign key join result [kafka]

2024-03-28 Thread via GitHub
soarez commented on PR #15607: URL: https://github.com/apache/kafka/pull/15607#issuecomment-2026208622 @mjsax I think this one should also be tagged 'streams' -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[PR] KAFKA-16394: Fix null propagation in foreign key join result [kafka]

2024-03-26 Thread via GitHub
AyoubOm opened a new pull request, #15607: URL: https://github.com/apache/kafka/pull/15607 This fixes the two issues reported in KAFKA-16394, which are: - Null should not be propagated to the join result when changing a foreign key - Null should not be propagated twice in the join