showuon merged PR #16079:
URL: https://github.com/apache/kafka/pull/16079
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.
showuon commented on PR #16079:
URL: https://github.com/apache/kafka/pull/16079#issuecomment-2151505048
Failed tests are unrelated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific co
jsancio commented on PR #16079:
URL: https://github.com/apache/kafka/pull/16079#issuecomment-2150573947
LGTM. Waiting for the build to finish.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
ahuang98 commented on code in PR #16079:
URL: https://github.com/apache/kafka/pull/16079#discussion_r1628130041
##
raft/src/test/java/org/apache/kafka/raft/LeaderStateTest.java:
##
@@ -272,20 +280,109 @@ public void testUpdateHighWatermarkQuorumSizeThree() {
assertEqual
ahuang98 commented on code in PR #16079:
URL: https://github.com/apache/kafka/pull/16079#discussion_r1628082127
##
raft/src/test/java/org/apache/kafka/raft/LeaderStateTest.java:
##
@@ -272,20 +280,109 @@ public void testUpdateHighWatermarkQuorumSizeThree() {
assertEqual
ahuang98 commented on code in PR #16079:
URL: https://github.com/apache/kafka/pull/16079#discussion_r1628083453
##
raft/src/test/java/org/apache/kafka/raft/LeaderStateTest.java:
##
@@ -272,20 +280,109 @@ public void testUpdateHighWatermarkQuorumSizeThree() {
assertEqual
ahuang98 commented on code in PR #16079:
URL: https://github.com/apache/kafka/pull/16079#discussion_r1628082127
##
raft/src/test/java/org/apache/kafka/raft/LeaderStateTest.java:
##
@@ -272,20 +280,109 @@ public void testUpdateHighWatermarkQuorumSizeThree() {
assertEqual
jsancio commented on code in PR #16079:
URL: https://github.com/apache/kafka/pull/16079#discussion_r1627947377
##
raft/src/test/java/org/apache/kafka/raft/internals/KafkaRaftMetricsTest.java:
##
@@ -98,6 +100,7 @@ private VoterSet localStandaloneVoterSet(short kraftVersion)
{
ahuang98 commented on code in PR #16079:
URL: https://github.com/apache/kafka/pull/16079#discussion_r1626330605
##
raft/src/main/java/org/apache/kafka/raft/LeaderState.java:
##
@@ -435,16 +438,40 @@ private DescribeQuorumResponseData.ReplicaState
describeReplicaState(
}
ahuang98 commented on code in PR #16079:
URL: https://github.com/apache/kafka/pull/16079#discussion_r1626317294
##
raft/src/main/java/org/apache/kafka/raft/LeaderState.java:
##
@@ -435,16 +438,40 @@ private DescribeQuorumResponseData.ReplicaState
describeReplicaState(
}
ahuang98 commented on code in PR #16079:
URL: https://github.com/apache/kafka/pull/16079#discussion_r1626217969
##
raft/src/test/java/org/apache/kafka/raft/LeaderStateTest.java:
##
@@ -272,20 +280,103 @@ public void testUpdateHighWatermarkQuorumSizeThree() {
assertEqual
showuon commented on code in PR #16079:
URL: https://github.com/apache/kafka/pull/16079#discussion_r1625880394
##
raft/src/main/java/org/apache/kafka/raft/LeaderState.java:
##
@@ -435,16 +438,40 @@ private DescribeQuorumResponseData.ReplicaState
describeReplicaState(
}
jsancio commented on code in PR #16079:
URL: https://github.com/apache/kafka/pull/16079#discussion_r1625072194
##
raft/src/test/java/org/apache/kafka/raft/LeaderStateTest.java:
##
@@ -272,20 +280,77 @@ public void testUpdateHighWatermarkQuorumSizeThree() {
assertEquals(
jsancio commented on code in PR #16079:
URL: https://github.com/apache/kafka/pull/16079#discussion_r1624780684
##
raft/src/main/java/org/apache/kafka/raft/LeaderState.java:
##
@@ -341,9 +346,18 @@ public boolean updateReplicaState(
state.nodeId, currentEndOf
ahuang98 commented on code in PR #16079:
URL: https://github.com/apache/kafka/pull/16079#discussion_r1619298801
##
raft/src/main/java/org/apache/kafka/raft/LeaderState.java:
##
@@ -445,6 +463,27 @@ private boolean isVoter(int remoteNodeId) {
return voterStates.containsK
ahuang98 commented on code in PR #16079:
URL: https://github.com/apache/kafka/pull/16079#discussion_r1619301291
##
raft/src/test/java/org/apache/kafka/raft/LeaderStateTest.java:
##
@@ -103,189 +105,247 @@ public void testNonFollowerAcknowledgement() {
assertThrows(Illeg
ahuang98 commented on code in PR #16079:
URL: https://github.com/apache/kafka/pull/16079#discussion_r1619301291
##
raft/src/test/java/org/apache/kafka/raft/LeaderStateTest.java:
##
@@ -103,189 +105,247 @@ public void testNonFollowerAcknowledgement() {
assertThrows(Illeg
ahuang98 commented on code in PR #16079:
URL: https://github.com/apache/kafka/pull/16079#discussion_r1619298801
##
raft/src/main/java/org/apache/kafka/raft/LeaderState.java:
##
@@ -445,6 +463,27 @@ private boolean isVoter(int remoteNodeId) {
return voterStates.containsK
ahuang98 commented on PR #16079:
URL: https://github.com/apache/kafka/pull/16079#issuecomment-2137996953
This version updates the voter set from a new argument of updateLocalState.
Ideally this would test that the voter set passed in is correct (i.e. we call
`partitionState.lastVoterSet()`
jsancio commented on code in PR #16079:
URL: https://github.com/apache/kafka/pull/16079#discussion_r1616359378
##
raft/src/main/java/org/apache/kafka/raft/LeaderState.java:
##
@@ -243,8 +243,9 @@ private boolean maybeUpdateHighWatermark() {
);
ahuang98 opened a new pull request, #16079:
URL: https://github.com/apache/kafka/pull/16079
- Changing log message from error to warn - We may expect the HW calculation
to give us a smaller result than the current HW in the case of quorum
reconfiguration. We will continue to _not_ allow the
21 matches
Mail list logo
