brenden20 closed pull request #16115: KAFKA-16557 Implemented
OffsetFetchRequestState toStringBase and added a test for it in
CommitRequestManagerTest
URL: https://github.com/apache/kafka/pull/16115
--
This is an automated message from the Apache Git Service.
To respond to the message, pleas
brenden20 commented on PR #16115:
URL: https://github.com/apache/kafka/pull/16115#issuecomment-2161514723
Had a lot of merge issues, was taking too much time to fix so I made a new
branch with my changes. New PR is here:
https://github.com/apache/kafka/pull/16291
--
This is an automated
brenden20 commented on code in PR #16115:
URL: https://github.com/apache/kafka/pull/16115#discussion_r1633783863
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/CommitRequestManagerTest.java:
##
@@ -123,6 +124,50 @@ public void setup() {
this.props.
philipnee commented on code in PR #16115:
URL: https://github.com/apache/kafka/pull/16115#discussion_r1632136312
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/CommitRequestManagerTest.java:
##
@@ -123,6 +124,50 @@ public void setup() {
this.props.
philipnee commented on code in PR #16115:
URL: https://github.com/apache/kafka/pull/16115#discussion_r1632136312
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/CommitRequestManagerTest.java:
##
@@ -123,6 +124,50 @@ public void setup() {
this.props.
brenden20 commented on PR #16115:
URL: https://github.com/apache/kafka/pull/16115#issuecomment-2150682316
Marked ready to review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comme
philipnee commented on code in PR #16115:
URL: https://github.com/apache/kafka/pull/16115#discussion_r1624598671
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/CommitRequestManagerTest.java:
##
@@ -123,6 +123,46 @@ public void setup() {
this.props.
brenden20 commented on code in PR #16115:
URL: https://github.com/apache/kafka/pull/16115#discussion_r1624585035
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/CommitRequestManagerTest.java:
##
@@ -123,6 +123,46 @@ public void setup() {
this.props.
philipnee commented on code in PR #16115:
URL: https://github.com/apache/kafka/pull/16115#discussion_r1624583148
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/CommitRequestManagerTest.java:
##
@@ -123,6 +123,46 @@ public void setup() {
this.props.
brenden20 commented on code in PR #16115:
URL: https://github.com/apache/kafka/pull/16115#discussion_r1624577785
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/CommitRequestManagerTest.java:
##
@@ -123,6 +123,46 @@ public void setup() {
this.props.
philipnee commented on code in PR #16115:
URL: https://github.com/apache/kafka/pull/16115#discussion_r1624575007
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/CommitRequestManagerTest.java:
##
@@ -123,6 +123,46 @@ public void setup() {
this.props.
brenden20 commented on PR #16115:
URL: https://github.com/apache/kafka/pull/16115#issuecomment-2145353574
@philipnee I have implemented all suggested changes except for the
whitespace issue, I am going to use Emacs to try to figure it out
--
This is an automated message from the Apache Gi
philipnee commented on PR #16115:
URL: https://github.com/apache/kafka/pull/16115#issuecomment-2144015771
hi @brenden20 - left some comments. lmk what do you think.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
U
philipnee commented on code in PR #16115:
URL: https://github.com/apache/kafka/pull/16115#discussion_r1623645517
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/CommitRequestManagerTest.java:
##
@@ -123,6 +126,47 @@ public void setup() {
this.props.
philipnee commented on code in PR #16115:
URL: https://github.com/apache/kafka/pull/16115#discussion_r1623644884
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/CommitRequestManagerTest.java:
##
@@ -106,6 +106,9 @@ public class CommitRequestManagerTest {
philipnee commented on code in PR #16115:
URL: https://github.com/apache/kafka/pull/16115#discussion_r1623644884
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/CommitRequestManagerTest.java:
##
@@ -106,6 +106,9 @@ public class CommitRequestManagerTest {
philipnee commented on code in PR #16115:
URL: https://github.com/apache/kafka/pull/16115#discussion_r1623644470
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java:
##
@@ -1289,5 +1293,11 @@ static class MemberInfo {
this.
philipnee commented on code in PR #16115:
URL: https://github.com/apache/kafka/pull/16115#discussion_r1623382628
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/CommitRequestManagerTest.java:
##
@@ -123,6 +126,47 @@ public void setup() {
this.props.
philipnee commented on code in PR #16115:
URL: https://github.com/apache/kafka/pull/16115#discussion_r1623382520
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/CommitRequestManagerTest.java:
##
@@ -123,6 +126,47 @@ public void setup() {
this.props.
philipnee commented on code in PR #16115:
URL: https://github.com/apache/kafka/pull/16115#discussion_r1623382281
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/CommitRequestManagerTest.java:
##
@@ -123,6 +126,47 @@ public void setup() {
this.props.
philipnee commented on code in PR #16115:
URL: https://github.com/apache/kafka/pull/16115#discussion_r1623381407
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/CommitRequestManagerTest.java:
##
@@ -123,6 +126,47 @@ public void setup() {
this.props.
philipnee commented on code in PR #16115:
URL: https://github.com/apache/kafka/pull/16115#discussion_r1623380991
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/CommitRequestManagerTest.java:
##
@@ -227,8 +275,8 @@ public void testPollEnsureEmptyPendingReque
kirktrue commented on PR #16115:
URL: https://github.com/apache/kafka/pull/16115#issuecomment-2140747685
@brenden20, as mentioned on another one of your PRs, there's a checkstyle
violation here. You can run this command locally to avoid waiting for the CI
infrastructure to catch it:
brenden20 commented on code in PR #16115:
URL: https://github.com/apache/kafka/pull/16115#discussion_r1618988743
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/CommitRequestManagerTest.java:
##
@@ -227,8 +275,8 @@ public void testPollEnsureEmptyPendingReque
brenden20 commented on code in PR #16115:
URL: https://github.com/apache/kafka/pull/16115#discussion_r1618981478
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java:
##
@@ -1090,14 +1094,15 @@ private void chainFuture(
}
brenden20 commented on code in PR #16115:
URL: https://github.com/apache/kafka/pull/16115#discussion_r1618980252
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java:
##
@@ -880,6 +880,10 @@ boolean retryTimeoutExpired(long currentTimeMs
kirktrue commented on code in PR #16115:
URL: https://github.com/apache/kafka/pull/16115#discussion_r1618028802
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java:
##
@@ -1090,14 +1094,15 @@ private void chainFuture(
}
philipnee commented on code in PR #16115:
URL: https://github.com/apache/kafka/pull/16115#discussion_r1618009088
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java:
##
@@ -880,6 +880,10 @@ boolean retryTimeoutExpired(long currentTimeMs
philipnee commented on code in PR #16115:
URL: https://github.com/apache/kafka/pull/16115#discussion_r1618008417
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/CommitRequestManagerTest.java:
##
@@ -227,8 +275,8 @@ public void testPollEnsureEmptyPendingReque
brenden20 opened a new pull request, #16115:
URL: https://github.com/apache/kafka/pull/16115
I changed OffsetFetchRequestState toString to toStringBase. I also added the
instance fields from OffsetFetchRequestState and RetriableState to the
toStringBase method. Within RetriableState, I also
30 matches
Mail list logo
