chia7712 merged PR #15916:
URL: https://github.com/apache/kafka/pull/15916
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
TaiJuWu commented on code in PR #15916:
URL: https://github.com/apache/kafka/pull/15916#discussion_r1606897632
##
core/src/test/scala/integration/kafka/zk/ZkMigrationIntegrationTest.scala:
##
@@ -64,7 +64,9 @@ import scala.jdk.CollectionConverters._
object
chia7712 commented on code in PR #15916:
URL: https://github.com/apache/kafka/pull/15916#discussion_r1606846442
##
core/src/test/scala/integration/kafka/zk/ZkMigrationIntegrationTest.scala:
##
@@ -64,7 +64,9 @@ import scala.jdk.CollectionConverters._
object
chia7712 commented on PR #15916:
URL: https://github.com/apache/kafka/pull/15916#issuecomment-2119259591
@TaiJuWu Please update all tests using `ClusterTemplate`. For example:
zkClustersForAllMigrationVersions
--
This is an automated message from the Apache Git Service.
To respond to the
TaiJuWu commented on code in PR #15916:
URL: https://github.com/apache/kafka/pull/15916#discussion_r1605682673
##
core/src/test/java/kafka/test/junit/ClusterTestExtensions.java:
##
@@ -122,31 +115,57 @@ public Stream
provideTestTemplateInvocationContex
return
chia7712 commented on code in PR #15916:
URL: https://github.com/apache/kafka/pull/15916#discussion_r1605371498
##
core/src/test/java/kafka/test/ClusterTestExtensionsTest.java:
##
@@ -62,10 +63,10 @@ public class ClusterTestExtensionsTest {
}
// Static methods can
chia7712 commented on code in PR #15916:
URL: https://github.com/apache/kafka/pull/15916#discussion_r1603229776
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/ConsumerGroupCommandTestUtils.java:
##
@@ -71,7 +72,8 @@ static void generator(ClusterGenerator
chia7712 commented on code in PR #15916:
URL: https://github.com/apache/kafka/pull/15916#discussion_r1603194691
##
core/src/test/java/kafka/test/junit/ClusterTestExtensionsUnitTest.java:
##
@@ -33,16 +31,16 @@ public class ClusterTestExtensionsUnitTest {
void
chia7712 commented on code in PR #15916:
URL: https://github.com/apache/kafka/pull/15916#discussion_r1600041904
##
core/src/test/java/kafka/test/annotation/Type.java:
##
@@ -22,30 +22,31 @@
import kafka.test.junit.ZkClusterInvocationContext;
import
chia7712 commented on PR #15916:
URL: https://github.com/apache/kafka/pull/15916#issuecomment-2106746824
@TaiJuWu please fix the conflicts :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
chia7712 commented on code in PR #15916:
URL: https://github.com/apache/kafka/pull/15916#discussion_r1597801203
##
core/src/test/java/kafka/test/junit/ClusterTestExtensions.java:
##
@@ -140,8 +141,38 @@ private void
generateClusterConfigurations(ExtensionContext context,
TaiJuWu commented on code in PR #15916:
URL: https://github.com/apache/kafka/pull/15916#discussion_r1597748792
##
core/src/test/java/kafka/test/junit/ClusterTestExtensions.java:
##
@@ -93,24 +92,19 @@ public Stream
provideTestTemplateInvocationContex
// Process the
TaiJuWu commented on code in PR #15916:
URL: https://github.com/apache/kafka/pull/15916#discussion_r1597748550
##
core/src/test/java/kafka/test/junit/ClusterTestExtensions.java:
##
@@ -140,8 +141,38 @@ private void
generateClusterConfigurations(ExtensionContext context, String
chia7712 commented on code in PR #15916:
URL: https://github.com/apache/kafka/pull/15916#discussion_r1597475237
##
core/src/test/java/kafka/test/annotation/Type.java:
##
@@ -22,44 +22,53 @@
import kafka.test.junit.ZkClusterInvocationContext;
import
TaiJuWu opened a new pull request, #15916:
URL: https://github.com/apache/kafka/pull/15916
*More detailed description of your change,
As title.
*Summary of testing strategy (including rationale)
local test.
### Committer Checklist (excluded from commit message)
- [ ]
15 matches
Mail list logo