omkreddy merged PR #16513:
URL: https://github.com/apache/kafka/pull/16513
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
apoorvmittal10 commented on PR #16513:
URL: https://github.com/apache/kafka/pull/16513#issuecomment-2206307430
@AndrewJSchofield @omkreddy The build passed with unrelated tests failure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
apoorvmittal10 commented on code in PR #16513:
URL: https://github.com/apache/kafka/pull/16513#discussion_r1663843416
##
server/src/main/java/org/apache/kafka/server/share/ShareSessionCache.java:
##
@@ -41,10 +41,10 @@ public class ShareSessionCache {
private long
apoorvmittal10 commented on code in PR #16513:
URL: https://github.com/apache/kafka/pull/16513#discussion_r1663835968
##
core/src/test/java/kafka/server/share/SharePartitionManagerTest.java:
##
@@ -1246,26 +1250,40 @@ public void testCloseSharePartitionManager() throws
AndrewJSchofield commented on code in PR #16513:
URL: https://github.com/apache/kafka/pull/16513#discussion_r1663821656
##
server/src/main/java/org/apache/kafka/server/share/ShareSessionCache.java:
##
@@ -41,10 +41,10 @@ public class ShareSessionCache {
private long
adixitconfluent commented on code in PR #16513:
URL: https://github.com/apache/kafka/pull/16513#discussion_r1663802402
##
core/src/test/java/kafka/server/share/SharePartitionManagerTest.java:
##
@@ -1246,26 +1250,40 @@ public void testCloseSharePartitionManager() throws
apoorvmittal10 commented on PR #16513:
URL: https://github.com/apache/kafka/pull/16513#issuecomment-2205430052
The context: https://github.com/apache/kafka/pull/16456/files#r1662556294
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
apoorvmittal10 opened a new pull request, #16513:
URL: https://github.com/apache/kafka/pull/16513
The release API exposed Partitions which should be an internal
implementation detail for `releaseAcquiredRecords` API. Also lessen the scope
for cached topic partitons method as it's not
