Re: [PR] KAFKA-16788 - Fix resource leakage during connector start() failure [kafka]

2024-07-10 Thread via GitHub
ashoke-cube commented on code in PR #16095: URL: https://github.com/apache/kafka/pull/16095#discussion_r1672075592 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/WorkerConnectorTest.java: ## @@ -134,7 +134,30 @@ public void testInitializeFailure(ConnectorType

Re: [PR] KAFKA-16788 - Fix resource leakage during connector start() failure [kafka]

2024-06-24 Thread via GitHub
ashoke-cube commented on PR #16095: URL: https://github.com/apache/kafka/pull/16095#issuecomment-2186292726 > > Hi @ashoke-cube could you fix the build? Thanks! > > Hey @gharris1727 I looked into the build failure. It is a bit weird. It is failing because it is not able to find the

Re: [PR] KAFKA-16788 - Fix resource leakage during connector start() failure [kafka]

2024-06-23 Thread via GitHub
ashoke-cube commented on PR #16095: URL: https://github.com/apache/kafka/pull/16095#issuecomment-2184736478 > Hi @ashoke-cube could you fix the build? Thanks! Hey @gharris1727 I looked into the build failure. It is a bit weird. It is failing because it is not able to find the junit's

Re: [PR] KAFKA-16788 - Fix resource leakage during connector start() failure [kafka]

2024-06-18 Thread via GitHub
ashoke-cube commented on code in PR #16095: URL: https://github.com/apache/kafka/pull/16095#discussion_r1644974636 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerConnector.java: ## @@ -307,7 +307,7 @@ void doShutdown() {

Re: [PR] KAFKA-16788 - Fix resource leakage during connector start() failure [kafka]

2024-06-18 Thread via GitHub
gharris1727 commented on code in PR #16095: URL: https://github.com/apache/kafka/pull/16095#discussion_r1644895138 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerConnector.java: ## @@ -307,7 +307,7 @@ void doShutdown() {

Re: [PR] KAFKA-16788 - Fix resource leakage during connector start() failure [kafka]

2024-06-18 Thread via GitHub
ashoke-cube commented on code in PR #16095: URL: https://github.com/apache/kafka/pull/16095#discussion_r1644889388 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerConnector.java: ## @@ -307,7 +307,7 @@ void doShutdown() {

Re: [PR] KAFKA-16788 - Fix resource leakage during connector start() failure [kafka]

2024-06-18 Thread via GitHub
gharris1727 commented on code in PR #16095: URL: https://github.com/apache/kafka/pull/16095#discussion_r1644883959 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerConnector.java: ## @@ -307,7 +307,7 @@ void doShutdown() {

Re: [PR] KAFKA-16788 - Fix resource leakage during connector start() failure [kafka]

2024-06-17 Thread via GitHub
gharris1727 commented on code in PR #16095: URL: https://github.com/apache/kafka/pull/16095#discussion_r1643426226 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerConnector.java: ## @@ -231,6 +231,12 @@ private synchronized void onFailure(Throwable t) {

Re: [PR] KAFKA-16788 - Fix resource leakage during connector start() failure [kafka]

2024-06-14 Thread via GitHub
ashoke-cube commented on code in PR #16095: URL: https://github.com/apache/kafka/pull/16095#discussion_r1640754632 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerConnector.java: ## @@ -231,6 +231,12 @@ private synchronized void onFailure(Throwable t) {

Re: [PR] KAFKA-16788 - Fix resource leakage during connector start() failure [kafka]

2024-06-10 Thread via GitHub
ashoke-cube commented on code in PR #16095: URL: https://github.com/apache/kafka/pull/16095#discussion_r1632856777 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerConnector.java: ## @@ -231,6 +231,12 @@ private synchronized void onFailure(Throwable t) {

Re: [PR] KAFKA-16788 - Fix resource leakage during connector start() failure [kafka]

2024-06-10 Thread via GitHub
ashoke-cube commented on code in PR #16095: URL: https://github.com/apache/kafka/pull/16095#discussion_r1632856777 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerConnector.java: ## @@ -231,6 +231,12 @@ private synchronized void onFailure(Throwable t) {

Re: [PR] KAFKA-16788 - Fix resource leakage during connector start() failure [kafka]

2024-05-30 Thread via GitHub
gharris1727 commented on code in PR #16095: URL: https://github.com/apache/kafka/pull/16095#discussion_r1621349710 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerConnector.java: ## @@ -231,6 +231,12 @@ private synchronized void onFailure(Throwable t) {

[PR] KAFKA-16788 - Fix resource leakage during connector start() failure [kafka]

2024-05-27 Thread via GitHub
ashoke-cube opened a new pull request, #16095: URL: https://github.com/apache/kafka/pull/16095 This PR fixes the resource leakage that occurs when connector `start()` results in a failure. `close()` on the connector is not called and this leads to the leakage of the connector's resources