Re: [PR] KAFKA-16909 Refactor GroupCoordinatorConfig with AbstractConfig [kafka]

2024-07-04 Thread via GitHub
dajac commented on PR #16458: URL: https://github.com/apache/kafka/pull/16458#issuecomment-2209037345 @chia7712 Thanks. Sounds good to me! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

Re: [PR] KAFKA-16909 Refactor GroupCoordinatorConfig with AbstractConfig [kafka]

2024-07-04 Thread via GitHub
chia7712 commented on PR #16458: URL: https://github.com/apache/kafka/pull/16458#issuecomment-2208789405 @brandboat I open https://issues.apache.org/jira/browse/KAFKA-17081 as follow-up. And it is assigned to you. PLEASE feel free to assign it back to me if you have no bandwidth -- This

Re: [PR] KAFKA-16909 Refactor GroupCoordinatorConfig with AbstractConfig [kafka]

2024-07-03 Thread via GitHub
chia7712 commented on PR #16458: URL: https://github.com/apache/kafka/pull/16458#issuecomment-220683 I double-check all configs and yes all of them are not dynamic. Maybe we don't need to be over-engineering for now. Hence, we can have a PR for following changes. 1. re-introduce

Re: [PR] KAFKA-16909 Refactor GroupCoordinatorConfig with AbstractConfig [kafka]

2024-07-03 Thread via GitHub
dajac commented on code in PR #16458: URL: https://github.com/apache/kafka/pull/16458#discussion_r1663919753 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorConfig.java: ## @@ -297,61 +333,92 @@ public class GroupCoordinatorConfig { *

Re: [PR] KAFKA-16909 Refactor GroupCoordinatorConfig with AbstractConfig [kafka]

2024-07-03 Thread via GitHub
dajac commented on code in PR #16458: URL: https://github.com/apache/kafka/pull/16458#discussion_r1663920778 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorConfig.java: ## @@ -297,61 +333,92 @@ public class GroupCoordinatorConfig { *