Re: [PR] KAFKA-16968: Make 3.8-IV0 a stable MetadataVersion and create 3.9-IV0 [kafka]

junrao commented on code in PR #16347: URL: https://github.com/apache/kafka/pull/16347#discussion_r1645128202 ## tools/src/test/java/org/apache/kafka/tools/FeatureCommandTest.java: ## @@ -146,7 +146,7 @@ public void testDowngradeMetadataVersionWithKRaft(ClusterInstance

Re: [PR] KAFKA-16968: Make 3.8-IV0 a stable MetadataVersion and create 3.9-IV0 [kafka]

cmccabe commented on code in PR #16347: URL: https://github.com/apache/kafka/pull/16347#discussion_r1644941547 ## server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java: ## @@ -202,11 +202,20 @@ public enum MetadataVersion { // Add new fetch

Re: [PR] KAFKA-16968: Make 3.8-IV0 a stable MetadataVersion and create 3.9-IV0 [kafka]

cmccabe commented on code in PR #16347: URL: https://github.com/apache/kafka/pull/16347#discussion_r1644940428 ## server-common/src/test/java/org/apache/kafka/server/common/FeaturesTest.java: ## @@ -110,7 +110,7 @@ public void

Re: [PR] KAFKA-16968: Make 3.8-IV0 a stable MetadataVersion and create 3.9-IV0 [kafka]

cmccabe commented on code in PR #16347: URL: https://github.com/apache/kafka/pull/16347#discussion_r1644937626 ## server-common/src/test/java/org/apache/kafka/server/common/MetadataVersionTest.java: ## @@ -184,8 +184,11 @@ public void testFromVersionString() {

Re: [PR] KAFKA-16968: Make 3.8-IV0 a stable MetadataVersion and create 3.9-IV0 [kafka]

cmccabe commented on code in PR #16347: URL: https://github.com/apache/kafka/pull/16347#discussion_r1644936406 ## metadata/src/test/java/org/apache/kafka/metadata/PartitionRegistrationTest.java: ## @@ -371,7 +371,7 @@ public void

Re: [PR] KAFKA-16968: Make 3.8-IV0 a stable MetadataVersion and create 3.9-IV0 [kafka]

cmccabe commented on code in PR #16347: URL: https://github.com/apache/kafka/pull/16347#discussion_r1644935988 ## core/src/test/scala/integration/kafka/zk/ZkMigrationIntegrationTest.scala: ## @@ -73,7 +73,7 @@ object ZkMigrationIntegrationTest {

Re: [PR] KAFKA-16968: Make 3.8-IV0 a stable MetadataVersion and create 3.9-IV0 [kafka]

cmccabe commented on code in PR #16347: URL: https://github.com/apache/kafka/pull/16347#discussion_r1644934445 ## tools/src/test/java/org/apache/kafka/tools/FeatureCommandTest.java: ## @@ -321,4 +321,4 @@ public void testHandleDisableDryRun() { "Can not disable

Re: [PR] KAFKA-16968: Make 3.8-IV0 a stable MetadataVersion and create 3.9-IV0 [kafka]

cmccabe commented on code in PR #16347: URL: https://github.com/apache/kafka/pull/16347#discussion_r1644933858 ## core/src/test/scala/unit/kafka/server/ApiVersionsRequestTest.scala: ## @@ -47,7 +47,7 @@ object ApiVersionsRequestTest { List(ClusterConfig.defaultBuilder()

Re: [PR] KAFKA-16968: Make 3.8-IV0 a stable MetadataVersion and create 3.9-IV0 [kafka]

cmccabe commented on code in PR #16347: URL: https://github.com/apache/kafka/pull/16347#discussion_r1644933588 ## server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java: ## @@ -331,7 +340,7 @@ public boolean isDirectoryAssignmentSupported() { }

Re: [PR] KAFKA-16968: Make 3.8-IV0 a stable MetadataVersion and create 3.9-IV0 [kafka]

junrao commented on code in PR #16347: URL: https://github.com/apache/kafka/pull/16347#discussion_r1644931539 ## server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java: ## @@ -202,11 +202,20 @@ public enum MetadataVersion { // Add new fetch request

Re: [PR] KAFKA-16968: Make 3.8-IV0 a stable MetadataVersion and create 3.9-IV0 [kafka]

cmccabe commented on code in PR #16347: URL: https://github.com/apache/kafka/pull/16347#discussion_r1644931292 ## clients/src/main/resources/common/message/ListOffsetsRequest.json: ## @@ -34,9 +34,12 @@ // Version 7 enables listing offsets by max timestamp (KIP-734). //

Re: [PR] KAFKA-16968: Make 3.8-IV0 a stable MetadataVersion and create 3.9-IV0 [kafka]

junrao commented on code in PR #16347: URL: https://github.com/apache/kafka/pull/16347#discussion_r1644855151 ## server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java: ## @@ -331,7 +340,7 @@ public boolean isDirectoryAssignmentSupported() { }

Re: [PR] KAFKA-16968: Make 3.8-IV0 a stable MetadataVersion and create 3.9-IV0 [kafka]

cmccabe commented on PR #16347: URL: https://github.com/apache/kafka/pull/16347#issuecomment-2176593301 @junrao @clolov @dajac @jlprat : It seems like the client side of the KIP-1005 changes is not implemented. So I would propose we revert #15213 from 3.8 since the KIP is only

Re: [PR] KAFKA-16968: Make 3.8-IV0 a stable MetadataVersion and create 3.9-IV0 [kafka]

junrao commented on PR #16347: URL: https://github.com/apache/kafka/pull/16347#issuecomment-2176493383 > Maybe someone can explain more about what https://github.com/apache/kafka/pull/15673 does exactly. @cmccabe : The main issue that https://github.com/apache/kafka/pull/15673 fixes

Re: [PR] KAFKA-16968: Make 3.8-IV0 a stable MetadataVersion and create 3.9-IV0 [kafka]

cmccabe commented on PR #16347: URL: https://github.com/apache/kafka/pull/16347#issuecomment-2176365238 @dajac Just pushed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] KAFKA-16968: Make 3.8-IV0 a stable MetadataVersion and create 3.9-IV0 [kafka]

dajac commented on PR #16347: URL: https://github.com/apache/kafka/pull/16347#issuecomment-2176354721 @cmccabe I don't see the last changes. Did you push? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] KAFKA-16968: Make 3.8-IV0 a stable MetadataVersion and create 3.9-IV0 [kafka]

cmccabe commented on code in PR #16347: URL: https://github.com/apache/kafka/pull/16347#discussion_r1644427304 ## server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java: ## @@ -202,11 +202,20 @@ public enum MetadataVersion { // Add new fetch

Re: [PR] KAFKA-16968: Make 3.8-IV0 a stable MetadataVersion and create 3.9-IV0 [kafka]

cmccabe commented on code in PR #16347: URL: https://github.com/apache/kafka/pull/16347#discussion_r1644425919 ## server-common/src/main/java/org/apache/kafka/server/common/GroupVersion.java: ## @@ -22,7 +22,7 @@ public enum GroupVersion implements FeatureVersion { //

Re: [PR] KAFKA-16968: Make 3.8-IV0 a stable MetadataVersion and create 3.9-IV0 [kafka]

cmccabe commented on PR #16347: URL: https://github.com/apache/kafka/pull/16347#issuecomment-2176042112 > @cmccabe : https://github.com/apache/kafka/pull/15673 is fixing a mistake that shouldn't be in 3.8.0. We should have bumped up the API version for ListOffset, but we didn't. To me,

Re: [PR] KAFKA-16968: Make 3.8-IV0 a stable MetadataVersion and create 3.9-IV0 [kafka]

dajac commented on code in PR #16347: URL: https://github.com/apache/kafka/pull/16347#discussion_r1644109817 ## server-common/src/main/java/org/apache/kafka/server/common/GroupVersion.java: ## @@ -22,7 +22,7 @@ public enum GroupVersion implements FeatureVersion { //

Re: [PR] KAFKA-16968: Make 3.8-IV0 a stable MetadataVersion and create 3.9-IV0 [kafka]

jlprat commented on PR #16347: URL: https://github.com/apache/kafka/pull/16347#issuecomment-2175231482 hi @junrao I marked https://issues.apache.org/jira/projects/KAFKA/issues/KAFKA-16480 as a blocker for 3.8 -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] KAFKA-16968: Make 3.8-IV0 a stable MetadataVersion and create 3.9-IV0 [kafka]

junrao commented on PR #16347: URL: https://github.com/apache/kafka/pull/16347#issuecomment-2174646474 @cmccabe : https://github.com/apache/kafka/pull/15673 is fixing a mistake that shouldn't be in 3.8.0. We should have bumped up the API version for ListOffset, but we didn't. To me, that

Re: [PR] KAFKA-16968: Make 3.8-IV0 a stable MetadataVersion and create 3.9-IV0 [kafka]

cmccabe commented on code in PR #16347: URL: https://github.com/apache/kafka/pull/16347#discussion_r1643463801 ## server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java: ## @@ -202,11 +202,12 @@ public enum MetadataVersion { // Add new fetch

Re: [PR] KAFKA-16968: Make 3.8-IV0 a stable MetadataVersion and create 3.9-IV0 [kafka]

cmccabe commented on code in PR #16347: URL: https://github.com/apache/kafka/pull/16347#discussion_r1643441501 ## server-common/src/main/java/org/apache/kafka/server/common/GroupVersion.java: ## @@ -22,7 +22,7 @@ public enum GroupVersion implements FeatureVersion { //

Re: [PR] KAFKA-16968: Make 3.8-IV0 a stable MetadataVersion and create 3.9-IV0 [kafka]

cmccabe commented on PR #16347: URL: https://github.com/apache/kafka/pull/16347#issuecomment-2174438309 > @cmccabe @AndrewJSchofield @dajac , there is another PR adding a new metadata version of 3.8.IV1(it will be the next production ready MV), it also tries to move KIP-966 from 3.8IV0 to

Re: [PR] KAFKA-16968: Make 3.8-IV0 a stable MetadataVersion and create 3.9-IV0 [kafka]

cmccabe commented on code in PR #16347: URL: https://github.com/apache/kafka/pull/16347#discussion_r1643436916 ## server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java: ## @@ -232,7 +233,7 @@ public enum MetadataVersion { * Think carefully before

Re: [PR] KAFKA-16968: Make 3.8-IV0 a stable MetadataVersion and create 3.9-IV0 [kafka]

CalvinConfluent commented on PR #16347: URL: https://github.com/apache/kafka/pull/16347#issuecomment-2173868554 @cmccabe @AndrewJSchofield @dajac , there is another PR adding a new metadata version of 3.8.IV1(it will be the next production ready MV), it also tries to move KIP-966 from

Re: [PR] KAFKA-16968: Make 3.8-IV0 a stable MetadataVersion and create 3.9-IV0 [kafka]

AndrewJSchofield commented on code in PR #16347: URL: https://github.com/apache/kafka/pull/16347#discussion_r1642456703 ## server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java: ## @@ -232,7 +233,7 @@ public enum MetadataVersion { * Think

Re: [PR] KAFKA-16968: Make 3.8-IV0 a stable MetadataVersion and create 3.9-IV0 [kafka]

AndrewJSchofield commented on code in PR #16347: URL: https://github.com/apache/kafka/pull/16347#discussion_r1642454880 ## server-common/src/main/java/org/apache/kafka/server/common/GroupVersion.java: ## @@ -22,7 +22,7 @@ public enum GroupVersion implements FeatureVersion {

Re: [PR] KAFKA-16968: Make 3.8-IV0 a stable MetadataVersion and create 3.9-IV0 [kafka]

jlprat commented on PR #16347: URL: https://github.com/apache/kafka/pull/16347#issuecomment-2172726481 Thanks @dajac! Let's get this to 3.8 once merged -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] KAFKA-16968: Make 3.8-IV0 a stable MetadataVersion and create 3.9-IV0 [kafka]

dajac commented on PR #16347: URL: https://github.com/apache/kafka/pull/16347#issuecomment-2172721012 cc @jlprat We need this on in 3.8. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] KAFKA-16968: Make 3.8-IV0 a stable MetadataVersion and create 3.9-IV0 [kafka]

dajac commented on code in PR #16347: URL: https://github.com/apache/kafka/pull/16347#discussion_r1642442783 ## server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java: ## @@ -202,11 +202,12 @@ public enum MetadataVersion { // Add new fetch request