Re: [PR] KAFKA-17003: Implemented SharePartitionManager close() functionality [kafka]

2024-06-24 Thread via GitHub
adixitconfluent commented on code in PR #16431: URL: https://github.com/apache/kafka/pull/16431#discussion_r1650928682 ## core/src/test/java/kafka/server/share/SharePartitionManagerTest.java: ## @@ -1221,6 +1224,36 @@ public void testReplicaManagerFetchShouldProceed() {

Re: [PR] KAFKA-17003: Implemented SharePartitionManager close() functionality [kafka]

2024-06-24 Thread via GitHub
adixitconfluent commented on code in PR #16431: URL: https://github.com/apache/kafka/pull/16431#discussion_r1650969451 ## core/src/test/java/kafka/server/share/SharePartitionManagerTest.java: ## @@ -1221,6 +1224,36 @@ public void testReplicaManagerFetchShouldProceed() {

Re: [PR] KAFKA-17003: Implemented SharePartitionManager close() functionality [kafka]

2024-06-24 Thread via GitHub
adixitconfluent commented on code in PR #16431: URL: https://github.com/apache/kafka/pull/16431#discussion_r1650969451 ## core/src/test/java/kafka/server/share/SharePartitionManagerTest.java: ## @@ -1221,6 +1224,36 @@ public void testReplicaManagerFetchShouldProceed() {

Re: [PR] KAFKA-17003: Implemented SharePartitionManager close() functionality [kafka]

2024-06-24 Thread via GitHub
adixitconfluent commented on code in PR #16431: URL: https://github.com/apache/kafka/pull/16431#discussion_r1650969451 ## core/src/test/java/kafka/server/share/SharePartitionManagerTest.java: ## @@ -1221,6 +1224,36 @@ public void testReplicaManagerFetchShouldProceed() {

Re: [PR] KAFKA-17003: Implemented SharePartitionManager close() functionality [kafka]

2024-06-24 Thread via GitHub
adixitconfluent commented on code in PR #16431: URL: https://github.com/apache/kafka/pull/16431#discussion_r1650931188 ## core/src/test/java/kafka/server/share/SharePartitionManagerTest.java: ## @@ -1221,6 +1224,36 @@ public void testReplicaManagerFetchShouldProceed() {

Re: [PR] KAFKA-17003: Implemented SharePartitionManager close() functionality [kafka]

2024-06-24 Thread via GitHub
adixitconfluent commented on code in PR #16431: URL: https://github.com/apache/kafka/pull/16431#discussion_r1650928682 ## core/src/test/java/kafka/server/share/SharePartitionManagerTest.java: ## @@ -1221,6 +1224,36 @@ public void testReplicaManagerFetchShouldProceed() {

Re: [PR] KAFKA-17003: Implemented SharePartitionManager close() functionality [kafka]

2024-06-24 Thread via GitHub
apoorvmittal10 commented on code in PR #16431: URL: https://github.com/apache/kafka/pull/16431#discussion_r1650896425 ## core/src/test/java/kafka/server/share/SharePartitionManagerTest.java: ## @@ -1221,6 +1224,36 @@ public void testReplicaManagerFetchShouldProceed() {

[PR] KAFKA-17003: Implemented SharePartitionManager close() functionality [kafka]

2024-06-24 Thread via GitHub
adixitconfluent opened a new pull request, #16431: URL: https://github.com/apache/kafka/pull/16431 ### About Implemented close() functionality of SharePartitionManager to avoid any chances of memory leak. The functionality will be utilized when the `sharePartitionObject` is closed, at