Re: [PR] KIP-951: protocol changes [kafka]

chb2ab commented on code in PR #14627: URL: https://github.com/apache/kafka/pull/14627#discussion_r1373265206 ## clients/src/main/resources/common/message/FetchRequest.json: ## @@ -53,7 +53,9 @@ // // Version 15 adds the ReplicaState which includes new field ReplicaEpoch

Re: [PR] KIP-951: protocol changes [kafka]

chb2ab commented on code in PR #14627: URL: https://github.com/apache/kafka/pull/14627#discussion_r1373258152 ## clients/src/main/resources/common/message/FetchResponse.json: ## @@ -45,7 +45,9 @@ // Version 14 is the same as version 13 but it also receives a new error called

Re: [PR] KIP-951: protocol changes [kafka]

chb2ab commented on code in PR #14627: URL: https://github.com/apache/kafka/pull/14627#discussion_r1373245183 ## clients/src/main/resources/common/message/FetchResponse.json: ## @@ -102,6 +104,15 @@ "about": "The preferred read replica for the consumer to use on its

Re: [PR] KIP-951: protocol changes [kafka]

chb2ab commented on code in PR #14627: URL: https://github.com/apache/kafka/pull/14627#discussion_r1373238109 ## server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java: ## @@ -360,7 +360,9 @@ public short partitionRecordVersion() { } public s

Re: [PR] KIP-951: protocol changes [kafka]

msn-tldr commented on PR #14627: URL: https://github.com/apache/kafka/pull/14627#issuecomment-1780966602 @chb2ab CMIIW, but @jolshan i think scope of the PR is just protocol changes, not server-side changes. Intention is to merge the protocol-changes soon, so client-side changes can also be

Re: [PR] KIP-951: protocol changes [kafka]

jolshan commented on code in PR #14627: URL: https://github.com/apache/kafka/pull/14627#discussion_r1372394072 ## server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java: ## @@ -360,7 +360,9 @@ public short partitionRecordVersion() { } public

Re: [PR] KIP-951: protocol changes [kafka]

jolshan commented on code in PR #14627: URL: https://github.com/apache/kafka/pull/14627#discussion_r1372393724 ## clients/src/main/resources/common/message/FetchRequest.json: ## @@ -53,7 +53,9 @@ // // Version 15 adds the ReplicaState which includes new field ReplicaEpoch

Re: [PR] KIP-951: protocol changes [kafka]

jolshan commented on code in PR #14627: URL: https://github.com/apache/kafka/pull/14627#discussion_r1372392217 ## clients/src/main/resources/common/message/FetchResponse.json: ## @@ -102,6 +104,15 @@ "about": "The preferred read replica for the consumer to use on its

Re: [PR] KIP-951: protocol changes [kafka]

jolshan commented on code in PR #14627: URL: https://github.com/apache/kafka/pull/14627#discussion_r1372391952 ## clients/src/main/resources/common/message/FetchResponse.json: ## @@ -45,7 +45,9 @@ // Version 14 is the same as version 13 but it also receives a new error calle

Re: [PR] KIP-951: protocol changes [kafka]

jolshan commented on PR #14627: URL: https://github.com/apache/kafka/pull/14627#issuecomment-1780155389 Hey there. If this is KAFKA-15661, then the title of the PR should be `KAFKA-15661: KIP-951: Server side and protocol changes` -- This is an automated message from the Apache Git Ser

Re: [PR] KIP-951: protocol changes [kafka]

msn-tldr commented on PR #14627: URL: https://github.com/apache/kafka/pull/14627#issuecomment-1778870153 @chb2ab lgtm, thanks for raising this! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[PR] KIP-951: protocol changes [kafka]

chb2ab opened a new pull request, #14627: URL: https://github.com/apache/kafka/pull/14627 Separating out the protocol changes from https://github.com/apache/kafka/pull/1 in an effort to more quickly unblock the client side PR. https://cwiki.apache.org/confluence/display/KAFKA/KI