Re: [PR] KIP-988 [kafka]

2023-11-13 Thread via GitHub
ableegoldman commented on code in PR #14735: URL: https://github.com/apache/kafka/pull/14735#discussion_r1391815838 ## streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java: ## @@ -580,6 +583,17 @@ public void setGlobalStateRestoreListener(final StateRestoreListener

Re: [PR] KIP-988 [kafka]

2023-11-13 Thread via GitHub
ableegoldman commented on code in PR #14735: URL: https://github.com/apache/kafka/pull/14735#discussion_r1391848915 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/StoreChangelogReader.java: ## @@ -1012,6 +1022,8 @@ private void prepareChangelogs(final Map

Re: [PR] KIP-988 [kafka]

2023-11-13 Thread via GitHub
ableegoldman commented on code in PR #14735: URL: https://github.com/apache/kafka/pull/14735#discussion_r1391818555 ## streams/src/main/java/org/apache/kafka/streams/processor/StandbyUpdateListener.java: ## @@ -0,0 +1,80 @@ +/* + * Licensed to the Apache Software Foundation (ASF

Re: [PR] KIP-988 [kafka]

2023-11-13 Thread via GitHub
ableegoldman commented on code in PR #14735: URL: https://github.com/apache/kafka/pull/14735#discussion_r1391822284 ## streams/src/main/java/org/apache/kafka/streams/processor/StandbyUpdateListener.java: ## @@ -0,0 +1,80 @@ +/* + * Licensed to the Apache Software Foundation (ASF

Re: [PR] KIP-988 [kafka]

2023-11-13 Thread via GitHub
ableegoldman commented on code in PR #14735: URL: https://github.com/apache/kafka/pull/14735#discussion_r1391818555 ## streams/src/main/java/org/apache/kafka/streams/processor/StandbyUpdateListener.java: ## @@ -0,0 +1,80 @@ +/* + * Licensed to the Apache Software Foundation (ASF

Re: [PR] KIP-988 [kafka]

2023-11-13 Thread via GitHub
ableegoldman commented on PR #14735: URL: https://github.com/apache/kafka/pull/14735#issuecomment-1809299774 I'll take a look! In the meantime, can you format the PR title with the ticket number? I thought we had a guide on this somewhere but I can't find it mentioned anywhere 😞 Anyways, it

Re: [PR] KIP-988 [kafka]

2023-11-13 Thread via GitHub
eduwercamacaro commented on code in PR #14735: URL: https://github.com/apache/kafka/pull/14735#discussion_r1391293607 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java: ## @@ -70,6 +71,7 @@ import static org.apache.kafka.streams.internals.S

Re: [PR] KIP-988 [kafka]

2023-11-11 Thread via GitHub
coltmcnealy-lh commented on PR #14735: URL: https://github.com/apache/kafka/pull/14735#issuecomment-1806946706 @ableegoldman or @mjsax , any chance you could help review this? I'm pretty unqualified on many levels :smile: -- This is an automated message from the Apache Git Service. To re

[PR] KIP-988 [kafka]

2023-11-10 Thread via GitHub
eduwercamacaro opened a new pull request, #14735: URL: https://github.com/apache/kafka/pull/14735 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary of