Re: [PR] MINOR: Allow local-log segment deletion when log-start-offset incremented [kafka]

2023-12-06 Thread via GitHub
satishd merged PR #14905: URL: https://github.com/apache/kafka/pull/14905 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

Re: [PR] MINOR: Allow local-log segment deletion when log-start-offset incremented [kafka]

2023-12-06 Thread via GitHub
satishd commented on PR #14905: URL: https://github.com/apache/kafka/pull/14905#issuecomment-1842685829 Jenkins test failures are unrelated to this PR, merging it to trunk. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

Re: [PR] MINOR: Allow local-log segment deletion when log-start-offset incremented [kafka]

2023-12-06 Thread via GitHub
satishd commented on code in PR #14905: URL: https://github.com/apache/kafka/pull/14905#discussion_r1417134578 ## core/src/main/scala/kafka/log/UnifiedLog.scala: ## @@ -1443,11 +1443,14 @@ class UnifiedLog(@volatile var logStartOffset: Long, * @return the segments ready to b

Re: [PR] MINOR: Allow local-log segment deletion when log-start-offset incremented [kafka]

2023-12-05 Thread via GitHub
kamalcph commented on PR #14905: URL: https://github.com/apache/kafka/pull/14905#issuecomment-1842245405 > Does that mean currently, when the log start offset incremented over the candidate segments, we won't delete until the segments are uploaded to the remote storage? The loca

[PR] MINOR: Allow local-log segment deletion when log-start-offset incremented [kafka]

2023-12-03 Thread via GitHub
kamalcph opened a new pull request, #14905: URL: https://github.com/apache/kafka/pull/14905 `DELETE_RECORDS` API can move the log-start-offset beyond the highest-copied-remote-offset. In such cases, we should allow deletion of local-log segments since they are not eligible for upload to rem