chia7712 merged PR #15908:
URL: https://github.com/apache/kafka/pull/15908
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
FrankYang0529 commented on code in PR #15908:
URL: https://github.com/apache/kafka/pull/15908#discussion_r1641165864
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/DescribeConsumerGroupTest.java:
##
@@ -16,834 +16,986 @@
*/
package org.apache.kafka.tools.consume
chia7712 commented on code in PR #15908:
URL: https://github.com/apache/kafka/pull/15908#discussion_r1640136697
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/DescribeConsumerGroupTest.java:
##
@@ -16,834 +16,986 @@
*/
package org.apache.kafka.tools.consumer.gro
chia7712 commented on code in PR #15908:
URL: https://github.com/apache/kafka/pull/15908#discussion_r1640133745
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/DescribeConsumerGroupTest.java:
##
@@ -16,834 +16,986 @@
*/
package org.apache.kafka.tools.consumer.gro
FrankYang0529 commented on PR #15908:
URL: https://github.com/apache/kafka/pull/15908#issuecomment-2167763518
Hi @chia7712 and @TaiJuWu, I addressed all comments. May you take a look
again? Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, ple
FrankYang0529 commented on code in PR #15908:
URL: https://github.com/apache/kafka/pull/15908#discussion_r1639418996
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/DescribeConsumerGroupTest.java:
##
@@ -16,834 +16,986 @@
*/
package org.apache.kafka.tools.consume
FrankYang0529 commented on code in PR #15908:
URL: https://github.com/apache/kafka/pull/15908#discussion_r1639415070
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/DescribeConsumerGroupTest.java:
##
@@ -16,834 +16,986 @@
*/
package org.apache.kafka.tools.consume
TaiJuWu commented on code in PR #15908:
URL: https://github.com/apache/kafka/pull/15908#discussion_r1639336398
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/DescribeConsumerGroupTest.java:
##
@@ -16,834 +16,986 @@
*/
package org.apache.kafka.tools.consumer.grou
FrankYang0529 commented on code in PR #15908:
URL: https://github.com/apache/kafka/pull/15908#discussion_r1638250075
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/DescribeConsumerGroupTest.java:
##
@@ -16,833 +16,962 @@
*/
package org.apache.kafka.tools.consume
chia7712 commented on code in PR #15908:
URL: https://github.com/apache/kafka/pull/15908#discussion_r1634130364
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/DescribeConsumerGroupTest.java:
##
@@ -16,833 +16,962 @@
*/
package org.apache.kafka.tools.consumer.gro
FrankYang0529 commented on code in PR #15908:
URL: https://github.com/apache/kafka/pull/15908#discussion_r1633346019
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/DescribeConsumerGroupTest.java:
##
@@ -16,88 +16,100 @@
*/
package org.apache.kafka.tools.consumer
chia7712 commented on code in PR #15908:
URL: https://github.com/apache/kafka/pull/15908#discussion_r1632118232
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/DescribeConsumerGroupTest.java:
##
@@ -16,88 +16,100 @@
*/
package org.apache.kafka.tools.consumer.grou
FrankYang0529 commented on PR #15908:
URL: https://github.com/apache/kafka/pull/15908#issuecomment-215601
> @FrankYang0529 please rebase code :)
Thanks for reminder. Rebased it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
chia7712 commented on PR #15908:
URL: https://github.com/apache/kafka/pull/15908#issuecomment-2156005905
@FrankYang0529 please rebase code :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
chia7712 commented on PR #15908:
URL: https://github.com/apache/kafka/pull/15908#issuecomment-2152982252
@FrankYang0529 could you please take a look at failed tests?
```
org.opentest4j.AssertionFailedError: Expected a topic partition assigned to
the single group member for group test.g
FrankYang0529 commented on code in PR #15908:
URL: https://github.com/apache/kafka/pull/15908#discussion_r1625913424
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/DescribeConsumerGroupTest.java:
##
@@ -141,699 +186,857 @@ public void testPrintVersion(String quorum
chia7712 commented on code in PR #15908:
URL: https://github.com/apache/kafka/pull/15908#discussion_r1625904399
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/DescribeConsumerGroupTest.java:
##
@@ -141,699 +186,857 @@ public void testPrintVersion(String quorum) {
FrankYang0529 commented on code in PR #15908:
URL: https://github.com/apache/kafka/pull/15908#discussion_r1625898691
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/DescribeConsumerGroupTest.java:
##
@@ -69,35 +91,60 @@ public class DescribeConsumerGroupTest extends
chia7712 commented on code in PR #15908:
URL: https://github.com/apache/kafka/pull/15908#discussion_r1625889885
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/DescribeConsumerGroupTest.java:
##
@@ -69,35 +91,60 @@ public class DescribeConsumerGroupTest extends
Con
FrankYang0529 commented on code in PR #15908:
URL: https://github.com/apache/kafka/pull/15908#discussion_r1625870476
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/DescribeConsumerGroupTest.java:
##
@@ -69,35 +91,60 @@ public class DescribeConsumerGroupTest extends
FrankYang0529 commented on code in PR #15908:
URL: https://github.com/apache/kafka/pull/15908#discussion_r1625866331
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/DescribeConsumerGroupTest.java:
##
@@ -141,699 +186,857 @@ public void testPrintVersion(String quorum
FrankYang0529 commented on code in PR #15908:
URL: https://github.com/apache/kafka/pull/15908#discussion_r1625866331
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/DescribeConsumerGroupTest.java:
##
@@ -141,699 +186,857 @@ public void testPrintVersion(String quorum
FrankYang0529 commented on code in PR #15908:
URL: https://github.com/apache/kafka/pull/15908#discussion_r1625866331
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/DescribeConsumerGroupTest.java:
##
@@ -141,699 +186,857 @@ public void testPrintVersion(String quorum
FrankYang0529 commented on code in PR #15908:
URL: https://github.com/apache/kafka/pull/15908#discussion_r1625856890
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/DescribeConsumerGroupTest.java:
##
@@ -141,699 +186,857 @@ public void testPrintVersion(String quorum
FrankYang0529 commented on PR #15908:
URL: https://github.com/apache/kafka/pull/15908#issuecomment-2147193649
> @FrankYang0529 Could you please remove `ConsumerGroupCommandTest`? it is
unused now
Yes, removed it. Glad to see most of consumer group tests are migrated.
--
This is an
chia7712 commented on PR #15908:
URL: https://github.com/apache/kafka/pull/15908#issuecomment-2146920803
@FrankYang0529 Could you please remove `ConsumerGroupCommandTest`? it is
unused now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log o
FrankYang0529 commented on PR #15908:
URL: https://github.com/apache/kafka/pull/15908#issuecomment-2145024531
> @FrankYang0529 please fix the conflicts, thanks!
Resolved it. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
chia7712 commented on PR #15908:
URL: https://github.com/apache/kafka/pull/15908#issuecomment-2139564485
@FrankYang0529 please fix the conflicts, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
FrankYang0529 commented on PR #15908:
URL: https://github.com/apache/kafka/pull/15908#issuecomment-2138512364
> > That is why testing time takes longer. In my latest update, I change to
run following cases. Also, in old framework, we started KRAFT server with
group.coordinator.new.enable=tr
chia7712 commented on PR #15908:
URL: https://github.com/apache/kafka/pull/15908#issuecomment-2137946979
> That is why testing time takes longer. In my latest update, I change to
run following cases. Also, in old framework, we started KRAFT server with
group.coordinator.new.enable=true twic
FrankYang0529 commented on code in PR #15908:
URL: https://github.com/apache/kafka/pull/15908#discussion_r1617280168
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/DescribeConsumerGroupTest.java:
##
@@ -16,48 +16,71 @@
*/
package org.apache.kafka.tools.consumer.
TaiJuWu commented on code in PR #15908:
URL: https://github.com/apache/kafka/pull/15908#discussion_r1617235824
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/DescribeConsumerGroupTest.java:
##
@@ -16,48 +16,71 @@
*/
package org.apache.kafka.tools.consumer.group;
FrankYang0529 commented on code in PR #15908:
URL: https://github.com/apache/kafka/pull/15908#discussion_r1614679946
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/DescribeConsumerGroupTest.java:
##
@@ -141,699 +162,773 @@ public void testPrintVersion(String quorum
FrankYang0529 commented on PR #15908:
URL: https://github.com/apache/kafka/pull/15908#issuecomment-2131274897
> One high-level question:
> I found after this change, we increased the test case numbers from 492 ->
660. And the time for this test suite takes form 1h 19m -> 1h 31m. Do we rea
showuon commented on PR #15908:
URL: https://github.com/apache/kafka/pull/15908#issuecomment-2123949904
Forgot to say, thanks for closing all the `ConsumerGroupService` instances.
I can't believe we leak these resources before.
--
This is an automated message from the Apache Git Service.
showuon commented on PR #15908:
URL: https://github.com/apache/kafka/pull/15908#issuecomment-2123948788
One high-level question:
I found after this change, we increased the test case numbers from 492 ->
660. And the time for this test suite takes form 1h 19m -> 1h 31m. Do we really
need
showuon commented on code in PR #15908:
URL: https://github.com/apache/kafka/pull/15908#discussion_r1609296852
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/ConsumerGroupCommandTestUtils.java:
##
@@ -92,6 +94,7 @@ static void generator(ClusterGenerator clusterGene
FrankYang0529 opened a new pull request, #15908:
URL: https://github.com/apache/kafka/pull/15908
By using ClusterTestExtensions, DescribeConsumerGroupTest get get away from
KafkaServerTestHarness dependency.
### Committer Checklist (excluded from commit message)
- [ ] Verify design
38 matches
Mail list logo
