[jira] [Commented] (KAFKA-7481) Consider options for safer upgrade of offset commit value schema

2019-02-12 Thread Ismael Juma (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-7481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16766769#comment-16766769 ] Ismael Juma commented on KAFKA-7481: I would remove the target version and reduce pri

[jira] [Commented] (KAFKA-7481) Consider options for safer upgrade of offset commit value schema

2019-02-11 Thread Matthias J. Sax (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-7481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16765463#comment-16765463 ] Matthias J. Sax commented on KAFKA-7481: [~hachikuji] The corresponding KIP of th

[jira] [Commented] (KAFKA-7481) Consider options for safer upgrade of offset commit value schema

2019-02-01 Thread Matthias J. Sax (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-7481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16758861#comment-16758861 ] Matthias J. Sax commented on KAFKA-7481: [~hachikuji] This is marked as blocker,

[jira] [Commented] (KAFKA-7481) Consider options for safer upgrade of offset commit value schema

2018-11-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-7481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16677334#comment-16677334 ] ASF GitHub Bot commented on KAFKA-7481: --- lindong28 closed pull request #5857: KAFKA

[jira] [Commented] (KAFKA-7481) Consider options for safer upgrade of offset commit value schema

2018-11-01 Thread JIRA
[ https://issues.apache.org/jira/browse/KAFKA-7481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16671625#comment-16671625 ] 点儿郎当 commented on KAFKA-7481: - kafka version1.0 [2018-11-01 21:37:26,250] ERROR [Controller

[jira] [Commented] (KAFKA-7481) Consider options for safer upgrade of offset commit value schema

2018-10-31 Thread Ismael Juma (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-7481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16670137#comment-16670137 ] Ismael Juma commented on KAFKA-7481: Yeah, in my original comment, I was not counting

[jira] [Commented] (KAFKA-7481) Consider options for safer upgrade of offset commit value schema

2018-10-30 Thread Dong Lin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-7481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16669391#comment-16669391 ] Dong Lin commented on KAFKA-7481: - [~ijuma] Yeah this works and this is why I think we ne

[jira] [Commented] (KAFKA-7481) Consider options for safer upgrade of offset commit value schema

2018-10-30 Thread Ismael Juma (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-7481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16669360#comment-16669360 ] Ismael Juma commented on KAFKA-7481: The state where you can roll back is "upgrade bi

[jira] [Commented] (KAFKA-7481) Consider options for safer upgrade of offset commit value schema

2018-10-30 Thread Dong Lin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-7481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16669323#comment-16669323 ] Dong Lin commented on KAFKA-7481: - [~ijuma] Regarding `I am still not sure if there's a l

[jira] [Commented] (KAFKA-7481) Consider options for safer upgrade of offset commit value schema

2018-10-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-7481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16669203#comment-16669203 ] ASF GitHub Bot commented on KAFKA-7481: --- hachikuji opened a new pull request #5857:

[jira] [Commented] (KAFKA-7481) Consider options for safer upgrade of offset commit value schema

2018-10-30 Thread Jason Gustafson (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-7481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16669120#comment-16669120 ] Jason Gustafson commented on KAFKA-7481: I am also in favor of option 1 for the t

[jira] [Commented] (KAFKA-7481) Consider options for safer upgrade of offset commit value schema

2018-10-29 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-7481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16667977#comment-16667977 ] Jun Rao commented on KAFKA-7481: I agree that introducing a new config probably needs mor

[jira] [Commented] (KAFKA-7481) Consider options for safer upgrade of offset commit value schema

2018-10-29 Thread Ismael Juma (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-7481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16667490#comment-16667490 ] Ismael Juma commented on KAFKA-7481: Using KIP-35 to negotiate protocols is something

[jira] [Commented] (KAFKA-7481) Consider options for safer upgrade of offset commit value schema

2018-10-24 Thread Dong Lin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-7481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16663274#comment-16663274 ] Dong Lin commented on KAFKA-7481: - Hey [~ewencp], regarding the change for 2.1.0 release,

[jira] [Commented] (KAFKA-7481) Consider options for safer upgrade of offset commit value schema

2018-10-24 Thread Ewen Cheslack-Postava (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-7481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16663144#comment-16663144 ] Ewen Cheslack-Postava commented on KAFKA-7481: -- [~lindong] I think anything

[jira] [Commented] (KAFKA-7481) Consider options for safer upgrade of offset commit value schema

2018-10-24 Thread Dong Lin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-7481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16662619#comment-16662619 ] Dong Lin commented on KAFKA-7481: - BTW, if we think this the long term solution, then thi

[jira] [Commented] (KAFKA-7481) Consider options for safer upgrade of offset commit value schema

2018-10-24 Thread Dong Lin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-7481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16662610#comment-16662610 ] Dong Lin commented on KAFKA-7481: - After reading through the discussion and thinking thro

[jira] [Commented] (KAFKA-7481) Consider options for safer upgrade of offset commit value schema

2018-10-24 Thread Dong Lin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-7481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16662555#comment-16662555 ] Dong Lin commented on KAFKA-7481: - Thanks [~ewencp] for the suggestion. I agree. Will do

[jira] [Commented] (KAFKA-7481) Consider options for safer upgrade of offset commit value schema

2018-10-24 Thread Ewen Cheslack-Postava (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-7481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16662460#comment-16662460 ] Ewen Cheslack-Postava commented on KAFKA-7481: -- [~lindong] we might just wan

[jira] [Commented] (KAFKA-7481) Consider options for safer upgrade of offset commit value schema

2018-10-23 Thread Dong Lin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-7481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16661482#comment-16661482 ] Dong Lin commented on KAFKA-7481: - I removed 2.1.0 tag so that release.py would generate

[jira] [Commented] (KAFKA-7481) Consider options for safer upgrade of offset commit value schema

2018-10-22 Thread Ewen Cheslack-Postava (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-7481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16659935#comment-16659935 ] Ewen Cheslack-Postava commented on KAFKA-7481: -- [~ijuma] As it stands today,

[jira] [Commented] (KAFKA-7481) Consider options for safer upgrade of offset commit value schema

2018-10-22 Thread Ismael Juma (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-7481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16659227#comment-16659227 ] Ismael Juma commented on KAFKA-7481: The key insight for me is that the the benefit o

[jira] [Commented] (KAFKA-7481) Consider options for safer upgrade of offset commit value schema

2018-10-21 Thread Ewen Cheslack-Postava (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-7481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16658580#comment-16658580 ] Ewen Cheslack-Postava commented on KAFKA-7481: -- [~ijuma] Arguably your sugge

[jira] [Commented] (KAFKA-7481) Consider options for safer upgrade of offset commit value schema

2018-10-20 Thread Ismael Juma (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-7481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16658038#comment-16658038 ] Ismael Juma commented on KAFKA-7481: Thanks for the KIP [~hachikuji], it's very helpf

[jira] [Commented] (KAFKA-7481) Consider options for safer upgrade of offset commit value schema

2018-10-19 Thread Dong Lin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-7481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16657754#comment-16657754 ] Dong Lin commented on KAFKA-7481: - [~hachikuji] Thanks for the quick work on the KIP! The

[jira] [Commented] (KAFKA-7481) Consider options for safer upgrade of offset commit value schema

2018-10-19 Thread Jason Gustafson (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-7481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16657718#comment-16657718 ] Jason Gustafson commented on KAFKA-7481: [~lindong] [~ijuma] For consideration, I

[jira] [Commented] (KAFKA-7481) Consider options for safer upgrade of offset commit value schema

2018-10-19 Thread Dong Lin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-7481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16657635#comment-16657635 ] Dong Lin commented on KAFKA-7481: - Previously I thought that major version indicates 1) m

[jira] [Commented] (KAFKA-7481) Consider options for safer upgrade of offset commit value schema

2018-10-19 Thread Jason Gustafson (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-7481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16657064#comment-16657064 ] Jason Gustafson commented on KAFKA-7481: [~ijuma] I'm not sure if it was the last

[jira] [Commented] (KAFKA-7481) Consider options for safer upgrade of offset commit value schema

2018-10-18 Thread Ismael Juma (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-7481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16656051#comment-16656051 ] Ismael Juma commented on KAFKA-7481: In the past we did a major bump whenever we chan

[jira] [Commented] (KAFKA-7481) Consider options for safer upgrade of offset commit value schema

2018-10-18 Thread Dong Lin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-7481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16656026#comment-16656026 ] Dong Lin commented on KAFKA-7481: - Thanks for the detailed explanation [~hachikuji]. I ag

[jira] [Commented] (KAFKA-7481) Consider options for safer upgrade of offset commit value schema

2018-10-18 Thread Jason Gustafson (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-7481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16655701#comment-16655701 ] Jason Gustafson commented on KAFKA-7481: [~ijuma] [~lindong] Thanks for the respo

[jira] [Commented] (KAFKA-7481) Consider options for safer upgrade of offset commit value schema

2018-10-18 Thread Dong Lin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-7481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16654759#comment-16654759 ] Dong Lin commented on KAFKA-7481: - BTW, this is currently the only blocking issue for 2.1

[jira] [Commented] (KAFKA-7481) Consider options for safer upgrade of offset commit value schema

2018-10-18 Thread Dong Lin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-7481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16654757#comment-16654757 ] Dong Lin commented on KAFKA-7481: - Option 2 sounds good to me. For option 2, it is true t

[jira] [Commented] (KAFKA-7481) Consider options for safer upgrade of offset commit value schema

2018-10-04 Thread Ismael Juma (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-7481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16639095#comment-16639095 ] Ismael Juma commented on KAFKA-7481: Another option would be to introduce a new confi