ashmeet13 commented on code in PR #12988:
URL: https://github.com/apache/kafka/pull/12988#discussion_r1721230587
##
streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java:
##
@@ -1182,41 +1171,59 @@ public class StreamsConfig extends AbstractConfig {
ashmeet13 commented on code in PR #12988:
URL: https://github.com/apache/kafka/pull/12988#discussion_r1720931330
##
streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java:
##
@@ -1500,68 +1516,71 @@ private void validateRackAwarenessConfiguration() {
});
ashmeet13 commented on code in PR #12988:
URL: https://github.com/apache/kafka/pull/12988#discussion_r1720951008
##
streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java:
##
@@ -1500,68 +1507,57 @@ private void validateRackAwarenessConfiguration() {
});
ashmeet13 commented on code in PR #12988:
URL: https://github.com/apache/kafka/pull/12988#discussion_r1720950900
##
streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java:
##
@@ -1500,68 +1507,57 @@ private void validateRackAwarenessConfiguration() {
});
ashmeet13 commented on code in PR #12988:
URL: https://github.com/apache/kafka/pull/12988#discussion_r1720934316
##
streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java:
##
@@ -1500,68 +1507,57 @@ private void validateRackAwarenessConfiguration() {
});
ashmeet13 commented on code in PR #12988:
URL: https://github.com/apache/kafka/pull/12988#discussion_r1720933373
##
streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java:
##
@@ -1500,68 +1516,71 @@ private void validateRackAwarenessConfiguration() {
});
ashmeet13 commented on code in PR #12988:
URL: https://github.com/apache/kafka/pull/12988#discussion_r1720932944
##
streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java:
##
@@ -1751,7 +1774,15 @@ public Map getProducerConfigs(final
String clientId) {
p
ashmeet13 commented on code in PR #12988:
URL: https://github.com/apache/kafka/pull/12988#discussion_r1720931330
##
streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java:
##
@@ -1500,68 +1516,71 @@ private void validateRackAwarenessConfiguration() {
});
ashmeet13 commented on code in PR #12988:
URL: https://github.com/apache/kafka/pull/12988#discussion_r1720931216
##
streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java:
##
@@ -1500,68 +1516,71 @@ private void validateRackAwarenessConfiguration() {
});
ashmeet13 commented on code in PR #12988:
URL: https://github.com/apache/kafka/pull/12988#discussion_r1720931124
##
streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java:
##
@@ -1500,68 +1516,71 @@ private void validateRackAwarenessConfiguration() {
});
ashmeet13 commented on code in PR #12988:
URL: https://github.com/apache/kafka/pull/12988#discussion_r1720931040
##
streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java:
##
@@ -1182,41 +1175,64 @@ public class StreamsConfig extends AbstractConfig {
ashmeet13 commented on code in PR #12988:
URL: https://github.com/apache/kafka/pull/12988#discussion_r1720931028
##
streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java:
##
@@ -1182,41 +1175,64 @@ public class StreamsConfig extends AbstractConfig {
ashmeet13 commented on code in PR #12988:
URL: https://github.com/apache/kafka/pull/12988#discussion_r1720931177
##
streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java:
##
@@ -1500,68 +1516,71 @@ private void validateRackAwarenessConfiguration() {
});
ashmeet13 commented on code in PR #12988:
URL: https://github.com/apache/kafka/pull/12988#discussion_r1720931089
##
streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java:
##
@@ -1500,68 +1516,71 @@ private void validateRackAwarenessConfiguration() {
});
ashmeet13 commented on code in PR #12988:
URL: https://github.com/apache/kafka/pull/12988#discussion_r1720930932
##
streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java:
##
@@ -1182,41 +1175,64 @@ public class StreamsConfig extends AbstractConfig {
ashmeet13 commented on code in PR #12988:
URL: https://github.com/apache/kafka/pull/12988#discussion_r1720930899
##
streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java:
##
@@ -1182,41 +1175,64 @@ public class StreamsConfig extends AbstractConfig {
ashmeet13 commented on code in PR #12988:
URL: https://github.com/apache/kafka/pull/12988#discussion_r1720930718
##
streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java:
##
@@ -1182,41 +1175,64 @@ public class StreamsConfig extends AbstractConfig {
ashmeet13 commented on code in PR #12988:
URL: https://github.com/apache/kafka/pull/12988#discussion_r1720930643
##
streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java:
##
@@ -1182,41 +1175,64 @@ public class StreamsConfig extends AbstractConfig {
ashmeet13 commented on code in PR #12988:
URL: https://github.com/apache/kafka/pull/12988#discussion_r1720930593
##
streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java:
##
@@ -1182,41 +1175,64 @@ public class StreamsConfig extends AbstractConfig {
ashmeet13 commented on code in PR #12988:
URL: https://github.com/apache/kafka/pull/12988#discussion_r1720930486
##
streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java:
##
@@ -999,6 +988,10 @@ public class StreamsConfig extends AbstractConfig {
mjsax commented on code in PR #12988:
URL: https://github.com/apache/kafka/pull/12988#discussion_r1678407405
##
streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java:
##
@@ -1500,68 +1507,57 @@ private void validateRackAwarenessConfiguration() {
});
}
mjsax commented on code in PR #12988:
URL: https://github.com/apache/kafka/pull/12988#discussion_r1645265421
##
streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java:
##
@@ -1182,41 +1175,64 @@ public class StreamsConfig extends AbstractConfig {
mjsax commented on code in PR #12988:
URL: https://github.com/apache/kafka/pull/12988#discussion_r1645262881
##
streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java:
##
@@ -999,6 +988,10 @@ public class StreamsConfig extends AbstractConfig {
(na
ashmeet13 commented on PR #12988:
URL: https://github.com/apache/kafka/pull/12988#issuecomment-2145719503
@mjsax I have added the handling for `partitioner.class` config on the basis
of this logic -
1. If the config set is of a class that implements `StreamPartitioner`, we
let it pass
ashmeet13 commented on PR #12988:
URL: https://github.com/apache/kafka/pull/12988#issuecomment-2143755742
Hi @mjsax requesting a review on this PR.
There is one open case still that I am not sure how we should handle - it's
the check @ableegoldman mentioned in here comment
[here](htt
ashmeet13 commented on PR #12988:
URL: https://github.com/apache/kafka/pull/12988#issuecomment-2096203457
Fixing the failing build
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific com
ashmeet13 commented on code in PR #12988:
URL: https://github.com/apache/kafka/pull/12988#discussion_r1590353376
##
streams/src/test/java/org/apache/kafka/streams/StreamsConfigTest.java:
##
@@ -530,6 +530,14 @@ public void
shouldSetInternalLeaveGroupOnCloseConfigToFalseInConsum
ashmeet13 commented on PR #12988:
URL: https://github.com/apache/kafka/pull/12988#issuecomment-2094870332
Down are the configs for each type with whether -
1. Is it a custom default for KS but is editable by the user
2. Or, is it a fixed value controlled by KS
### Producer Confi
ashmeet13 commented on PR #12988:
URL: https://github.com/apache/kafka/pull/12988#issuecomment-2094869760
Hi @mjsax, apologies for the extremely absent behavior on this PR. I have
gone ahead and implemented the changes. The tests are pending and currently
working on them. Detailing the impl
ashmeet13 commented on code in PR #12988:
URL: https://github.com/apache/kafka/pull/12988#discussion_r1589029328
##
streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java:
##
@@ -1202,16 +1202,47 @@ public class StreamsConfig extends AbstractConfig {
PRODUCER
ashmeet13 commented on code in PR #12988:
URL: https://github.com/apache/kafka/pull/12988#discussion_r1589029328
##
streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java:
##
@@ -1202,16 +1202,47 @@ public class StreamsConfig extends AbstractConfig {
PRODUCER
ashmeet13 commented on code in PR #12988:
URL: https://github.com/apache/kafka/pull/12988#discussion_r1589029328
##
streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java:
##
@@ -1202,16 +1202,47 @@ public class StreamsConfig extends AbstractConfig {
PRODUCER
mjsax commented on code in PR #12988:
URL: https://github.com/apache/kafka/pull/12988#discussion_r1588576144
##
streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java:
##
@@ -1202,16 +1202,47 @@ public class StreamsConfig extends AbstractConfig {
PRODUCER_EOS
mjsax commented on PR #12988:
URL: https://github.com/apache/kafka/pull/12988#issuecomment-2084303833
@ashmeet13 -- any updates on this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spe
mjsax commented on code in PR #12988:
URL: https://github.com/apache/kafka/pull/12988#discussion_r1509672158
##
streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java:
##
@@ -1140,6 +1145,7 @@ public class StreamsConfig extends AbstractConfig {
static {
ashmeet13 commented on PR #12988:
URL: https://github.com/apache/kafka/pull/12988#issuecomment-1842424947
Hi @mjsax apologies for the delay. Pushing this soon.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL a
mjsax commented on PR #12988:
URL: https://github.com/apache/kafka/pull/12988#issuecomment-1831199541
@ashmeet13 -- Any update on this PR? We are coming up to 3.7 release code
freeze deadline. Might be nice to finish this on time?
--
This is an automated message from the Apache Git Servic
ashmeet13 commented on PR #12988:
URL: https://github.com/apache/kafka/pull/12988#issuecomment-1762139883
Got it! I'll make this change - for now I have gone through the code and the
following two references and compiled a list of configs that are somehow
"controlled" by KS. For now sharing
mjsax commented on PR #12988:
URL: https://github.com/apache/kafka/pull/12988#issuecomment-1760676675
Thanks for digging into this -- I think you are spot on -- seem we should
extract a method that will set KS controlled config, and refactor
`getMainConsumerConfigs` to first call `getCommon
ashmeet13 commented on PR #12988:
URL: https://github.com/apache/kafka/pull/12988#issuecomment-1752128811
Got it @mjsax -
Sharing the code that seems to be causing this bypass. Currently to fetch
any consumer config i.e. `main`, `restore` or `global` we use a common function
`getCommonC
40 matches
Mail list logo
