Re: [PR] KAFKA-16285: Make group metadata available when a new assignment is set [kafka]

cadonna merged PR #15426: URL: https://github.com/apache/kafka/pull/15426 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] KAFKA-16285: Make group metadata available when a new assignment is set [kafka]

AndrewJSchofield commented on code in PR #15426: URL: https://github.com/apache/kafka/pull/15426#discussion_r1510345836 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java: ## @@ -1372,4 +1373,8 @@ public PollResult poll(final long

Re: [PR] KAFKA-16285: Make group metadata available when a new assignment is set [kafka]

kirktrue commented on PR #15426: URL: https://github.com/apache/kafka/pull/15426#issuecomment-1974135452 > @kirktrue are you fine with merging this PR and coming back to this after 3.8? Yes. I think this is an area that we need a more holistic design review, unfortunately. --

Re: [PR] KAFKA-16285: Make group metadata available when a new assignment is set [kafka]

cadonna commented on PR #15426: URL: https://github.com/apache/kafka/pull/15426#issuecomment-1971644323 @kirktrue are you fine with merging this PR and coming back to this after 3.8? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] KAFKA-16285: Make group metadata available when a new assignment is set [kafka]

kirktrue commented on PR #15426: URL: https://github.com/apache/kafka/pull/15426#issuecomment-1968025786 @cadonna—thanks for the PR! I'm concerned that `MemberStateListener` mechanism has opened a path for us to sidestep the thread separation we've intentionally introduced. With this

Re: [PR] KAFKA-16285: Make group metadata available when a new assignment is set [kafka]

kirktrue commented on PR #15426: URL: https://github.com/apache/kafka/pull/15426#issuecomment-1968017311 > Did we take any decision about this architectural change proposed in [issues.apache.org/jira/browse/KAFKA-16290](https://issues.apache.org/jira/browse/KAFKA-16290)? Not that I'm

Re: [PR] KAFKA-16285: Make group metadata available when a new assignment is set [kafka]

cadonna commented on code in PR #15426: URL: https://github.com/apache/kafka/pull/15426#discussion_r1504623635 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java: ## @@ -1372,4 +1373,8 @@ public PollResult poll(final long

Re: [PR] KAFKA-16285: Make group metadata available when a new assignment is set [kafka]

lucasbru commented on code in PR #15426: URL: https://github.com/apache/kafka/pull/15426#discussion_r1504333691 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java: ## @@ -1372,4 +1373,8 @@ public PollResult poll(final long

Re: [PR] KAFKA-16285: Make group metadata available when a new assignment is set [kafka]

cadonna commented on code in PR #15426: URL: https://github.com/apache/kafka/pull/15426#discussion_r1504158556 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java: ## @@ -1372,4 +1373,8 @@ public PollResult poll(final long

Re: [PR] KAFKA-16285: Make group metadata available when a new assignment is set [kafka]

cadonna commented on code in PR #15426: URL: https://github.com/apache/kafka/pull/15426#discussion_r1504144313 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java: ## @@ -1372,4 +1373,8 @@ public PollResult poll(final long

Re: [PR] KAFKA-16285: Make group metadata available when a new assignment is set [kafka]

cadonna commented on code in PR #15426: URL: https://github.com/apache/kafka/pull/15426#discussion_r1504156212 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java: ## @@ -293,6 +276,23 @@ private void process(final

Re: [PR] KAFKA-16285: Make group metadata available when a new assignment is set [kafka]

cadonna commented on PR #15426: URL: https://github.com/apache/kafka/pull/15426#issuecomment-1966444988 > Thanks for the PR! I left some comments > > Architecturally, this is going a bit against https://issues.apache.org/jira/browse/KAFKA-16290 which proposes propagating the

Re: [PR] KAFKA-16285: Make group metadata available when a new assignment is set [kafka]

cadonna commented on code in PR #15426: URL: https://github.com/apache/kafka/pull/15426#discussion_r1504146104 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java: ## @@ -1186,8 +1181,7 @@ public OptionalLong currentLag(TopicPartition

Re: [PR] KAFKA-16285: Make group metadata available when a new assignment is set [kafka]

cadonna commented on code in PR #15426: URL: https://github.com/apache/kafka/pull/15426#discussion_r1504145709 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/RequestManagersTest.java: ## @@ -0,0 +1,71 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] KAFKA-16285: Make group metadata available when a new assignment is set [kafka]

cadonna commented on code in PR #15426: URL: https://github.com/apache/kafka/pull/15426#discussion_r1504144313 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java: ## @@ -1372,4 +1373,8 @@ public PollResult poll(final long

Re: [PR] KAFKA-16285: Make group metadata available when a new assignment is set [kafka]

cadonna commented on code in PR #15426: URL: https://github.com/apache/kafka/pull/15426#discussion_r1504099715 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java: ## @@ -293,6 +276,23 @@ private void process(final

Re: [PR] KAFKA-16285: Make group metadata available when a new assignment is set [kafka]

lucasbru commented on code in PR #15426: URL: https://github.com/apache/kafka/pull/15426#discussion_r1504029285 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java: ## @@ -293,6 +276,23 @@ private void process(final