chia7712 commented on PR #15507:
URL: https://github.com/apache/kafka/pull/15507#issuecomment-2001031718
> Do you have any in particular?
how about https://issues.apache.org/jira/browse/KAFKA-16376 ? or check the
following link:
https://issues.apache.org/jira/issues/?jql=proj
ChrisAHolland commented on PR #15507:
URL: https://github.com/apache/kafka/pull/15507#issuecomment-277204
I will take a look for some unassigned tickets! Do you have any in
particular?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log o
chia7712 commented on PR #15507:
URL: https://github.com/apache/kafka/pull/15507#issuecomment-1999649048
@ChrisAHolland thanks for contribution. If you have free cycle, please help
us fix the flaky. There are a bunch of tickets about flaky tests :)
--
This is an automated message from the
chia7712 merged PR #15507:
URL: https://github.com/apache/kafka/pull/15507
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
chia7712 commented on PR #15507:
URL: https://github.com/apache/kafka/pull/15507#issuecomment-1998993124
@ChrisAHolland thank for double checking the failed tests. Will merge it
later!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
ChrisAHolland commented on PR #15507:
URL: https://github.com/apache/kafka/pull/15507#issuecomment-1998991332
@chia7712 I believe test failures are orthogonal, it seems all recently
merged PR's have been having test failures.
--
This is an automated message from the Apache Git Service.
To
ChrisAHolland commented on code in PR #15507:
URL: https://github.com/apache/kafka/pull/15507#discussion_r1525616031
##
server-common/src/main/java/org/apache/kafka/server/mutable/BoundedList.java:
##
@@ -40,18 +40,22 @@ public static BoundedList newArrayBacked(int
maxLength)
chia7712 commented on code in PR #15507:
URL: https://github.com/apache/kafka/pull/15507#discussion_r1525585193
##
server-common/src/main/java/org/apache/kafka/server/mutable/BoundedList.java:
##
@@ -40,18 +40,22 @@ public static BoundedList newArrayBacked(int
maxLength) {
ChrisAHolland commented on code in PR #15507:
URL: https://github.com/apache/kafka/pull/15507#discussion_r1525523190
##
server-common/src/test/java/org/apache/kafka/server/mutable/BoundedListTest.java:
##
@@ -165,18 +199,24 @@ public void testIterator() {
@Test
publi
chia7712 commented on code in PR #15507:
URL: https://github.com/apache/kafka/pull/15507#discussion_r1525490485
##
server-common/src/test/java/org/apache/kafka/server/mutable/BoundedListTest.java:
##
@@ -165,18 +199,24 @@ public void testIterator() {
@Test
public voi
ChrisAHolland commented on PR #15507:
URL: https://github.com/apache/kafka/pull/15507#issuecomment-1998410642
@chia7712 Thank you, updated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spec
chia7712 commented on code in PR #15507:
URL: https://github.com/apache/kafka/pull/15507#discussion_r1525419354
##
server-common/src/main/java/org/apache/kafka/server/mutable/BoundedList.java:
##
@@ -40,18 +40,17 @@ public static BoundedList newArrayBacked(int
maxLength) {
ChrisAHolland commented on code in PR #15507:
URL: https://github.com/apache/kafka/pull/15507#discussion_r1524147955
##
server-common/src/main/java/org/apache/kafka/server/mutable/BoundedList.java:
##
@@ -35,24 +35,12 @@ public class BoundedList implements List {
private fi
ChrisAHolland commented on code in PR #15507:
URL: https://github.com/apache/kafka/pull/15507#discussion_r1524143322
##
server-common/src/main/java/org/apache/kafka/server/mutable/BoundedList.java:
##
@@ -35,24 +35,12 @@ public class BoundedList implements List {
private fi
chia7712 commented on code in PR #15507:
URL: https://github.com/apache/kafka/pull/15507#discussion_r1524140865
##
server-common/src/main/java/org/apache/kafka/server/mutable/BoundedList.java:
##
@@ -35,24 +35,12 @@ public class BoundedList implements List {
private final i
ChrisAHolland commented on PR #15507:
URL: https://github.com/apache/kafka/pull/15507#issuecomment-1996246082
@chia7712 @jolshan Pushed an update based on discussion
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
ChrisAHolland commented on code in PR #15507:
URL: https://github.com/apache/kafka/pull/15507#discussion_r1524100301
##
server-common/src/main/java/org/apache/kafka/server/mutable/BoundedList.java:
##
@@ -35,24 +35,12 @@ public class BoundedList implements List {
private fi
chia7712 commented on code in PR #15507:
URL: https://github.com/apache/kafka/pull/15507#discussion_r1524078277
##
server-common/src/main/java/org/apache/kafka/server/mutable/BoundedList.java:
##
@@ -35,24 +35,12 @@ public class BoundedList implements List {
private final i
ChrisAHolland commented on code in PR #15507:
URL: https://github.com/apache/kafka/pull/15507#discussion_r1524075123
##
server-common/src/main/java/org/apache/kafka/server/mutable/BoundedList.java:
##
@@ -35,24 +35,12 @@ public class BoundedList implements List {
private fi
ChrisAHolland commented on code in PR #15507:
URL: https://github.com/apache/kafka/pull/15507#discussion_r1524073993
##
server-common/src/main/java/org/apache/kafka/server/mutable/BoundedList.java:
##
@@ -35,24 +35,12 @@ public class BoundedList implements List {
private fi
jolshan commented on code in PR #15507:
URL: https://github.com/apache/kafka/pull/15507#discussion_r1524070820
##
server-common/src/main/java/org/apache/kafka/server/mutable/BoundedList.java:
##
@@ -35,24 +35,12 @@ public class BoundedList implements List {
private final in
jolshan commented on code in PR #15507:
URL: https://github.com/apache/kafka/pull/15507#discussion_r1524069898
##
server-common/src/main/java/org/apache/kafka/server/mutable/BoundedList.java:
##
@@ -35,24 +35,12 @@ public class BoundedList implements List {
private final in
chia7712 commented on code in PR #15507:
URL: https://github.com/apache/kafka/pull/15507#discussion_r1524061026
##
server-common/src/main/java/org/apache/kafka/server/mutable/BoundedList.java:
##
@@ -35,24 +35,12 @@ public class BoundedList implements List {
private final i
chia7712 commented on code in PR #15507:
URL: https://github.com/apache/kafka/pull/15507#discussion_r1524056640
##
server-common/src/main/java/org/apache/kafka/server/mutable/BoundedList.java:
##
@@ -35,24 +35,12 @@ public class BoundedList implements List {
private final i
ChrisAHolland commented on code in PR #15507:
URL: https://github.com/apache/kafka/pull/15507#discussion_r1523909237
##
server-common/src/main/java/org/apache/kafka/server/mutable/BoundedList.java:
##
@@ -35,24 +35,12 @@ public class BoundedList implements List {
private fi
ChrisAHolland commented on code in PR #15507:
URL: https://github.com/apache/kafka/pull/15507#discussion_r1523907637
##
server-common/src/main/java/org/apache/kafka/server/mutable/BoundedList.java:
##
@@ -35,24 +35,12 @@ public class BoundedList implements List {
private fi
chia7712 commented on code in PR #15507:
URL: https://github.com/apache/kafka/pull/15507#discussion_r1523656781
##
server-common/src/main/java/org/apache/kafka/server/mutable/BoundedList.java:
##
@@ -35,24 +35,12 @@ public class BoundedList implements List {
private final i
ChrisAHolland commented on PR #15507:
URL: https://github.com/apache/kafka/pull/15507#issuecomment-1994913616
@showuon @jolshan Would appreciate if you could take a look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
ChrisAHolland commented on code in PR #15507:
URL: https://github.com/apache/kafka/pull/15507#discussion_r1521727181
##
server-common/src/main/java/org/apache/kafka/server/mutable/BoundedList.java:
##
@@ -35,24 +35,12 @@ public class BoundedList implements List {
private fi
ChrisAHolland commented on code in PR #15507:
URL: https://github.com/apache/kafka/pull/15507#discussion_r1521713491
##
server-common/src/main/java/org/apache/kafka/server/mutable/BoundedList.java:
##
@@ -35,24 +35,12 @@ public class BoundedList implements List {
private fi
cadonna commented on code in PR #15507:
URL: https://github.com/apache/kafka/pull/15507#discussion_r1521177424
##
server-common/src/main/java/org/apache/kafka/server/mutable/BoundedList.java:
##
@@ -35,24 +35,12 @@ public class BoundedList implements List {
private final in
ChrisAHolland commented on PR #15507:
URL: https://github.com/apache/kafka/pull/15507#issuecomment-1990325002
@chia7712 @cadonna Hi, saw you approved some recent PR's, wondering if you
could take a look at mine or suggest someone better suited that I can ask?
Thanks!
--
This is an automa
32 matches
Mail list logo
