Re: [PR] MINOR: Remove deprecated constructors from Connect's Kafka*BackingStore classes [kafka]

2024-05-17 Thread via GitHub
chia7712 merged PR #15865: URL: https://github.com/apache/kafka/pull/15865 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] MINOR: Remove deprecated constructors from Connect's Kafka*BackingStore classes [kafka]

2024-05-16 Thread via GitHub
yashmayya commented on code in PR #15865: URL: https://github.com/apache/kafka/pull/15865#discussion_r1603105885 ## connect/runtime/src/main/java/org/apache/kafka/connect/storage/KafkaStatusBackingStore.java: ## @@ -160,7 +155,7 @@ public KafkaStatusBackingStore(Time time,

Re: [PR] MINOR: Remove deprecated constructors from Connect's Kafka*BackingStore classes [kafka]

2024-05-16 Thread via GitHub
chia7712 commented on PR #15865: URL: https://github.com/apache/kafka/pull/15865#issuecomment-2114786021 @yashmayya any update? I'm ok to merge it and open follow-up to address remaining comments. -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] MINOR: Remove deprecated constructors from Connect's Kafka*BackingStore classes [kafka]

2024-05-05 Thread via GitHub
chia7712 commented on code in PR #15865: URL: https://github.com/apache/kafka/pull/15865#discussion_r1590318726 ## connect/runtime/src/main/java/org/apache/kafka/connect/storage/KafkaStatusBackingStore.java: ## @@ -160,7 +155,7 @@ public KafkaStatusBackingStore(Time time,

Re: [PR] MINOR: Remove deprecated constructors from Connect's Kafka*BackingStore classes [kafka]

2024-05-05 Thread via GitHub
yashmayya commented on PR #15865: URL: https://github.com/apache/kafka/pull/15865#issuecomment-2094813303 Context - https://github.com/apache/kafka/pull/13434#discussion_r1590212654 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to