FrankYang0529 commented on code in PR #15616:
URL: https://github.com/apache/kafka/pull/15616#discussion_r1575753935
##
core/src/test/scala/unit/kafka/server/AlterReplicaLogDirsRequestTest.scala:
##
@@ -116,6 +124,56 @@ class AlterReplicaLogDirsRequestTest extends
BaseRequestTe
FrankYang0529 commented on code in PR #15616:
URL: https://github.com/apache/kafka/pull/15616#discussion_r1575754146
##
core/src/test/scala/unit/kafka/server/AlterReplicaLogDirsRequestTest.scala:
##
@@ -116,6 +124,56 @@ class AlterReplicaLogDirsRequestTest extends
BaseRequestTe
[
https://issues.apache.org/jira/browse/KAFKA-13459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17839981#comment-17839981
]
Daniel Urban commented on KAFKA-13459:
--
[~viktorsomogyi] No plans, and it does req
lucasbru commented on code in PR #15778:
URL: https://github.com/apache/kafka/pull/15778#discussion_r1575801343
##
tests/kafkatest/tests/client/consumer_test.py:
##
@@ -242,16 +242,15 @@ def test_static_consumer_bounce(self, clean_shutdown,
static_membership, bounce_
lucasbru merged PR #15746:
URL: https://github.com/apache/kafka/pull/15746
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
soarez merged PR #15783:
URL: https://github.com/apache/kafka/pull/15783
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.o
chia7712 commented on code in PR #15774:
URL: https://github.com/apache/kafka/pull/15774#discussion_r1575855253
##
server-common/src/main/java/org/apache/kafka/server/config/QuotaConfigs.java:
##
@@ -0,0 +1,154 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under on
chia7712 commented on PR #14983:
URL: https://github.com/apache/kafka/pull/14983#issuecomment-2071780823
I have backport this PR to 3.7 see
https://github.com/apache/kafka/commit/6e998cffdd33e343945877ccee1fec8337c7d57d
--
This is an automated message from the Apache Git Service.
To respo
chia7712 commented on PR #15777:
URL: https://github.com/apache/kafka/pull/15777#issuecomment-2071783047
The failed tests is fixed by
https://github.com/chia7712/kafka/commit/6e998cffdd33e343945877ccee1fec8337c7d57d
--
This is an automated message from the Apache Git Service.
To respond t
chia7712 merged PR #15777:
URL: https://github.com/apache/kafka/pull/15777
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
chia7712 commented on PR #15354:
URL: https://github.com/apache/kafka/pull/15354#issuecomment-2071806320
@jolshan Do you plan to backport this to 3.7? I recently try to backport
other PRs to 3.7 and encounter the same flaky
--
This is an automated message from the Apache Git Service.
To
chia7712 commented on PR #15772:
URL: https://github.com/apache/kafka/pull/15772#issuecomment-2071831061
> controller.listener.names
oh, it will be moved to `KRaftConfigs`. please ignore my previous comments.
--
This is an automated message from the Apache Git Service.
To respond to
chia7712 commented on PR #15772:
URL: https://github.com/apache/kafka/pull/15772#issuecomment-2071861237
Those failed tests pass on my local. will merge it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
chia7712 merged PR #15772:
URL: https://github.com/apache/kafka/pull/15772
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
chia7712 commented on PR #15762:
URL: https://github.com/apache/kafka/pull/15762#issuecomment-2071864618
retrigger QA due to incomplete build. I will merge it after QA get completed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Git
abhijeetk88 commented on code in PR #15625:
URL: https://github.com/apache/kafka/pull/15625#discussion_r1576005665
##
core/src/main/java/kafka/log/remote/quota/RLMQuotaManager.java:
##
@@ -0,0 +1,119 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+
abhijeetk88 commented on code in PR #15625:
URL: https://github.com/apache/kafka/pull/15625#discussion_r1576007574
##
core/src/main/java/kafka/log/remote/quota/RLMQuotaManager.java:
##
Review Comment:
Yes, the integration of the quota manager will come in the follow-up PRs.
chia7712 commented on code in PR #15766:
URL: https://github.com/apache/kafka/pull/15766#discussion_r1576009920
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/DeleteConsumerGroupsTest.java:
##
@@ -17,279 +17,448 @@
package org.apache.kafka.tools.consumer.group;
chia7712 commented on code in PR #15679:
URL: https://github.com/apache/kafka/pull/15679#discussion_r1576013151
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/DeleteOffsetsConsumerGroupCommandIntegrationTest.java:
##
@@ -171,29 +209,27 @@ private void produceRecord
brandboat commented on code in PR #15761:
URL: https://github.com/apache/kafka/pull/15761#discussion_r1576056664
##
core/src/test/java/kafka/testkit/BrokerNode.java:
##
@@ -66,11 +74,27 @@ public Builder setNumLogDirectories(int numLogDirectories) {
return this;
mimaison opened a new pull request, #15786:
URL: https://github.com/apache/kafka/pull/15786
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgr
Sagar Rao created KAFKA-16604:
-
Summary: Deprecate ConfigDef.ConfigKey constructor from public APIs
Key: KAFKA-16604
URL: https://issues.apache.org/jira/browse/KAFKA-16604
Project: Kafka
Issue Ty
vamossagar12 commented on PR #15762:
URL: https://github.com/apache/kafka/pull/15762#issuecomment-2072021300
@chia7712 , I created this ticket:
[KAFKA-16604](https://issues.apache.org/jira/browse/KAFKA-16604) for tracking
the KIP
--
This is an automated message from the Apache Git Servic
FrankYang0529 commented on code in PR #15679:
URL: https://github.com/apache/kafka/pull/15679#discussion_r1576082586
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/DeleteOffsetsConsumerGroupCommandIntegrationTest.java:
##
@@ -202,7 +238,7 @@ private KafkaProducer
dajac commented on code in PR #15717:
URL: https://github.com/apache/kafka/pull/15717#discussion_r1576085044
##
jmh-benchmarks/src/main/java/org/apache/kafka/jmh/assignor/ServerSideAssignorBenchmark.java:
##
@@ -0,0 +1,281 @@
+/*
+ * Licensed to the Apache Software Foundation (A
FrankYang0529 commented on PR #15679:
URL: https://github.com/apache/kafka/pull/15679#issuecomment-2072051627
> @FrankYang0529 sorry that I check the PR again, and more comments are
left. PTAL
Hi @chia7712, I addressed last comments. I think we can add new test case in
next PR. We ca
dajac commented on code in PR #15721:
URL: https://github.com/apache/kafka/pull/15721#discussion_r1576113492
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -1422,10 +1499,16 @@ private
CoordinatorResult consumerGr
) t
brandboat commented on PR #15761:
URL: https://github.com/apache/kafka/pull/15761#issuecomment-2072088191
> @brandboat Sorry that I leave more comments below. please take a look.
thanks
Thank you for your patience! I appreciate your input. Already addressed all
comments as above. Ple
TaiJuWu commented on PR #15782:
URL: https://github.com/apache/kafka/pull/15782#issuecomment-2072107254
> Thank you for the changes.
>
> Is there a reason to prefer the `java.lang.` prefix?
There is no special reason, Removing prefix is ok.
Following other code, Removing this
[
https://issues.apache.org/jira/browse/KAFKA-16604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17840075#comment-17840075
]
Chia-Ping Tsai commented on KAFKA-16604:
[~sagarrao] Thanks for opening this jir
chia7712 commented on PR #15679:
URL: https://github.com/apache/kafka/pull/15679#issuecomment-2072132702
> I think we can add new test case in next PR. We can more focus on migrate
to ClusterTestExtensions in this PR.
Please take a look at
https://github.com/apache/kafka/pull/15766#d
OmniaGM commented on code in PR #15774:
URL: https://github.com/apache/kafka/pull/15774#discussion_r1576158733
##
core/src/main/scala/kafka/server/DynamicConfig.scala:
##
@@ -36,30 +35,12 @@ import scala.jdk.CollectionConverters._
object DynamicConfig {
Review Comment:
It n
chia7712 commented on code in PR #15761:
URL: https://github.com/apache/kafka/pull/15761#discussion_r1576155040
##
core/src/test/java/kafka/testkit/TestKitNodes.java:
##
@@ -167,11 +186,11 @@ private TestKitNodes(
NavigableMap controllerNodes,
NavigableMap brok
FrankYang0529 commented on PR #15773:
URL: https://github.com/apache/kafka/pull/15773#issuecomment-2072172997
> > Yeah, I tried to use unit test. However, I didn't find a good way to
check whether kafka-delete-logs task has run or not. I also tried to check
whether scheduler can be stopped.
kamalcph commented on code in PR #15748:
URL: https://github.com/apache/kafka/pull/15748#discussion_r1576175394
##
core/src/test/scala/unit/kafka/log/LogCleanerParameterizedIntegrationTest.scala:
##
@@ -121,9 +121,9 @@ class LogCleanerParameterizedIntegrationTest extends
Abstra
kamalcph commented on code in PR #15748:
URL: https://github.com/apache/kafka/pull/15748#discussion_r1576175394
##
core/src/test/scala/unit/kafka/log/LogCleanerParameterizedIntegrationTest.scala:
##
@@ -121,9 +121,9 @@ class LogCleanerParameterizedIntegrationTest extends
Abstra
Kamal Chandraprakash created KAFKA-16605:
Summary: Fix the flaky LogCleanerParameterizedIntegrationTest
Key: KAFKA-16605
URL: https://issues.apache.org/jira/browse/KAFKA-16605
Project: Kafka
[
https://issues.apache.org/jira/browse/KAFKA-16605?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kamal Chandraprakash updated KAFKA-16605:
-
Description:
https://ge.apache.org/scans/tests?search.relativeStartTime=P7D&sear
OmniaGM commented on code in PR #15774:
URL: https://github.com/apache/kafka/pull/15774#discussion_r1576188830
##
server-common/src/main/java/org/apache/kafka/server/config/QuotaConfigs.java:
##
@@ -0,0 +1,154 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
kamalcph opened a new pull request, #15787:
URL: https://github.com/apache/kafka/pull/15787
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgr
kamalcph commented on code in PR #15748:
URL: https://github.com/apache/kafka/pull/15748#discussion_r1576190364
##
core/src/test/scala/unit/kafka/log/LogCleanerParameterizedIntegrationTest.scala:
##
@@ -121,9 +121,9 @@ class LogCleanerParameterizedIntegrationTest extends
Abstra
chia7712 commented on code in PR #15786:
URL: https://github.com/apache/kafka/pull/15786#discussion_r1576193128
##
core/src/test/scala/unit/kafka/coordinator/group/GroupCoordinatorConcurrencyTest.scala:
##
@@ -209,7 +209,7 @@ class GroupCoordinatorConcurrencyTest extends
Abstra
FrankYang0529 commented on PR #15679:
URL: https://github.com/apache/kafka/pull/15679#issuecomment-2072251579
> > I think we can add new test case in next PR. We can more focus on
migrate to ClusterTestExtensions in this PR.
>
> Please take a look at [#15766
(comment)](https://github
mimaison commented on code in PR #15786:
URL: https://github.com/apache/kafka/pull/15786#discussion_r1576233041
##
core/src/test/scala/unit/kafka/coordinator/group/GroupCoordinatorConcurrencyTest.scala:
##
@@ -209,7 +209,7 @@ class GroupCoordinatorConcurrencyTest extends
Abstra
chia7712 commented on code in PR #15679:
URL: https://github.com/apache/kafka/pull/15679#discussion_r1576262016
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/DeleteOffsetsConsumerGroupCommandIntegrationTest.java:
##
@@ -170,30 +227,23 @@ private void produceRecord
mimaison commented on code in PR #15774:
URL: https://github.com/apache/kafka/pull/15774#discussion_r1576247775
##
tools/src/main/java/org/apache/kafka/tools/reassign/ReassignPartitionsCommand.java:
##
@@ -98,23 +99,18 @@ public class ReassignPartitionsCommand {
static fina
ijuma commented on PR #9315:
URL: https://github.com/apache/kafka/pull/9315#issuecomment-2072363189
Fyi, Java 18+ do have a SPI for this:
https://bugs.openjdk.org/browse/JDK-8263693
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
OmniaGM commented on code in PR #15774:
URL: https://github.com/apache/kafka/pull/15774#discussion_r1576308101
##
tools/src/main/java/org/apache/kafka/tools/reassign/ReassignPartitionsCommand.java:
##
@@ -98,23 +99,18 @@ public class ReassignPartitionsCommand {
static final
OmniaGM commented on code in PR #15774:
URL: https://github.com/apache/kafka/pull/15774#discussion_r1576308464
##
checkstyle/import-control-metadata.xml:
##
@@ -123,6 +123,7 @@
+
Review Comment:
Fixed
--
This is an automated message
dajac commented on code in PR #15785:
URL: https://github.com/apache/kafka/pull/15785#discussion_r1576317772
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroup.java:
##
@@ -918,40 +935,53 @@ private void
maybeUpdateClassicProtocolMember
OmniaGM commented on code in PR #15786:
URL: https://github.com/apache/kafka/pull/15786#discussion_r1576329465
##
core/src/main/scala/kafka/server/ZkAdminManager.scala:
##
@@ -959,7 +960,7 @@ class ZkAdminManager(val config: KafkaConfig,
} else if (requestStatus.mechani
OmniaGM commented on code in PR #15786:
URL: https://github.com/apache/kafka/pull/15786#discussion_r1576332250
##
core/src/main/scala/kafka/server/ZkAdminManager.scala:
##
@@ -871,7 +872,7 @@ class ZkAdminManager(val config: KafkaConfig,
users.get.filterNot(usersToSkip.
FrankYang0529 commented on PR #15679:
URL: https://github.com/apache/kafka/pull/15679#issuecomment-2072421039
> @FrankYang0529 thanks for updated PR. please take a look at two comments.
Hi @chia7712, thanks for the review. Updated it.
--
This is an automated message from the Apache
OmniaGM commented on code in PR #15786:
URL: https://github.com/apache/kafka/pull/15786#discussion_r1576333034
##
core/src/main/scala/kafka/server/ZkAdminManager.scala:
##
@@ -871,7 +872,7 @@ class ZkAdminManager(val config: KafkaConfig,
users.get.filterNot(usersToSkip.
OmniaGM commented on code in PR #15786:
URL: https://github.com/apache/kafka/pull/15786#discussion_r1576338028
##
core/src/main/scala/kafka/server/ReplicaManager.scala:
##
@@ -144,7 +144,7 @@ case class LogReadResult(info: FetchDataInfo,
def withEmptyFetchInfo: LogReadResult
OmniaGM commented on code in PR #15786:
URL: https://github.com/apache/kafka/pull/15786#discussion_r1576343801
##
core/src/main/scala/kafka/server/ReplicaManager.scala:
##
@@ -300,7 +300,7 @@ class ReplicaManager(val config: KafkaConfig,
protected val allPartitions = new Pool
Jakub Scholz created KAFKA-16606:
Summary: JBOD support in KRaft does not seem to be gated by the
metadata version
Key: KAFKA-16606
URL: https://issues.apache.org/jira/browse/KAFKA-16606
Project: Kafk
OmniaGM commented on code in PR #15786:
URL: https://github.com/apache/kafka/pull/15786#discussion_r1576354443
##
core/src/main/scala/kafka/server/ZkAdminManager.scala:
##
@@ -871,7 +872,7 @@ class ZkAdminManager(val config: KafkaConfig,
users.get.filterNot(usersToSkip.
OmniaGM commented on PR #15786:
URL: https://github.com/apache/kafka/pull/15786#issuecomment-2072445566
We also have couple of out-of-date parameters in javaDocs, we can either fix
here or have another followup pr
-
https://github.com/apache/kafka/blob/1b301b30207ed8fca9f0aea5cf940b0353a
mimaison commented on code in PR #15786:
URL: https://github.com/apache/kafka/pull/15786#discussion_r1576351984
##
core/src/main/scala/kafka/server/ZkAdminManager.scala:
##
@@ -871,7 +872,7 @@ class ZkAdminManager(val config: KafkaConfig,
users.get.filterNot(usersToSkip
mimaison commented on code in PR #15786:
URL: https://github.com/apache/kafka/pull/15786#discussion_r1576358398
##
core/src/main/scala/kafka/server/ReplicaManager.scala:
##
@@ -300,7 +300,7 @@ class ReplicaManager(val config: KafkaConfig,
protected val allPartitions = new Poo
OmniaGM commented on code in PR #15786:
URL: https://github.com/apache/kafka/pull/15786#discussion_r1576360092
##
core/src/main/scala/kafka/zookeeper/ZooKeeperClient.scala:
##
@@ -52,8 +51,8 @@ object ZooKeeperClient {
* @param sessionTimeoutMs session timeout in milliseconds
mimaison commented on code in PR #15786:
URL: https://github.com/apache/kafka/pull/15786#discussion_r1576363327
##
core/src/main/scala/kafka/server/ZkAdminManager.scala:
##
@@ -871,7 +872,7 @@ class ZkAdminManager(val config: KafkaConfig,
users.get.filterNot(usersToSkip
OmniaGM commented on code in PR #15786:
URL: https://github.com/apache/kafka/pull/15786#discussion_r1576366593
##
core/src/main/scala/kafka/server/ZkAdminManager.scala:
##
@@ -871,7 +872,7 @@ class ZkAdminManager(val config: KafkaConfig,
users.get.filterNot(usersToSkip.
[
https://issues.apache.org/jira/browse/KAFKA-16606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17840118#comment-17840118
]
Mickael Maison commented on KAFKA-16606:
cc [~soarez]
> JBOD support in KRaft
OmniaGM commented on code in PR #15786:
URL: https://github.com/apache/kafka/pull/15786#discussion_r1576375031
##
core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala:
##
@@ -2192,8 +2192,8 @@ class PlaintextAdminIntegrationTest extends
BaseAdminIntegra
KevinZTW commented on code in PR #15714:
URL: https://github.com/apache/kafka/pull/15714#discussion_r1576372796
##
storage/src/test/java/org/apache/kafka/storage/internals/checkpoint/PartitionMetadataFileTest.java:
##
@@ -0,0 +1,94 @@
+/*
+ * Licensed to the Apache Software Foun
OmniaGM commented on code in PR #15786:
URL: https://github.com/apache/kafka/pull/15786#discussion_r1576375031
##
core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala:
##
@@ -2192,8 +2192,8 @@ class PlaintextAdminIntegrationTest extends
BaseAdminIntegra
lianetm commented on code in PR #15766:
URL: https://github.com/apache/kafka/pull/15766#discussion_r1576385492
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/DeleteConsumerGroupsTest.java:
##
@@ -17,279 +17,448 @@
package org.apache.kafka.tools.consumer.group;
chia7712 commented on code in PR #15679:
URL: https://github.com/apache/kafka/pull/15679#discussion_r1576386813
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/DeleteOffsetsConsumerGroupCommandIntegrationTest.java:
##
@@ -202,7 +256,7 @@ private KafkaProducer
creat
nikramakrishnan commented on PR #15241:
URL: https://github.com/apache/kafka/pull/15241#issuecomment-2072530250
Bump! @satishd @kamalcph can we get this review going? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
lianetm commented on code in PR #15766:
URL: https://github.com/apache/kafka/pull/15766#discussion_r1576385492
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/DeleteConsumerGroupsTest.java:
##
@@ -17,279 +17,448 @@
package org.apache.kafka.tools.consumer.group;
chia7712 commented on code in PR #15766:
URL: https://github.com/apache/kafka/pull/15766#discussion_r1576392526
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/DeleteConsumerGroupsTest.java:
##
@@ -17,279 +17,448 @@
package org.apache.kafka.tools.consumer.group;
[
https://issues.apache.org/jira/browse/KAFKA-16606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17840125#comment-17840125
]
Igor Soarez commented on KAFKA-16606:
-
Thanks for bringing this to my attention [~mi
lianetm commented on code in PR #15766:
URL: https://github.com/apache/kafka/pull/15766#discussion_r1576409478
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/DeleteConsumerGroupsTest.java:
##
@@ -17,279 +17,448 @@
package org.apache.kafka.tools.consumer.group;
mimaison commented on code in PR #15786:
URL: https://github.com/apache/kafka/pull/15786#discussion_r1576420731
##
core/src/main/scala/kafka/server/ReplicaManager.scala:
##
@@ -144,7 +144,7 @@ case class LogReadResult(info: FetchDataInfo,
def withEmptyFetchInfo: LogReadResult
mimaison commented on code in PR #15786:
URL: https://github.com/apache/kafka/pull/15786#discussion_r1576422765
##
core/src/main/scala/kafka/server/ZkAdminManager.scala:
##
@@ -959,7 +960,7 @@ class ZkAdminManager(val config: KafkaConfig,
} else if (requestStatus.mechan
FrankYang0529 commented on code in PR #15679:
URL: https://github.com/apache/kafka/pull/15679#discussion_r1576432135
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/DeleteOffsetsConsumerGroupCommandIntegrationTest.java:
##
@@ -202,7 +256,7 @@ private KafkaProducer
brandboat commented on code in PR #15761:
URL: https://github.com/apache/kafka/pull/15761#discussion_r1576432963
##
core/src/test/java/kafka/testkit/BrokerNode.java:
##
@@ -121,16 +146,16 @@ public BrokerNode build(
private final boolean combined;
private final Map pro
[
https://issues.apache.org/jira/browse/KAFKA-16606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17840132#comment-17840132
]
Jakub Scholz commented on KAFKA-16606:
--
[~soarez] That sounds like without using th
mimaison commented on PR #15756:
URL: https://github.com/apache/kafka/pull/15756#issuecomment-2072692296
While it's not directly adding new configurations, it's effectively changing
the behavior of `ExtractField` and `InsertField` and making them support new
configurations. The `configure()
johnnychhsu opened a new pull request, #15788:
URL: https://github.com/apache/kafka/pull/15788
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of tes
frankvicky commented on PR #15766:
URL: https://github.com/apache/kafka/pull/15766#issuecomment-2072734321
Hi @lianetm, @chia7712
Thanks for the suggestions, I have addressed the comments. 😀
--
This is an automated message from the Apache Git Service.
To respond to the message, please
chia7712 commented on code in PR #15786:
URL: https://github.com/apache/kafka/pull/15786#discussion_r1576457731
##
core/src/main/scala/kafka/metrics/LinuxIoMetricsCollector.scala:
##
@@ -29,9 +29,9 @@ import scala.jdk.CollectionConverters._
*/
class LinuxIoMetricsCollector(pr
[
https://issues.apache.org/jira/browse/KAFKA-16606?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jakub Scholz resolved KAFKA-16606.
--
Resolution: Not A Problem
> JBOD support in KRaft does not seem to be gated by the metadata ve
johnnychhsu commented on PR #15787:
URL: https://github.com/apache/kafka/pull/15787#issuecomment-2072775161
nice fix! crystal clear solution :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
chia7712 commented on code in PR #15761:
URL: https://github.com/apache/kafka/pull/15761#discussion_r1576492165
##
core/src/test/java/kafka/testkit/BrokerNode.java:
##
@@ -66,17 +69,30 @@ public Builder setNumLogDirectories(int numLogDirectories) {
return this;
johnnychhsu commented on code in PR #15727:
URL: https://github.com/apache/kafka/pull/15727#discussion_r1576500340
##
core/src/test/scala/unit/kafka/server/ConsumerGroupDescribeRequestsTest.scala:
##
@@ -0,0 +1,175 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) und
rreddy-22 commented on code in PR #15717:
URL: https://github.com/apache/kafka/pull/15717#discussion_r1576507146
##
jmh-benchmarks/src/main/java/org/apache/kafka/jmh/assignor/ServerSideAssignorBenchmark.java:
##
@@ -0,0 +1,281 @@
+/*
+ * Licensed to the Apache Software Foundatio
johnnychhsu commented on PR #15720:
URL: https://github.com/apache/kafka/pull/15720#issuecomment-2072812226
thanks for the review @cmccabe !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
chia7712 commented on code in PR #15679:
URL: https://github.com/apache/kafka/pull/15679#discussion_r1576508031
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/DeleteOffsetsConsumerGroupCommandIntegrationTest.java:
##
@@ -42,109 +58,141 @@
import static org.junit.j
mfvitale commented on PR #15756:
URL: https://github.com/apache/kafka/pull/15756#issuecomment-2072820368
> The `configure()` method on Transformation is only called with
configurations provided with their prefix.
This cleared my doubt. So in that case it should be clear declared as an
rreddy-22 commented on code in PR #15717:
URL: https://github.com/apache/kafka/pull/15717#discussion_r1576516058
##
jmh-benchmarks/src/main/java/org/apache/kafka/jmh/assignor/ServerSideAssignorBenchmark.java:
##
@@ -0,0 +1,281 @@
+/*
+ * Licensed to the Apache Software Foundatio
[
https://issues.apache.org/jira/browse/KAFKA-16606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17840148#comment-17840148
]
Igor Soarez commented on KAFKA-16606:
-
That's right [~scholzj] . When KIP-858 starte
chia7712 commented on code in PR #15766:
URL: https://github.com/apache/kafka/pull/15766#discussion_r1576523223
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/DeleteConsumerGroupsTest.java:
##
@@ -17,279 +17,440 @@
package org.apache.kafka.tools.consumer.group;
chia7712 commented on PR #15766:
URL: https://github.com/apache/kafka/pull/15766#issuecomment-2072841232
@frankvicky @m1a2st It seems your PR (#15766 and #15779) need a consumer
running in background. Hence, we can consider moving
`AbstractConsumerGroupExecutor`/`ConsumerGroupExecutor` to a
brandboat commented on code in PR #15761:
URL: https://github.com/apache/kafka/pull/15761#discussion_r1576531833
##
core/src/test/scala/unit/kafka/server/ApiVersionsRequestTest.scala:
##
@@ -84,17 +125,38 @@ class ApiVersionsRequestTest(cluster: ClusterInstance)
extends Abstrac
[
https://issues.apache.org/jira/browse/KAFKA-16606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17840150#comment-17840150
]
Mickael Maison commented on KAFKA-16606:
To me that kind of looks like a bug. Pr
chia7712 commented on PR #15788:
URL: https://github.com/apache/kafka/pull/15788#issuecomment-2072851173
@johnnychhsu Instead of removing them, could you make `MetadataLogConfig`
use those help methods?
https://github.com/apache/kafka/blob/1b301b30207ed8fca9f0aea5cf940b0353a1abca/co
lucasbru opened a new pull request, #15789:
URL: https://github.com/apache/kafka/pull/15789
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of testin
1 - 100 of 159 matches
Mail list logo
