Re: Logging suggestions

2003-06-06 Thread mstover1
That's a fair reason to keep it static. It's unfortunate though because that means each instance needs to be changed by hand. -Mike On 5 Jun 2003 at 21:09, Jeremy Arnold wrote: > Hello, > I would prefer the loggers to remain static if possible -- even if > Logkit returns the same logger

Re: Logging suggestions

2003-06-06 Thread Jeremy Arnold
Hello, I would prefer the loggers to remain static if possible -- even if Logkit returns the same logger instance for each call, using a non-static reference will result in an object reference (to the logger) in each instance of a JMeter object. In a 64-bit JVM, this would generally make ea

RE: Logging suggestions

2003-06-06 Thread BAZLEY, Sebastian
. And for its simple design, which made it easy to do... -Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] Sent: 05 June 2003 21:43 To: JMeter Developers List Subject: Re: Logging suggestions That's a fair reason to keep it static. It's unfortunate though becaus

RE: Logging suggestions

2003-06-03 Thread mstover1
PROTECTED] > Sent: 02 June 2003 15:14 > To: JMeter Developers List > Subject: RE: Logging suggestions > > > Yeah, I looked at this briefly and recognized the same problem with the > classnames. although 1.8 is dependent on Java 1.4, 1.8.1 is not, and > neither >

RE: Logging suggestions

2003-06-03 Thread BAZLEY, Sebastian
nce if the same category is used? I guess I need to try it, but if so, there would be no need to keep a hash, unless I've misunderstood what the hash would be for? S. -Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] Sent: 02 June 2003 15:14 To: JMeter Developers List

RE: Logging suggestions

2003-06-03 Thread mstover1
Yeah, I looked at this briefly and recognized the same problem with the classnames. although 1.8 is dependent on Java 1.4, 1.8.1 is not, and neither is 1.9, and too many have let it be known they want to use Java 1.3, so... Alternatively, these log variables could be instance instead of static

RE: Logging suggestions

2003-06-03 Thread BAZLEY, Sebastian
I've now experimented with the changes to the logging system. Before submitting patches etc, may I just confirm that the proposed changes are OK? == All relevant files (except LoggingManager.java) are changed as follows: import org.apache.log.Hierarchy; becomes import org.apache.jorphan.loggi

RE: Logging suggestions

2003-05-30 Thread BAZLEY, Sebastian
> -Original Message- > From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] > Sent: 30 May 2003 13:12 > To: JMeter Developers List > Subject: RE: Logging suggestions > > > On 30 May 2003 at 11:41, BAZLEY, Sebastian wrote: > > > For most source files,

RE: Logging suggestions

2003-05-30 Thread BAZLEY, Sebastian
mport org.apache.log.Hierarchy; by import org.apache.jorphan.logging.LoggingManager; If only Eclipse had a batch editor ... Sebastian -Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] Sent: 30 May 2003 13:33 To: JMeter Developers List Subject: Re: Logging suggestions On 30 May 2003

Re: Logging suggestions

2003-05-30 Thread mstover1
On 30 May 2003 at 14:15, Jeremy Arnold wrote: > Hello, >[snip] > For making changes to the call to getLoggerFor( ) for all of the > classes, it might be easier for one of the committers to do this > directly, rather than dealing with patches. That's very true. -Mike > > BAZLEY, S

Re: Logging suggestions

2003-05-30 Thread Jeremy Arnold
Hello, I don't have a strong opinion about this, although personally I like Log4J. However, my general opinion is that using Commons Logging is great for library code, since this makes it possible to use the same logging setup for several libraries used by one application. But when working

RE: Logging suggestions

2003-05-30 Thread mstover1
--- > From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] > Sent: 29 May 2003 20:24 > To: JMeter Developers List > Subject: RE: Logging suggestions > > > There is a LoggingManager class in the jorphan code that I use that's really > simple, and it has > a public method

RE: Logging suggestions

2003-05-30 Thread BAZLEY, Sebastian
List Subject: RE: Logging suggestions There is a LoggingManager class in the jorphan code that I use that's really simple, and it has a public method you can call to change the priority for any category at runtime. It just needs to be made static and you have exactly what you want. Furthe

RE: Logging suggestions

2003-05-30 Thread mstover1
[EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] > Sent: 22 May 2003 20:09 > To: JMeter Developers List > Subject: Re: Logging suggestions > > > It all sounds reasonable. Actually, the way logging is setup now, we should > > just the fully qualified classname as the logging c

RE: Logging suggestions

2003-05-30 Thread BAZLEY, Sebastian
add an extra method call. If others think it is useful, I can pursue this further (with the aim of providing patches). S. -Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] Sent: 22 May 2003 20:09 To: JMeter Developers List Subject: Re: Logging suggestions It all sounds