Re: [jquery-dev] attr() is still very broken in 1.4a1

2009-12-11 Thread John Resig
1) It still confuses properties and attributes, which is its biggest problem. Behavior is unpredictable. This is bad. Do you have any specific examples? 2) It looks like new code was added to call the jQuery method if the requested attribute is in jQuery.fn. But what about attributes like

Re: [jquery-dev] attr() is still very broken in 1.4a1

2009-12-11 Thread John Resig
I integrated the tests in the following branch: http://github.com/jquery/jquery/commits/attr At first scan it looks like the majority of the ~10 failures in Firefox relate to the suite expecting 'null' and us returning some other false-y value. That seems like an easy enough fix. Found two bugs