Re: [jquery-dev] make breaks after pulling commits from GitHub

2009-12-07 Thread Karl Swedberg
thanks, John! --Karl On Dec 7, 2009, at 9:08 PM, John Resig wrote: > I've landed commits to fix both of the aforementioned issues. (I > would've done it sooner but was without Internet today - sorry!) > > --John > > > > On Mon, Dec 7, 2009 at 2:08 PM, Will wrote: >> FYI, there is a "p" in exce

Re: [jquery-dev] make breaks after pulling commits from GitHub

2009-12-07 Thread John Resig
I've landed commits to fix both of the aforementioned issues. (I would've done it sooner but was without Internet today - sorry!) --John On Mon, Dec 7, 2009 at 2:08 PM, Will wrote: > FYI, there is a "p" in excess in Rakefile latest commit > > # Basic Rakefile for building jQuery > files = [ "i

Re: [jquery-dev] make breaks after pulling commits from GitHub

2009-12-07 Thread Will
FYI, there is a "p" in excess in Rakefile latest commit # Basic Rakefile for building jQuery files = [ "intro", "core", "suppport", Thank you! -will On Dec 7, 2009, at 16:50 , John Resig wrote: > Fixed the missing brace: > http://github.com/jquery/jquery/commit/97323d192f368fb8fa4ab8c77fbd7da9

Re: [jquery-dev] make breaks after pulling commits from GitHub

2009-12-07 Thread Julian Aubourg
Still not working, there seems to be a remaining nodeNode in manipulation.js (line 466 -- also in need of an elem.nodeName test too btw). /me nods ;) 2009/12/7 John Resig > Fixed the missing brace: > > http://github.com/jquery/jquery/commit/97323d192f368fb8fa4ab8c77fbd7da99b049800 > > And chang

Re: [jquery-dev] make breaks after pulling commits from GitHub

2009-12-07 Thread John Resig
Fixed the missing brace: http://github.com/jquery/jquery/commit/97323d192f368fb8fa4ab8c77fbd7da99b049800 And changed the ordered of event & support (and made sure it won't freak out): http://github.com/jquery/jquery/commit/afaae84a7a56bcbb69cb772d9ea29766ad0a2aa6 I'll be moving ready into core la

Re: [jquery-dev] make breaks after pulling commits from GitHub

2009-12-07 Thread arrixz...@gmail.com
That commit also makes event.js dependent on support.js so scripts inclusion order in build scripts must be updated. But even after adding the missing "}" and adjusting build.xml, I still cannot get a working build. I got the following error when running the generated jquery.js Uncaught TypeError:

Re: [jquery-dev] make breaks after pulling commits from GitHub

2009-12-07 Thread Julian Aubourg
Commented about it here : http://github.com/jquery/jquery/commit/7d36ccfa8eb018fcf349e1f74e3a0a614385558f 2009/12/7 Karl Swedberg > I pulled in the latest changes this morning from the jQuery GitHub repo, > but when I tried to run "make" it threw a couple errors: > > ERROR] 1:0:Compilation produ

[jquery-dev] make breaks after pulling commits from GitHub

2009-12-07 Thread Karl Swedberg
I pulled in the latest changes this morning from the jQuery GitHub repo, but when I tried to run "make" it threw a couple errors: ERROR] 1:0:Compilation produced 2 syntax errors. org.mozilla.javascript.EvaluatorException: Compilation produced 2 syntax errors. at com.yahoo.platform.yui.