[jQuery] Re: Graceful degradation (Safari < 2)

2007-08-30 Thread Brandon Aaron
I believe this code has just been migrated from an earlier hack for Safari. We used to just clone the event object only for Safari but now we clone it for all browsers. The best thing that can be done to help us make sure we don't browser sniff unless we absolutely have to is to create a new ticket

[jQuery] Re: Graceful degradation (Safari < 2)

2007-08-30 Thread Michael Geary
> > In this case you are fixing a bug that happens to appear in one > > browser, but why limit the fix to only that browser? What > > if another browser based on Safari comes out but has a > > different user agent string and isn't recognized by jQuery? > > Wouldn't you still want the bug to be f

[jQuery] Re: Graceful degradation (Safari < 2)

2007-08-30 Thread Matt Kruse
On Aug 30, 2:06 pm, "Mike Alsup" <[EMAIL PROTECTED]> wrote: > Why fix something that isn't broken? You can play the hypothetical > both ways without satisfaction. I don't think so - in the case where it "isn't broken" then nothing bad will result. The correction will not execute. In fact, it's l

[jQuery] Re: Graceful degradation (Safari < 2)

2007-08-30 Thread Brandon Aaron
On 8/30/07, Matt Kruse <[EMAIL PROTECTED]> wrote: > In this case you are fixing a bug that happens to appear in one > browser, but why limit the fix to only that browser? What if another > browser based on Safari comes out but has a different user agent > string and isn't recognized by jQuery? Wou

[jQuery] Re: Graceful degradation (Safari < 2)

2007-08-30 Thread Mike Alsup
> In this case you are fixing a bug that happens to appear in one > browser, but why limit the fix to only that browser? What if another > browser based on Safari comes out but has a different user agent > string and isn't recognized by jQuery? Wouldn't you still want the bug > to be fixed? What h

[jQuery] Re: Graceful degradation (Safari < 2)

2007-08-30 Thread Matt Kruse
On Aug 30, 12:52 pm, "Brandon Aaron" <[EMAIL PROTECTED]> wrote: > The example you posted is a very specific bug in Safari and running it for > other browsers would be incorrect. If the bug is that the original target of events in safari can be a text node within an element rather than the element

[jQuery] Re: Graceful degradation (Safari < 2)

2007-08-30 Thread Brandon Aaron
The example you posted is a very specific bug in Safari and running it for other browsers would be incorrect. We do feature/object checking when it is possible. -- Brandon Aaron On 8/30/07, Matt Kruse <[EMAIL PROTECTED]> wrote: > > > On Aug 30, 7:15 am, "[EMAIL PROTECTED]" <[EMAIL PROTECTED]> wro

[jQuery] Re: Graceful degradation (Safari < 2)

2007-08-30 Thread Matt Kruse
On Aug 30, 7:15 am, "[EMAIL PROTECTED]" <[EMAIL PROTECTED]> wrote: > I was wondering why jquery would not automatically do a browser sniff, > and fall back to methods that non-supported browsers understand. Why browser sniff at all? Why not detect for supported methods and do what is supported.

[jQuery] Re: Graceful degradation (Safari < 2)

2007-08-30 Thread [EMAIL PROTECTED]
I was wondering why jquery would not automatically do a browser sniff, and fall back to methods that non-supported browsers understand. Instead of me doing the browser checking, why doesn't jquery do this for me? For example, something like this within the show, or animate methods: if ( $.browse

[jQuery] Re: Graceful degradation (Safari < 2)

2007-08-29 Thread Brandon Aaron
The Safari version is actually the WebKit build number. Which is 413 for Safari 2. -- Brandon Aaron On 8/29/07, Karl Rudd <[EMAIL PROTECTED]> wrote: > > > If you're using jQuery 1.1.3 or later you can test for the version of > Safari really easily: > > if ( $.browser.safari && parseFloat($.browse

[jQuery] Re: Graceful degradation (Safari < 2)

2007-08-29 Thread Karl Rudd
If you're using jQuery 1.1.3 or later you can test for the version of Safari really easily: if ( $.browser.safari && parseFloat($.browser.version) < 2 ) { // Do stuff for Safari version < 2 } Karl Rudd On 8/29/07, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote: > > I love jquery, the only issue