Re: Layer-Supervisor

2016-07-21 Thread Stuart Bishop
On 21 July 2016 at 10:40, James Beedy wrote: > I'll take all the input/feedback/criticism I can get on this - thanks! Under Multi Application Support, the example references myapp1_ctxt and myapp2_ctxt variables but they are both undefined and there is no mention on what they are supposed to con

Re: Layer-Supervisor

2016-07-21 Thread Adam Stokes
One thing (which I haven't done yet in some of my layers) is to place your supervisorlib in `lib/charms/layer`. A nice first start though! On Thu, Jul 21, 2016 at 4:39 AM, Stuart Bishop wrote: > On 21 July 2016 at 10:40, James Beedy wrote: > > > I'll take all the input/feedback/criticism I can

juju bundle of Mitaka OpenStack with HA

2016-07-21 Thread 曾建銘
Hi All, I am trying to deploy Mitaka OpenStack with HA by Juju 2.0 & MAAS 2.0. It works if I use the OpenStack base bundle downloaded from charm store, but after adding HA configurations(HAProxy) into it, the deployment result can not work properly. Is there anyone successfully deployed Mitaka O

Re: Layer-Supervisor

2016-07-21 Thread James Beedy
A big thanks to those of you who gave feedback! I have made some revisions based on the suggestions I received from a few of you (thank you!), and would like to get a second round of feedback now the modifications have been made -> [layer-supervisor]( https://github.com/jamesbeedy/layer-supervisor

Re: Layer-Supervisor

2016-07-21 Thread Adam Stokes
looks good, one small nit pick, maybe change supervisorlib.py to just supervisor.py. that seems to be the current naming scheme of things On Thu, Jul 21, 2016 at 1:42 PM, James Beedy wrote: > A big thanks to those of you who gave feedback! I have made some revisions > based on the suggestions I

Re: Layer-Supervisor

2016-07-21 Thread Charles Butler
Greetings James, +1 to Adams suggestion. A question about the readme examples: There's a given example where you're getting a Workers() object but it isn't imported, or declared. Where did it come from? @when('myapp1.supervisor.available', 'myapp2.supervisor.available')def run_workers():

Re: Layer-Supervisor

2016-07-21 Thread James Beedy
Thank you all, for your feedback! @alex tracking @adam 10-4 @charles | That all makes sense -the reason I wanted it in lib, was because I was leaving it open to the user of the layer to configure supervisor for their app(s). Would it be preferable to have the user specify a list of ap