Re: Juju-core on github

2014-03-14 Thread Jonathan Aquilina
For code review there is gerrit https://code.google.com/p/gerrit/ I have seen this used by the libreoffice project, and its very successful as there can be multiple people reviewing patches which get submitted. it integrates with any git version control and already github has a hook available to

juju-core tests broken by gwacl

2014-03-14 Thread Nate Finch
I know some people were working on gwacl, but it seems there were some breaking changes made (possibly for 1.17.5?) The provider/azure tests are failing... I took a look but couldn't immediately figure out what was going wrong... Looked like Andrew was the last one to change gwacl, maybe you'd

Re: juju-core tests broken by gwacl

2014-03-14 Thread Andrew Wilkins
I have updated gwacl in preparation for some upcoming changes, but I haven't landed them or updated dependencies.tsv yet. Please revert to whatever's in dependencies.tsv. Cheers, Andrew On Sat, Mar 15, 2014 at 3:43 AM, Nate Finch nate.fi...@canonical.comwrote: I know some people were working

Re: Juju-core on github

2014-03-14 Thread John Meinel
The main problem with TravisCI is that it doesn't actually test what you woukd finally land if trunk gets ahead of your branch. (When you propose a branch it merges trunk at that time and then tells you the test results. But if you get more trunk revs, it doesn't re test.) We're used to a bot that