Re: Logger prefixes for api/apiserver are changing

2014-09-02 Thread John Meinel
I just wanted to make sure that this makes it into the release notes, as it is a semi-user-visible change. John =:- On Tue, Sep 2, 2014 at 2:00 PM, Dimiter Naydenov dimiter.nayde...@canonical.com wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi, As you may already know, this pull

Re: Logger prefixes for api/apiserver are changing

2014-09-02 Thread David Cheney
Wow. I'm sorry I broke that, it didn't even occur to me. I wonder if there is a better way to handle this default case of the name of the logger follows the package path), ie var logger = loggo.Logger() // or something, it could be a new method, logger.Default(), or something. which will

Re: Logger prefixes for api/apiserver are changing

2014-09-02 Thread Eric Snow
On Tue, Sep 2, 2014 at 5:07 AM, David Cheney david.che...@canonical.com wrote: I wonder if there is a better way to handle this default case of the name of the logger follows the package path), ie var logger = loggo.Logger() // or something, it could be a new method, logger.Default(), or

Re: State should not depend on the API server

2014-09-02 Thread Eric Snow
On Mon, Sep 1, 2014 at 12:03 AM, John Meinel j...@arbash-meinel.com wrote: FWIW I'd favor 3 layers, though it does mean you have to do copying between structs that would likely otherwise be almost identical. A State layer for saving in the DB, an API layer for communication, and a Model layer

auth fails bug reports

2014-09-02 Thread Matthew Williams
Hi Folks, Casey and I spent some time today looking at the auth fails during TearDownTest symptom/ bug: https://bugs.launchpad.net/juju-core/+bug/1348477. The failure seems to happen across various tests. The same problem was reported across a number of the errors listed in our juju test

Re: Logger prefixes for api/apiserver are changing

2014-09-02 Thread David Cheney
I'll take thumper's temperature for this feature at the standup and see what he thinks. On Wed, Sep 3, 2014 at 12:30 AM, Eric Snow eric.s...@canonical.com wrote: On Tue, Sep 2, 2014 at 5:07 AM, David Cheney david.che...@canonical.com wrote: I wonder if there is a better way to handle this

Re: gccgo internal compiler errors

2014-09-02 Thread Curtis Hovey-Canonical
I have been away. On Fri, Aug 29, 2014 at 8:36 AM, Ian Booth ian.bo...@canonical.com wrote: Yep, and we already want to do this for Windows compiles anyway. When I say want to, I mean we've already agreed that it should be done. So adding an extra compile step for gccgo should be done also.

review PR 512

2014-09-02 Thread Nate Finch
Someone who is allowed to give LGTMs please review PR 512 https://github.com/juju/juju/pull/512 -- Juju-dev mailing list Juju-dev@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/juju-dev

Re: Logger prefixes for api/apiserver are changing

2014-09-02 Thread Tim Penhey
On 02/09/14 23:07, David Cheney wrote: Wow. I'm sorry I broke that, it didn't even occur to me. I wonder if there is a better way to handle this default case of the name of the logger follows the package path), ie var logger = loggo.Logger() // or something, it could be a new method,

Re: Logger prefixes for api/apiserver are changing

2014-09-02 Thread John Meinel
... There were two ideas proposed: loggo.LoggerForPackage(juju) which would walk up the path until it found a path element juju, and construct the string that way. The other was do use a defined prefix: The only problem here is that we have: github.com/juju/juju/juju and

Re: Logger prefixes for api/apiserver are changing

2014-09-02 Thread Menno Smits
On 3 September 2014 15:07, Menno Smits menno.sm...@canonical.com wrote: Also, when we talk about package paths we really mean the source tree path right? Every in cmd/juju is in the main package but uses a logger named juju.cmd.juju. We can really use the real package name to set the logger