Re: Juju Academy

2014-05-09 Thread Matthew Williams
This is awesome Marco, I'll help out where I can On Wed, May 7, 2014 at 5:16 PM, Marco Ceppi wrote: > Hi everyone! > > I was trying to keep this under wraps as I worked on it more before > announcing to the world but I'm too excited with the progress so far so > here's the "SUPER ALPHA BETA OME

Re: End Of Review marker

2014-06-12 Thread Matthew Williams
+1 Rick. My opinion is it's just an issue of manners. After filling in comments inline let them know that you're done so they can start working on it. Likewise if you start doing a review and have some interruption and are unable to finish it let them know that there might be more to come. It's p

Open Ports on Ranges

2014-06-13 Thread Matthew Williams
I've spent some time over the last couple of days looking into lp:1216644 - being able to open a range of ports in a charm: https://bugs.launchpad.net/juju-core/+bug/1216644 Here are some notes taken during various conversations, as well as a task list: https://docs.google.com/a/canonical.com/d

Static Analysis on Juju

2014-06-23 Thread Matthew Williams
Hi Folks, As some of you will be aware the latest version of go includes some static analysis tools in godoc: http://golang.org/lib/godoc/analysis/help.html As is noted in the above, the analysis is quite slow (and resource intensive), but I wanted to find out if there was any useful output. To t

Re: Thoughts to keep in mind for Code Review

2014-06-25 Thread Matthew Williams
I agree that the code needs to be self-explanatory enough to not require annotations, but annotations can be useful - especially for larger changes. Suggesting the order for code to be reviewed is certainly useful if you're reviewing code in a part of the system you aren't familiar with On Wed, J

Re: Port ranges - restricting opening and closing ranges

2014-06-27 Thread Matthew Williams
there is a value in >> keeping a >> > port-range as an atomic data-object either way. >> > >> > --Mark Ramm >> > >> > >> > On Thu, Jun 26, 2014 at 2:11 PM, Domas Monkus < >> domas.mon...@canonical.com> >> > wrote:

Re: Reviewing - moving to review mentors, and guidelines

2014-07-19 Thread Matthew Williams
+1 Great idea, thank you On 18 Jul 2014 03:28, "Tim Penhey" wrote: > Hi all, > > Last night in the team meeting we discussed the review process. > Initially because there have been a number of things sneaking through > reviews where ideally we'd like to catch them earlier. > > In order to help t

Re: Reviewing - moving to review mentors, and guidelines

2014-08-11 Thread Matthew Williams
Is this still happening? M On 19 Jul 2014 09:43, "Matthew Williams" wrote: > +1 > > Great idea, thank you > On 18 Jul 2014 03:28, "Tim Penhey" wrote: > >> Hi all, >> >> Last night in the team meeting we discussed the review process. &g

Re: First customer pain point pull request - default-hook

2014-08-19 Thread Matthew Williams
Something to be mindful of is that we will shortly be implementing a new hook for metering (likely called collect-metrics). This hook differs slightly to the others in that it will be called periodically (e.g. once every hour) with the intention of sending metrics for that unit to the state server.

Re: First customer pain point pull request - default-hook

2014-08-20 Thread Matthew Williams
att On Tue, Aug 19, 2014 at 11:10 PM, Gustavo Niemeyer wrote: > On Tue, Aug 19, 2014 at 6:58 PM, Matthew Williams > wrote: > > Something to be mindful of is that we will shortly be implementing a new > > hook for metering (likely called collect-metrics). This hook differs > >

Re: Please Write Package Docs

2014-08-21 Thread Matthew Williams
Great idea, I'll do it On Thu, Aug 21, 2014 at 5:52 PM, Nate Finch wrote: > There's this great facility in Go where you can write a comment on the > package declaration, and that comment will get used as top-level docs > in godoc. We should be using this, and (in general) we're not. > > This

Re: gccgo internal compiler errors

2014-08-29 Thread Matthew Williams
As it's something we need to be doing for a while yet is there value in adding this as a task that gets run by the landing bot? Thanks Matty On Thu, Aug 28, 2014 at 11:48 PM, Tim Penhey wrote: > Hi folks, > > I spent some time this morning looking at > https://bugs.launchpad.net/juju-core

juju local bootstrap from tip

2014-08-30 Thread Matthew Williams
Hi Folks, I thought I'd try looking into the lxc failing to creates machines bug: https://bugs.launchpad.net/juju-core/+bug/1363143 If I wanted to do a local deploy using tip I thought it would be as simple as doing make install then juju bootstrap is that correct? It doesn't seem to work for me,

Re: Lag for unblocking CI

2014-09-01 Thread Matthew Williams
Thanks Martin, yeah things have come up since it tried to land, I'll try again later today and let you know if there are any problems On Mon, Sep 1, 2014 at 2:49 PM, Martin Packman wrote: > On 01/09/2014, John Meinel wrote: > > > > Is there some amount of caching going on somewhere? (I also no

auth fails bug reports

2014-09-02 Thread Matthew Williams
Hi Folks, Casey and I spent some time today looking at the "auth fails" during TearDownTest symptom/ bug: https://bugs.launchpad.net/juju-core/+bug/1348477. The failure seems to happen across various tests. The same problem was reported across a number of the errors listed in our juju test failu

Re: reviewboard

2014-09-09 Thread Matthew Williams
Thanks Eric, Taking it for a spin now, looks pretty cool Matty On Tue, Sep 9, 2014 at 3:47 PM, Eric Snow wrote: > On Mon, Sep 8, 2014 at 8:05 PM, Tim Penhey > wrote: > > On 09/09/14 04:32, Eric Snow wrote: > >> To install rbt: > >> > >> sudo pip install --allow-unverified rbtools --allow-exte

Re: Testing api clients

2014-09-11 Thread Matthew Williams
Thanks Andrew, I was almost about to reimplement this myself - making use of it right now Thanks Matty On Thu, Sep 11, 2014 at 5:57 AM, Andrew Wilkins < andrew.wilk...@canonical.com> wrote: > Hi folks, > > I'd like to bring a small, recent addition to everyone's attention: > https://github

Unit Tests & Integration Tests

2014-09-11 Thread Matthew Williams
Hi Folks, There seems to be a general push in the direction of having more mocking in unit tests. Obviously this is generally a good thing but there is still value in having integration tests that test a number of packages together. That's the subject of this mail - I'd like to start discussing ho

Re: Doing chained diffs w/ Reviewboard

2014-09-18 Thread Matthew Williams
I've got it working. Using rbt it was pretty trivial. I'm not 100% sure of my steps - but from memory and some prompting from `history` the process was more or less: 1) rebase my branch against the latest version of the parent. Then: 2) rbt post -parent remotes/mattyw/my-parent-branch It appeare

Re: Is ReviewBoard a good thing?

2014-09-19 Thread Matthew Williams
You can use kanban for a unified view of reviews, but reviewboard is better - you are able to see which reviews are missing comments and which ones are approved but not landed without having to click through multiple windows. Also the kanban board isn't viewable by everyone AFAIK. Everyone else ha

Re: The Pros and Cons of ReviewBoard.

2014-09-19 Thread Matthew Williams
At the risk of opening a can of worms: Reviewboard doesn't have to be a barrier to contributing. We could allow new contributors/ drive by fixes to use github. Matty On 19 Sep 2014 17:05, "Eric Snow" wrote: > On Fri, Sep 19, 2014 at 9:48 AM, Jonathan Aquilina > wrote: > > I am more than willin

Re: The Pros and Cons of ReviewBoard.

2014-09-22 Thread Matthew Williams
Just in case we're counting, another pro: You are able to seperate pushing branches to github and creating a new version of code for review Matty On Fri, Sep 19, 2014 at 4:37 PM, Eric Snow wrote: > Given that I've in some part driven the switch to ReviewBoard, I want > to make sure we are all

Re: Distributed systems theory

2014-09-23 Thread Matthew Williams
There's also the papers we love project https://github.com/papers-we-love/papers-we-love They have loads of papers about various topics. Here's the distributed systems section: https://github.com/papers-we-love/papers-we-love/tree/master/distributed_systems Matty On Tue, Sep 23, 2014 at 9:05 A

Re: Too space, or not two space

2014-11-19 Thread Matthew Williams
Believe it or not I also learned to type on a mechanical typewriter and I did double spaces on that. But you also needed to un jam it if you typed too fast. I'm voting for single space. -- Juju-dev mailing list Juju-dev@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com

Where to Review

2014-12-16 Thread Matthew Williams
Hi Folks, I'm forgetful and disorganised at the best of times I can never remember where I should go to review a particular juju project. I *think* only juju/juju and juju/utils are in reviewboard and everything else is in github - but I can't remember - is that right? Do we have a definitive l

Re: commands

2015-02-03 Thread Matthew Williams
Looks awesome Nick - it would be nice if we could expand the subcommands as well (like in user) mattyw On Tue, Feb 3, 2015 at 8:25 PM, Nate Finch wrote: > I'm so glad these are getting auto generated so they stay in sync. > > They should be consistent in style, we should choose capitalized or n

Unit test failure in juju/errors

2015-02-06 Thread Matthew Williams
Hi Folks, It appears that juju/errors has a failing unit test: http://paste.ubuntu.com/10085832/ It also appears that it only fails in go1.4 Matty -- Juju-dev mailing list Juju-dev@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/juju-dev

gocheck in non test code

2015-04-21 Thread Matthew Williams
Hi Folks, There seem to be a number of places in core where we end up importing gocheck in non test code. We should have a plan for reducing this down to zero, and at some stage not merge code in that does this. That's not a reasonable thing to do at the moment so I've just proposed a new rule in

Re: gocheck in non test code

2015-04-21 Thread Matthew Williams
ly have those dependencies, but should only be > imported in *_test.go code. > > John > =:-> > > > On Tue, Apr 21, 2015 at 5:17 PM, Matthew Williams < > matthew.willi...@canonical.com> wrote: > >> Hi Folks, >> >> There seem to be a number of plac

Re: gocheck in non test code

2015-04-21 Thread Matthew Williams
; > > > On Tue, Apr 21, 2015 at 5:46 PM, John Meinel > wrote: > >> I don't know if it is because of bad imports but I certainly see >> github.com/juju/juju/environs/testing >> github.com/juju/juju/juju/testing >> etc >> in the output of the

Re: Graduated reviewer: Domas Monkus

2015-04-24 Thread Matthew Williams
Congratulations Domas! On 23 Apr 2015 15:47, "Casey Marshall" wrote: > Juju developers, > I would like to announce Domas Monkus is a fully graduated Juju core > reviewer. This announcement is really long overdue.. Domas is careful > and thoughtful in his reviews, his feedback is useful, actionabl

Re: Test suite on windows now voting on trunk

2015-04-24 Thread Matthew Williams
I wasn't able to work out why my test failed on windows, but I was able to realise that it wasn't really testing what I wanted. I'm landing a further change now that makes the tests a little better, and adds a new one, and I've confirmed that they pass in the right way on windows and ubuntu. Matty

Public Service Annoucement

2015-04-24 Thread Matthew Williams
There's a very useful pre-push hook available for juju that does useful things like run gofmt, go vet, checks we can build etc. If you don't have it setup there's some lovely instructions in Contributing.md: https://github.com/juju/juju/blob/master/CONTRIBUTING.md#local-clone Thanks for listenin

Re: Fix for LP: #1174610 landing (unit ids should be unique)

2015-05-06 Thread Matthew Williams
This has now landed - and at the moment only in master so it will be out in 1.25 On Mon, Apr 27, 2015 at 5:44 PM, Casey Marshall < casey.marsh...@canonical.com> wrote: > Just a friendly heads-up.. a fix for this longstanding bug will be > landing into master shortly: > > LP: #1174610, unit ids sh

Godeps PSA (or don't make the same mistake I did)

2015-07-23 Thread Matthew Williams
I managed to break windows builds yesterday by removing a dependency from dependecies.tsv. I did this by running godeps - checking the diff and getting excited about being able to remove an unused dependency. But we currently need to import a package for windows builds that we don't for ubuntu. d

Re: Graduated Juju core reviewer: Aleš Stimec

2015-10-08 Thread Matthew Williams
Congratulations Ales. Good work On Wed, Oct 7, 2015 at 1:05 PM, Casey Marshall wrote: > All, > I'm pleased to announce Aleš Stimec is now a graduated Juju core reviewer. > His recent contributions and improvements to the Juju unit agent, > command-line infrastructure and API login clearly demons

Juju status & ubuntu snappy

2015-10-19 Thread Matthew Williams
Hey folks, I've been hacking around a bit more with juju and snappy. Thought you folks might be interested in seeing what I've come up with so far. Video: https://www.youtube.com/watch?v=JnbrWRDFqVo Blog post: http://blog.mattyw.net/blog/2015/10/18/snappy-juju-flasher-video/ Cheers Matty -- J

Problem Bootstrapping Azure

2015-10-21 Thread Matthew Williams
Hey Folks, Can someone with knowledge of azure respond to this issue? https://github.com/juju/juju/issues/3313 Many thanks Matty -- Juju-dev mailing list Juju-dev@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/juju-dev

On Call Reviewer Duties

2015-10-21 Thread Matthew Williams
Hey Folks, I propose that on call reviewers as part of their job should also review the issues list on https://github.com/juju/juju/issues and attempt to triage anything that's there. We moved to github to improve collaboration, but the issues list is often left ignored. If every OCR took a look a

public no address error in juju status

2015-11-16 Thread Matthew Williams
On a tip(ish) juju (built end of last week) I was running on the local provider and looking at the debug-log while watching juju status. The debug log was full of the following: http://paste.ubuntu.com/13300268/ Seems a bit noisy, and also sometimes quotes and sometimes not (status.go:448 and sta

Re: public no address error in juju status

2015-11-20 Thread Matthew Williams
> not to drop the log level to DEBUG for this? > > On 17 November 2015 at 06:29, Matthew Williams < > matthew.willi...@canonical.com> wrote: > >> On a tip(ish) juju (built end of last week) I was running on the local >> provider and looking at the debug-log

Re: mongo and ssh

2016-01-08 Thread Matthew Williams
Hi Neale, When you bootstrap, juju should be setting up mongo on the bootstrap server with all the correct settings and keys, you normally don't need to access the running mongodb, but if it's needed for debugging purposes it's possible. If you want to run mongo as part of your environment then yo

Problem with lxd on master - How do I debug this?

2016-02-01 Thread Matthew Williams
Hey folks, the lxd provider has been working fine for me - until this morning. I'm running on master (1cb8f0) I've attached output from juju debug-log juju status and lxd list, can someone help me work out what I should do to resolve this. The history leading up the attached logs is: 1) Everyth

Re: Awful dependency problem caused by romulus

2016-05-19 Thread Matthew Williams
Really sorry about this Dave, I'd not realised just how much they relied on each other. Surely there's an argument for romulus being merged into core? On Thu, May 19, 2016 at 8:55 AM, David Cheney wrote: > On Thu, May 19, 2016 at 5:04 PM, roger peppe > wrote: > > On 19 May 2016 at 07:02, David

Re: Awful dependency problem caused by romulus

2016-05-19 Thread Matthew Williams
7;t see how we can undo > the dependencies between cmd/juju and romulus -- they're so tightly > coupled they should probably live in the same repository. > > On Thu, May 19, 2016 at 6:45 PM, Matthew Williams > wrote: > > Really sorry about this Dave, I'd not reali

Re: Cleansing Mongo data

2016-06-24 Thread Matthew Williams
I seem to be missing something. Why do we need this? Matty On 24 Jun 2016 17:14, "Nate Finch" wrote: > It seems as though we should be cleansing all the keys since we never > know what queries we might want to make in the future. > > On Fri, Jun 24, 2016 at 12:04 PM Katherine Cox-Buday < > k

juju run-action --application?

2016-08-03 Thread Matthew Williams
Hey Folks, Is there any reason why I can't do juju run-action --application myapp (in the same way I can do juju run --application myapp). Thanks Matty -- Juju-dev mailing list Juju-dev@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/juju-dev

Re: juju run-action --application?

2016-08-03 Thread Matthew Williams
o how > results are curated. Do you get back X UUIDs one for each unit or a single > action UUID but results returned in a different fashion? > > Marco > > On Wed, Aug 3, 2016, 12:35 PM Matthew Williams < > matthew.willi...@canonical.com> wrote: > >> Hey

One instance manual provider

2016-12-05 Thread Matthew Williams
Hey Folks, I notice the docs state that at least two instances are needed for the manual provider: https://jujucharms.com/docs/stable/clouds-manual. Some quick playing around suggests that this is indeed the case. Is there a technical reason why? I'd love to spin up a charm on [insert vps provide

Leadership Election Tools

2016-12-13 Thread Matthew Williams
Hey Folks, Let's say I'm a charm author that wants to test leadership election in my charm. Are there any tools available that will let me force leadership election in juju so that I can test how my charm handles it? I was looking at the docs here: https://jujucharms.com/docs/stable/developer-lead

Default Controller Type on GCE

2017-01-09 Thread Matthew Williams
Hello Juju Fans, I've recently been playing around with Juju on GCE. Google is suggesting that I could downgrade the instance type to save some money (attached screenshot) I was wondering if anyone else had something similar, and therefore, does this suggest our default controller instance type o