Re: Clean Code: Intro, Clean Code and Meaningful Names (up to the end of chapter 2)

2013-09-26 Thread Tim Penhey
On 26/09/13 22:30, Nate Finch wrote: > Sorry, I've had this half typed out for like a week and a half. > > A general overview - I was actually really excited about the book. I try > to stress in words and actions that readable code is so much more > important than almost anything else. However, I

Re: Clean Code: Intro, Clean Code and Meaningful Names (up to the end of chapter 2)

2013-09-26 Thread Nate Finch
Function length is a different chapter ;) On Thu, Sep 26, 2013 at 10:00 AM, Frank Mueller wrote: > > People complain about single letter variable names, but if the function is >> only 10 lines long, does it really matter? You can see s := thing.State() >> ... so you know it's a state. Does it

Re: Clean Code: Intro, Clean Code and Meaningful Names (up to the end of chapter 2)

2013-09-26 Thread Frank Mueller
> People complain about single letter variable names, but if the function is > only 10 lines long, does it really matter? You can see s := thing.State() > ... so you know it's a state. Does it make it clearer to call it state > when you see it used 2 lines below? I don't think so. That being sa

Re: Clean Code: Intro, Clean Code and Meaningful Names (up to the end of chapter 2)

2013-09-26 Thread Nate Finch
Sorry, I've had this half typed out for like a week and a half. A general overview - I was actually really excited about the book. I try to stress in words and actions that readable code is so much more important than almost anything else. However, I find that the author's definition and mine dive

Re: Clean Code: Intro, Clean Code and Meaningful Names (up to the end of chapter 2)

2013-09-19 Thread Tim Penhey
On 20/09/13 04:57, Mark Canonical Ramm-Christensen wrote: > *Rules of Thumb for Code Cleanup* > > But, for everyday work, I'm also very aware that we need some shortcuts, > and rules of thumb. We can't make every single code cleanup decision by > trying to weigh all the costs and all the benefits.

Re: Clean Code: Intro, Clean Code and Meaningful Names (up to the end of chapter 2)

2013-09-19 Thread Mark Canonical Ramm-Christensen
Great discussion! I think there does need to be a level of pragmatism -- clean code is a means to an end. It reduces the cost of delivering features, and therefore makes it easier for us to achieve all our real goals. But as Gustavo correctly points out, the ultimate goal is happy and productive

Re: Clean Code: Intro, Clean Code and Meaningful Names (up to the end of chapter 2)

2013-09-17 Thread Tim Penhey
On 18/09/13 07:33, Gustavo Niemeyer wrote: > This isn't, by all means, to suggest that we should stop caring about > the quality of our code base. I'm all for improving variable names, > type names, and whatever else, as people who actually worked with me > can confirm. It's rather just a small rem

Re: Clean Code: Intro, Clean Code and Meaningful Names (up to the end of chapter 2)

2013-09-17 Thread Tim Penhey
On 17/09/13 18:20, Andrew Wilkins wrote: > On Tue, Sep 17, 2013 at 2:02 PM, Jeroen Vermeulen > mailto:jeroen.vermeu...@canonical.com>> > wrote: > Tim described duplication as a symptom. The difference is in > identifying the cause. Sometimes it takes you in much better > directions th

Re: Clean Code: Intro, Clean Code and Meaningful Names (up to the end of chapter 2)

2013-09-17 Thread Gustavo Niemeyer
I'll take Michael's reply as an arbitrary entry point [1] to balance the conversation a bit, which is ironic because I'm usually sitting far to the other side of this picture, fighting for coherence and perfection. But then, while the fight for code improvement is a good fight, it's also worth rem

Re: Clean Code: Intro, Clean Code and Meaningful Names (up to the end of chapter 2)

2013-09-17 Thread Michael Nelson
On Tue, Sep 17, 2013 at 7:42 AM, Andrew Wilkins wrote: > Decent read so far. Lots of reasonable ideas (obvious ideas, even!), though > some were a bit too dogmatic for me to swallow whole. > > I think for me the most important sections were (in chapter 2): > - Use Intention Revealing Names, > -

Re: Clean Code: Intro, Clean Code and Meaningful Names (up to the end of chapter 2)

2013-09-16 Thread Andrew Wilkins
On Tue, Sep 17, 2013 at 2:02 PM, Jeroen Vermeulen < jeroen.vermeu...@canonical.com> wrote: > On 17/09/13 12:42, Andrew Wilkins wrote: > > I don't think many people will disagree that deduplication of code is a >> bad idea in general. However, as with database denormalisation, there >> are excepti

Re: Clean Code: Intro, Clean Code and Meaningful Names (up to the end of chapter 2)

2013-09-16 Thread Jeroen Vermeulen
On 17/09/13 12:42, Andrew Wilkins wrote: I don't think many people will disagree that deduplication of code is a bad idea in general. However, as with database denormalisation, there are exceptions to the rule. If in the process of deduplicating you make things considerably more complicated to h

Re: Clean Code: Intro, Clean Code and Meaningful Names (up to the end of chapter 2)

2013-09-16 Thread Andrew Wilkins
Decent read so far. Lots of reasonable ideas (obvious ideas, even!), though some were a bit too dogmatic for me to swallow whole. I think for me the most important sections were (in chapter 2): - Use Intention Revealing Names, - Add Meaningful Context, and - (to a lesser degree) Don't Add Gratu

Clean Code: Intro, Clean Code and Meaningful Names (up to the end of chapter 2)

2013-09-16 Thread Tim Penhey
Hi folks, Rereading this book reminded me how good I found it. I went through and picked out some bits that I think that should be repeated. Small things matter. There has been a joke amongst some Canonical folks for a while that the company name should be "Pedantical". I'm a big supporter of