On Fri, Aug 22, 2014 at 4:19 AM, Katherine Cox-Buday <
katherine.cox-bu...@canonical.com> wrote:
> I have toyed with the idea of adding a git hook that runs godeps whenever
> I switch branches. I haven't gotten around to trying it out, but would that
> possibly be another helpful thing for develop
I have toyed with the idea of adding a git hook that runs godeps whenever I
switch branches. I haven't gotten around to trying it out, but would that
possibly be another helpful thing for developers to do?
On Thu, Aug 21, 2014 at 5:14 AM, roger peppe
wrote:
> On 21 August 2014 03:47, Nate Finch
On 21 August 2014 03:47, Nate Finch wrote:
> We've figured out that using godeps to print dependencies fails if you've
> installed Go from the PPA rather than from source, so that's why we're
> getting different results (Tim & Ian have the PPA, I have the source).
I'm sorry this is the case. I ha
On 21 August 2014 03:47, Nate Finch wrote:
> We've figured out that using godeps to print dependencies fails if you've
> installed Go from the PPA rather than from source, so that's why we're
> getting different results (Tim & Ian have the PPA, I have the source).
I'm sorry this is the case. I ha
On Wed, Aug 20, 2014 at 9:55 PM, Ian Booth wrote:
> I and others agree with the intent of the change but not the
> implementation, nor
>
the impact it has on developers. Perhaps a change of this nature might have
> been
> raised on the list before being committed to ensure there was broad
> agree
On 21/08/14 11:42, Nate Finch wrote:
> The point of the test is that developers *don't* run godeps. That's the
Well they *should*. If they don't why not? Is it not documented well enough?
It's explicitly mentioned in the CONTRIBUTING doc.
> problem. The original email noted that our dependenc
The point of the test is that developers *don't* run godeps. That's the
problem. The original email noted that our dependencies.tsv in master was
wrong. It's not the first time this has happened. I've also seen many
developers wonder why things were broken when it was just godeps needing to
be r
Lets' revert this change please.
I don't think this change pays for itself; the bot already runs godeps
from a *clean* working copy so there is no danger of it commiting
using the wrong deps and Tim has identified the make targets for
developers to check their own local working copy.
On Thu, Aug
Hmm, no, you're right... Godeps will probably report your dev branch. Hmph.
On Aug 20, 2014 8:42 PM, "Nate Finch" wrote:
> You shouldn't have a failing test, you just need to update
> dependencies.tsv to 've correct before running tests... Which you'd need to
> do anyway because you changed the
You shouldn't have a failing test, you just need to update dependencies.tsv
to 've correct before running tests... Which you'd need to do anyway
because you changed the deps.
I don't know why Ian's godeps is broken...
On Aug 20, 2014 8:37 PM, "Tim Penhey" wrote:
> A while back I added some usefu
A while back I added some useful make targets:
if the env var `JUJU_MAKE_GODEPS` is "true", then
make godeps
runs the godeps -u, and also makes sure it is run before build and check.
I tend to use this.
Also, if you are working on integrating changes in other branches that
aren't merged, you'l
Ah yes godeps -t ./... fails the same way.
But I never run that.
I just run godeps -u dependencies.tsv
to update the revs of the imported libs as I switch juju-core branches.
On 21/08/14 10:30, Nate Finch wrote:
> And running godeps -t ./... Didn't give the same error?
> On Aug 20, 2014 8:26 PM,
And running godeps -t ./... Didn't give the same error?
On Aug 20, 2014 8:26 PM, "Ian Booth" wrote:
> Don't think so
>
> ian@wallyworld:~$ which godeps
> /home/ian/juju/go/bin/godeps
>
> ian@wallyworld:~$ ls -l `which godeps`
> -rwxrwxr-x 1 ian ian 4821160 Aug 15 19:12 /home/ian/juju/go/bin/godep
Don't think so
ian@wallyworld:~$ which godeps
/home/ian/juju/go/bin/godeps
ian@wallyworld:~$ ls -l `which godeps`
-rwxrwxr-x 1 ian ian 4821160 Aug 15 19:12 /home/ian/juju/go/bin/godeps
On 21/08/14 10:20, Nate Finch wrote:
> All the test does is run godeps -t ./... It looks for godeps in the p
All the test does is run godeps -t ./... It looks for godeps in the path
first and then looks in gopath/bin. Do you maybe have a version in your
path that is old?
On Aug 20, 2014 8:15 PM, "Ian Booth" wrote:
> I run godeps all the time as I switch between 1.20 and master. It Just
> Works.
>
> On
I run godeps all the time as I switch between 1.20 and master. It Just Works.
On 21/08/14 10:12, Nate Finch wrote:
> What happens when you run godeps normally?
>
> It should ignore the std lib stuff, but I don't actually know how that's
> implemented.
> On Aug 20, 2014 8:02 PM, "Ian Booth" wrote
What happens when you run godeps normally?
It should ignore the std lib stuff, but I don't actually know how that's
implemented.
On Aug 20, 2014 8:02 PM, "Ian Booth" wrote:
> H. The test fails for me.
>
>
> FAIL: dependencies_test.go:42: dependenciesTest.TestGodepsIsRight
>
> dependencies_te
H. The test fails for me.
FAIL: dependencies_test.go:42: dependenciesTest.TestGodepsIsRight
dependencies_test.go:77:
...
dependencies_test.go:70:
c.Fatal(string(out))
... Error: godeps: no version control system found for
"/usr/lib/go/src/pkg/bufio"
godeps: no version control system
In an effort to make sure that dependencies.tsv is actually correct, the
tests in github.com/juju/juju now run godeps -t ./... and compare its
output to dependencies.tsv. The test looks for godeps first in the $PATH,
and then in the first $GOPATH/bin. If it is not found, it currently skips
the te
19 matches
Mail list logo
