Re: [JPP-Devel] Selectionstyle Patch

2010-09-07 Thread Sunburned Surveyor
Thanks Matthias. I was going to translate the English file, but sounds like you've already done that. Landon On Mon, Sep 6, 2010 at 12:29 PM, Matthias Scholz m...@jammerhund.de wrote: Hi Landon, sorry for my delay, but my internet connection was down at the weekend :-( I've done the german

Re: [JPP-Devel] Selectionstyle Patch

2010-09-06 Thread Matthias Scholz
Hi Landon, sorry for my delay, but my internet connection was down at the weekend :-( I've done the german and english translation in jump_de and jump_en.properties. Matthias I'll see if I can take a look at the English I18N file. Did you have English translations of the German words I can

Re: [JPP-Devel] Selectionstyle Patch

2010-09-03 Thread Michaël Michaud
Hi Matthias, Just tested the new selection options. It works great. Thank you. I'll try to have a look at language files this week-end. Michaël Le 03/09/2010 23:02, Sunburned Surveyor a écrit : I'll see if I can take a look at the English I18N file. Did you have English translations of

Re: [JPP-Devel] Selectionstyle Patch

2010-08-11 Thread Matthias Scholz
Hi Larry, i know the difference of handle outline drawing. This seems to be a problem in the VertexStyle classes. You get the same mistake if you switch on the vertices in the layer styling dialog. I can try to find the problem in the VertexStyle classes. What do you mean with the button in the

Re: [JPP-Devel] Selectionstyle Patch

2010-08-09 Thread Larry Becker
Hi Matthias, The code does indeed look much more efficient, however it still doesn't default to the old selection behavior, so I'm not sure how users outside your organization are going to react to the change. I don't like it as well as the current method which outlines the handles. Also

Re: [JPP-Devel] Selectionstyle Patch

2010-07-30 Thread Larry Becker
Hi Matthias, Sorry I've been unable to get back to you. I have been on travel, both vacation and business, but I should be able to get back to my normal schedule sometime next week. regards, Larry On Fri, Jul 30, 2010 at 11:34 AM, Matthias Scholz m...@jammerhund.de wrote: Hi, please can

Re: [JPP-Devel] Selectionstyle Patch

2010-07-11 Thread Matthias Scholz
Hi Larry, can we do the following? - add some setSelectionLineColor, setSelectionPointSize and setSelectionPointForm to com.vividsolutions.jump.workbench.ui.renderer.Renderer interface - implement simple setter in com.vividsolutions.jump.workbench.ui.renderer.FeatureCollectionRenderer, wich

Re: [JPP-Devel] Selectionstyle Patch

2010-07-11 Thread Larry Becker
Hi Matthias, I'm pretty sure that the right place to add setSelectionLineColor, setSelectionPointSize and setSelectionPointForm is AbstractSelectionRenderer since that is where the associated variables are declared. You will have to remove *final *from HANDLE_WIDTH. The real trick is getting

Re: [JPP-Devel] Selectionstyle Patch

2010-06-27 Thread Matthias Scholz
Hi Sunburned Surveyor and Larry, sorry for my late reply, but i had no time to code last week :-( I agree with Larry's remarks. My question went toward the concrete implementation, as I currently do not have enough knowledge about the internals of OJ. At the beginning I would to build a

Re: [JPP-Devel] Selectionstyle Patch

2010-06-27 Thread Larry Becker
I don't see an obvious solution. For one thing, it is unclear how your plugin would affect the interoperability of SelectionBackgroundRenderer, PartSelectionRenderer, and LineStringSelectionRenderer which uses constructors to select different feedback mechanisms. Larry On Sun, Jun 27, 2010 at

Re: [JPP-Devel] Selectionstyle Patch

2010-06-27 Thread Stefan Steiniger
mhm.. as a side note. the SRID Plugin[1] adds some listeners.. maybe that a way for a plugin? stefan [1] EnsureAllLayersHaveSRIDStylePlugIn.java Larry Becker schrieb: I don't see an obvious solution. For one thing, it is unclear how your plugin would affect the interoperability of

Re: [JPP-Devel] Selectionstyle Patch

2010-06-24 Thread Sunburned Surveyor
I haven't looked at the code Mathias provided. It sounds like Larry's provided some great comments. I hope the changes can be made so Mathias code can be integrated. If Mathias needs help making the mods Larry has suggested, he can let me know. The Sunburned Surveyor On Mon, Jun 21, 2010 at

Re: [JPP-Devel] Selectionstyle Patch

2010-06-21 Thread Larry Becker
Hi Matthias, My concern about code efficiency is that this is a very low level routine in AbstractSelectionRenderer that is potentially called millions of times per session. Everything possible (like blackboard access and object creation) needs to be moved outside of it. Also, if the user does

[JPP-Devel] Selectionstyle Patch

2010-06-18 Thread Matthias Scholz
Hi, the attached patch are a first version of my selectionstyle enhancement. You can change the selectionstyle with a new tab in the optionsdialog. The stylings are stored in the persistent Blackboard - workbench-state.xml. Please take a look at my code and tell me your opinion. It would be

Re: [JPP-Devel] Selectionstyle Patch

2010-06-18 Thread Larry Becker
Hi Matthias, I had some problems applying the patch. I was only able to get the AbstractSelectionRenderer and OptionsPlugIn patches. Eclipse wouldn't create the new files for some reason. Looking at the changes to AbstractSelectionRenderer, I do have some concerns about efficiency since I