[jira] [Commented] (KAFKA-267) Enhance ProducerPerformance to generate unique random Long value for payload

2012-10-29 Thread Yang Ye (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13486323#comment-13486323 ] Yang Ye commented on KAFKA-267: --- V6 should be the right one, please review this one

[jira] [Commented] (KAFKA-267) Enhance ProducerPerformance to generate unique random Long value for payload

2012-10-26 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13485024#comment-13485024 ] Jun Rao commented on KAFKA-267: --- Thanks for patch v7. Not sure if printing messages in

[jira] [Commented] (KAFKA-267) Enhance ProducerPerformance to generate unique random Long value for payload

2012-10-26 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13485032#comment-13485032 ] Neha Narkhede commented on KAFKA-267: - Keeping the printing in ProducerPerformance

[jira] [Commented] (KAFKA-267) Enhance ProducerPerformance to generate unique random Long value for payload

2012-10-26 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13485042#comment-13485042 ] Jun Rao commented on KAFKA-267: --- What we can do is that, in system tests, tune #retries and

[jira] [Commented] (KAFKA-267) Enhance ProducerPerformance to generate unique random Long value for payload

2012-10-24 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13483293#comment-13483293 ] Jun Rao commented on KAFKA-267: --- Thanks for patch v5. Looks good. Some minor comments: 50.

[jira] [Commented] (KAFKA-267) Enhance ProducerPerformance to generate unique random Long value for payload

2012-10-24 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13483415#comment-13483415 ] Neha Narkhede commented on KAFKA-267: - Thanks for patch v5, we are pretty close to

[jira] [Commented] (KAFKA-267) Enhance ProducerPerformance to generate unique random Long value for payload

2012-10-19 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13480112#comment-13480112 ] Jun Rao commented on KAFKA-267: --- Thanks for patch v4. It's better, but still messy. Some more

[jira] [Commented] (KAFKA-267) Enhance ProducerPerformance to generate unique random Long value for payload

2012-10-11 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13474299#comment-13474299 ] Jun Rao commented on KAFKA-267: --- Thanks for patch v3. The code is still pretty messy, mostly

[jira] [Commented] (KAFKA-267) Enhance ProducerPerformance to generate unique random Long value for payload

2012-10-10 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13473382#comment-13473382 ] Jun Rao commented on KAFKA-267: --- Can't find a revision that I can apply the patch cleanly.