[jira] [Commented] (KAFKA-532) Multiple controllers can co-exist during soft failures

2012-11-18 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13499941#comment-13499941 ] Jun Rao commented on KAFKA-532: --- 50. My feeling is that request level error code conveys the

[jira] [Commented] (KAFKA-532) Multiple controllers can co-exist during soft failures

2012-11-18 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13499873#comment-13499873 ] Neha Narkhede commented on KAFKA-532: - Thanks for reviewing patch v5 quickly ! 50. Tru

[jira] [Commented] (KAFKA-532) Multiple controllers can co-exist during soft failures

2012-11-18 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13499860#comment-13499860 ] Jun Rao commented on KAFKA-532: --- Thanks for patch v5. Looks good. Just a couple of minor comm

[jira] [Commented] (KAFKA-532) Multiple controllers can co-exist during soft failures

2012-11-06 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13491566#comment-13491566 ] Jun Rao commented on KAFKA-532: --- Thanks for patch v4. A few more comments: 40. PartitionStat

[jira] [Commented] (KAFKA-532) Multiple controllers can co-exist during soft failures

2012-11-01 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13489181#comment-13489181 ] Neha Narkhede commented on KAFKA-532: - >> 34. KafkaController: There seems to be a tric

[jira] [Commented] (KAFKA-532) Multiple controllers can co-exist during soft failures

2012-11-01 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13488893#comment-13488893 ] Jun Rao commented on KAFKA-532: --- Thanks for patch v3. The overall approach seems to work. Som

[jira] [Commented] (KAFKA-532) Multiple controllers can co-exist during soft failures

2012-10-26 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13485030#comment-13485030 ] Jun Rao commented on KAFKA-532: --- The purpose of controller epoc is to prevent an older contro

[jira] [Commented] (KAFKA-532) Multiple controllers can co-exist during soft failures

2012-10-01 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13467184#comment-13467184 ] Jun Rao commented on KAFKA-532: --- Thanks for patch v1. Some comments: 1. PartitionStateMachine