[jira] [Commented] (KAFKA-593) Empty log index file created when it shouldn't be empty

[ https://issues.apache.org/jira/browse/KAFKA-593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13490770#comment-13490770 ] Jun Rao commented on KAFKA-593: --- Thanks for patch v3. Looks good. Some minor comments. 30.

[jira] [Commented] (KAFKA-593) Empty log index file created when it shouldn't be empty

[ https://issues.apache.org/jira/browse/KAFKA-593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13490869#comment-13490869 ] Jay Kreps commented on KAFKA-593: - Looks good, two minor things: 1. Can we name resetSize

[jira] [Commented] (KAFKA-593) Empty log index file created when it shouldn't be empty

[ https://issues.apache.org/jira/browse/KAFKA-593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13490971#comment-13490971 ] Jay Kreps commented on KAFKA-593: - Discussed with Victor. (1) and (3) should be doable, but

[jira] [Commented] (KAFKA-593) Empty log index file created when it shouldn't be empty

[ https://issues.apache.org/jira/browse/KAFKA-593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13491082#comment-13491082 ] Jay Kreps commented on KAFKA-593: - +1 Empty log index file created when

[jira] [Commented] (KAFKA-593) Empty log index file created when it shouldn't be empty

[ https://issues.apache.org/jira/browse/KAFKA-593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13489500#comment-13489500 ] Jay Kreps commented on KAFKA-593: - trimOrReallocate(isReallocate: Boolean) is a bit of a

[jira] [Commented] (KAFKA-593) Empty log index file created when it shouldn't be empty

[ https://issues.apache.org/jira/browse/KAFKA-593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13489260#comment-13489260 ] Jun Rao commented on KAFKA-593: --- Thanks for the patch. A couple of comments: 1.

[jira] [Commented] (KAFKA-593) Empty log index file created when it shouldn't be empty

[ https://issues.apache.org/jira/browse/KAFKA-593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13487841#comment-13487841 ] Jun Rao commented on KAFKA-593: --- Here is the issue. We rolled a new segment in the follower.

[jira] [Commented] (KAFKA-593) Empty log index file created when it shouldn't be empty

[ https://issues.apache.org/jira/browse/KAFKA-593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13487878#comment-13487878 ] Jay Kreps commented on KAFKA-593: - Makes sense, clever. I thought a bit about this during

[jira] [Commented] (KAFKA-593) Empty log index file created when it shouldn't be empty

[ https://issues.apache.org/jira/browse/KAFKA-593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13487879#comment-13487879 ] Jay Kreps commented on KAFKA-593: - Err, that should read intra-messageset positions.

[jira] [Commented] (KAFKA-593) Empty log index file created when it shouldn't be empty

[ https://issues.apache.org/jira/browse/KAFKA-593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13486990#comment-13486990 ] Jun Rao commented on KAFKA-593: --- Producer used sync mode. So, there is 1 message per batch

[jira] [Commented] (KAFKA-593) Empty log index file created when it shouldn't be empty

[ https://issues.apache.org/jira/browse/KAFKA-593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13486631#comment-13486631 ] Jay Kreps commented on KAFKA-593: - I am not sure that this is a bug. The index entries are