[jira] [Commented] (KAFKA-70) Introduce retention setting that depends on space

2011-09-21 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-70?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13109608#comment-13109608 ] Neha Narkhede commented on KAFKA-70: You are right Chris. Trunk is on 0.7 > Introduce r

[jira] [Commented] (KAFKA-70) Introduce retention setting that depends on space

2011-09-21 Thread Chris Burroughs (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-70?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13109463#comment-13109463 ] Chris Burroughs commented on KAFKA-70: -- Trunk == 0.7 not 0.8, right? > Introduce reten

[jira] [Commented] (KAFKA-70) Introduce retention setting that depends on space

2011-09-16 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-70?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13107006#comment-13107006 ] Jay Kreps commented on KAFKA-70: Applied, thanks! I will open a JIRA to add per-topic overri

[jira] [Commented] (KAFKA-70) Introduce retention setting that depends on space

2011-09-15 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-70?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13105811#comment-13105811 ] Neha Narkhede commented on KAFKA-70: +1. Thanks for the patch ! > Introduce retention s

[jira] [Commented] (KAFKA-70) Introduce retention setting that depends on space

2011-09-15 Thread Prashanth Menon (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-70?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13105799#comment-13105799 ] Prashanth Menon commented on KAFKA-70: -- Hi guys, had a chance to look at the newest pat

[jira] [Commented] (KAFKA-70) Introduce retention setting that depends on space

2011-09-12 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-70?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13102815#comment-13102815 ] Jay Kreps commented on KAFKA-70: Jun, yeah, exactly, I think that is what I was trying to sa

[jira] [Commented] (KAFKA-70) Introduce retention setting that depends on space

2011-09-12 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-70?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13102733#comment-13102733 ] Jun Rao commented on KAFKA-70: -- One possibility is to have the following semantic: delete segme

[jira] [Commented] (KAFKA-70) Introduce retention setting that depends on space

2011-09-12 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-70?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13102703#comment-13102703 ] Jay Kreps commented on KAFKA-70: Actually, now that I think about it, not sure if just limit

[jira] [Commented] (KAFKA-70) Introduce retention setting that depends on space

2011-09-12 Thread Prashanth Menon (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-70?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13102567#comment-13102567 ] Prashanth Menon commented on KAFKA-70: -- Okay, expect a patch with the added rule enforc

[jira] [Commented] (KAFKA-70) Introduce retention setting that depends on space

2011-09-11 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-70?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13102417#comment-13102417 ] Jun Rao commented on KAFKA-70: -- Prashanth, thanks for the patch. I suggest that we enforce ret

[jira] [Commented] (KAFKA-70) Introduce retention setting that depends on space

2011-09-11 Thread Prashanth Menon (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-70?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13102399#comment-13102399 ] Prashanth Menon commented on KAFKA-70: -- Haha, this is quite uncanny. I had the same di

[jira] [Commented] (KAFKA-70) Introduce retention setting that depends on space

2011-09-11 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-70?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13102303#comment-13102303 ] Jay Kreps commented on KAFKA-70: I agree the delete logic is correct. Log.scala keeps all se

[jira] [Commented] (KAFKA-70) Introduce retention setting that depends on space

2011-09-10 Thread Prashanth Menon (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-70?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13102157#comment-13102157 ] Prashanth Menon commented on KAFKA-70: -- Hi Joel, Looking through Log.loadSegments it l

[jira] [Commented] (KAFKA-70) Introduce retention setting that depends on space

2011-09-09 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-70?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13101547#comment-13101547 ] Joel Koshy commented on KAFKA-70: - Prashanth, Thanks a lot for the patch. cleanUpSegmentsTo

[jira] [Commented] (KAFKA-70) Introduce retention setting that depends on space

2011-09-08 Thread Prashanth Menon (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-70?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13100831#comment-13100831 ] Prashanth Menon commented on KAFKA-70: -- Hi Jun, Nope, answered them myself (had a brai

[jira] [Commented] (KAFKA-70) Introduce retention setting that depends on space

2011-09-07 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-70?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13099027#comment-13099027 ] Jun Rao commented on KAFKA-70: -- Prashanth, Not sure if you still have those questions in the d

[jira] [Commented] (KAFKA-70) Introduce retention setting that depends on space

2011-09-05 Thread Prashanth Menon (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-70?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13097606#comment-13097606 ] Prashanth Menon commented on KAFKA-70: -- Hi there, I'm currently looking into this issue