Re: Review Request 129724: [frameworks] Enable -Wsuggest-override for g++ >= 5.0.0

> On Dec. 30, 2016, 6:39 a.m., Martin Gräßlin wrote: > > Is that enabled by default now? I hope not! This is a completely useless > > warning for all frameworks (as we are not allowed to use override) and even > > more for a legacy code bases. I don't want to have to adjust the cmake in > > al

Re: Review Request 129724: [frameworks] Enable -Wsuggest-override for g++ >= 5.0.0

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129724/#review101664 --- Is that enabled by default now? I hope not! This is a comple

Re: Review Request 129708: C project also need Clang Sanitizer

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129708/ --- (Updated Dec. 30, 2016, 4:19 a.m.) Status -- This change has been ma

Re: Review Request 129708: C project also need Clang Sanitizer

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129708/ --- (Updated 十二月 30, 2016, 11:17 a.m.) Review request for Extra Cmake Modules

Re: Review Request 129724: [frameworks] Enable -Wsuggest-override for g++ >= 5.0.0

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129724/ --- (Updated Dec. 29, 2016, 11:48 p.m.) Status -- This change has been m

Re: Review Request 129724: [frameworks] Enable -Wsuggest-override for g++ >= 5.0.0

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129724/#review101662 --- Ship it! LGTM, and the Clang equivalent (-Winconsistent-m

Review Request 129724: [frameworks] Enable -Wsuggest-override for g++ >= 5.0.0

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129724/ --- Review request for Build System and KDE Frameworks. Repository: extra-cma

[Differential] [Commented On] D3850: Pass -fno-operator-names when supported

rakuco added a comment. Isn't it better to use `check_cxx_compiler_flag` to see if the flag is supported and enable it in case it is? REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D3850 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emai

Re: Review Request 129708: C project also need Clang Sanitizer

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129708/#review101656 --- Ship it! Maybe you can add a TODO to investigate it for g

[Differential] [Updated] D3850: Pass -fno-operator-names when supported

ltoscano added a reviewer: Buildsystem. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D3850 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: kfunk, #frameworks, ivan, #buildsystem Cc: elvisangelaccio

[Differential] [Closed] D3733: Force colored warnings in ninja's output

This revision was automatically updated to reflect the committed changes. Closed by commit R240:dc525a42ae70: Enable colored warnings in ninja's output (authored by elvisangelaccio). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3733?vs=9437&id=94

[Differential] [Accepted] D3733: Force colored warnings in ninja's output

kfunk accepted this revision. kfunk added a comment. This revision is now accepted and ready to land. LGTM REPOSITORY R240 Extra CMake Modules BRANCH ninja-colors REVISION DETAIL https://phabricator.kde.org/D3733 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpref

[Differential] [Updated, 8 lines] D3733: Force colored warnings in ninja's output

elvisangelaccio updated this revision to Diff 9437. elvisangelaccio added a comment. - Add color switch only if the generator is Ninja REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3733?vs=9169&id=9437 BRANCH ninja-colors REVISION DETAIL

Re: Review Request 129708: C project also need Clang Sanitizer

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129708/#review101639 --- Ship it! Ship It! - David Faure On Dec. 29, 2016, 2:48

[Differential] [Requested Changes To] D3733: Force colored warnings in ninja's output

kfunk requested changes to this revision. kfunk added a reviewer: kfunk. kfunk added a comment. This revision now requires changes to proceed. This flag is only needed for Ninja, correct? Thus please check for Ninja in `CMAKE_GENERATOR ` before adding the compiler flag. REPOSITORY R240 Extr