kossebau added a comment.
A .rst file in the docs/module/ directory is needed, otherwise the
documentation generation will not pick up this, as it runs only over docs/.
Please enable the documentation generation in your ecm build and check for
yourself, by e.g. ensuring `BUILD_HTML_DOCS`
pino added inline comments.
INLINE COMMENTS
> davidedmundson wrote in ECMConfiguredInstall.cmake:46-48
> Maybe.
>
> My rationale for not forcing a suffix is sometimes we do this configure dance
> for .desktop files and there we have to be a bit careful with scripty.
>
> But generally it's
davidedmundson added inline comments.
INLINE COMMENTS
> pino wrote in ECMConfiguredInstall.cmake:46-48
> considering we are documenting the input file as `.cmake.in`, should we
> enforce this here and ignore any file not ending like that?
Maybe.
My rationale for not forcing a suffix is
pino added a comment.
Nice one! I cannot test right now though, I might do it over the weekend (do
not hold on me though).
I took the liberty of doing some formatting changes to the header of the new
file, what do you think?
#.rst:
# ECMConfiguredInstall
#
davidedmundson updated this revision to Diff 78693.
davidedmundson added a comment.
Good idea. Done
REPOSITORY
R240 Extra CMake Modules
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D28355?vs=78678=78693
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D28355
pino added a comment.
Can you please adapt it so `_template` can be an absolute path?
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D28355
To: davidedmundson
Cc: pino, kde-frameworks-devel, kde-buildsystem, LeGast00n, cblack, GB_2,
bencreasy, michaelh,
davidedmundson created this revision.
Herald added projects: Frameworks, Build System.
Herald added subscribers: kde-buildsystem, kde-frameworks-devel.
davidedmundson requested review of this revision.
REVISION SUMMARY
This, as the name suggests, configures a file and installs it.
It's not
