Re: Changing my mind: reverting my menubar, toolbars and statusbar changes

2010-11-07 Thread Ingo Klöcker
On Saturday 06 November 2010, Ingomar Wesp wrote: > Aurélien Gâteau wrote: > > I have been quite busy trying to convince everyone actions to > > toggle UI items such as menubar, toolbars, sidebars or statusbar > > should be labeled "Show/hide Foo" depending on the visibility of > > Foo rather than

Re: Review Request: Four simple patches for kdecore

2010-11-07 Thread Jaime Torres
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5775/ --- (Updated 2010-11-07 12:54:32.253284) Review request for kdelibs. Changes -

Re: Review Request: Four simple patches for kdecore

2010-11-07 Thread Albert Astals Cid
> On 2010-11-07 02:06:16, Dawit Alemayehu wrote: > > /trunk/KDE/kdelibs/kdecore/localization/klocale_kde.cpp, line 2699 > > > > > > The iterators here should be changed to constBegin() and constEnd(). > > Actually,

Re: Review Request: Four simple patches for kdecore

2010-11-07 Thread Jaime Torres
> On 2010-11-07 02:06:16, Dawit Alemayehu wrote: > > /trunk/KDE/kdelibs/kdecore/network/netsupp.cpp, line 419 > > > > > > Actually, the better fix here would simply be to move the code block > > that allocates and ch

Re: Review Request: Four simple patches for kdecore

2010-11-07 Thread David Jarvie
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5775/#review8535 --- /trunk/KDE/kdelibs/kdecore/date/ktimezone.cpp

Re: Review Request: Four simple patches for kdecore

2010-11-07 Thread Jaime Torres
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5775/ --- (Updated 2010-11-07 14:17:29.120532) Review request for kdelibs. Changes -

Re: Changing my mind: reverting my menubar, toolbars and statusbar changes

2010-11-07 Thread Aurélien Gâteau
On 07/11/2010 14:16, David Jarvie wrote: > On Sunday 07 November 2010 09:31:44 Ingo Klöcker wrote: >> On Saturday 06 November 2010, Ingomar Wesp wrote: >>> Aurélien Gâteau wrote: I have been quite busy trying to convince everyone actions to toggle UI items such as menubar, toolbars, sideb

Re: Changing my mind: reverting my menubar, toolbars and statusbar changes

2010-11-07 Thread Aurélien Gâteau
On 06/11/2010 22:26, Ingomar Wesp wrote: > Aurélien Gâteau wrote: >> I have been quite busy trying to convince everyone actions to toggle UI >> items such as menubar, toolbars, sidebars or statusbar should be labeled >> "Show/hide Foo" depending on the visibility of Foo rather than >> implemented a

Re: Review Request: Four simple patches for kdecore

2010-11-07 Thread Albert Astals Cid
> On 2010-11-07 02:06:16, Dawit Alemayehu wrote: > > /trunk/KDE/kdelibs/kdecore/network/netsupp.cpp, line 419 > > > > > > Actually, the better fix here would simply be to move the code block > > that allocates and ch

Fwd: Using multiple klocales uses stale translations

2010-11-07 Thread Stephen Kelly
Moving to k-c-d. --- Forwarded message (begin) Subject: Using multiple klocales uses stale translations From: Stephen Kelly Date: Sun, 07 Nov 2010 15:03:01 +0100 Newsgroup: gmane.comp.kde.devel.internationalization-and-documentation Hi, I'm trying to get strings from different loc

Re: Review Request: Four simple patches for kdecore

2010-11-07 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5775/#review8543 --- I am personally not conveinced the need for changing from usleep t

Re: Review Request: Four simple patches for kdecore

2010-11-07 Thread Rolf Eike Beer
Dawit Alemayehu wrote: > --- > This is an automatically generated e-mail. To reply, visit: > http://svn.reviewboard.kde.org/r/5775/#review8543 > --- > > > I am personally not conveinced

Re: Changing my mind: reverting my menubar, toolbars and statusbar changes

2010-11-07 Thread Ingo Klöcker
On Sunday 07 November 2010, David Jarvie wrote: > On Sunday 07 November 2010 09:31:44 Ingo Klöcker wrote: > > On Saturday 06 November 2010, Ingomar Wesp wrote: > > > Aurélien Gâteau wrote: > > > > I have been quite busy trying to convince everyone actions to > > > > toggle UI items such as menubar,

Important KDE 4.6 Freezes This Week

2010-11-07 Thread Tom Albers
Hi all, Please note that the following freezes will become active this week: Thursday, November 11, 2010: Soft Message Freeze All translated messages (GUI strings) are frozen on this date. Only previously untranslated strings or clear errors in strings can be fixed. No major new strings changes

Re: Changing my mind: reverting my menubar, toolbars and statusbar changes

2010-11-07 Thread Ingo Klöcker
On Sunday 07 November 2010, David Jarvie wrote: > On Sunday 07 November 2010 19:12:46 Ingo Klöcker wrote: > > On Sunday 07 November 2010, David Jarvie wrote: > > > On Sunday 07 November 2010 09:31:44 Ingo Klöcker wrote: > > > > On Saturday 06 November 2010, Ingomar Wesp wrote: > > > > > Aurélien Gâ

Re: Fwd: Using multiple klocales uses stale translations

2010-11-07 Thread Chusslove Illich
> [: Stephen Kelly :] > Clearly someone decided that should be commented out. Should what I am > trying work already, or does that need to be uncommented? It was I who both added and later commented out that code. As per the note, I commented it out because I didn't think of the use case, even tho

Re: Review Request: Add DevicePrivate pointer to DeviceInterfacePrivate

2010-11-07 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5769/#review8544 --- Ship it! Please adjust DeviceInterfacePrivate ctor as indicated b

Re: Review Request: Add isReleased() method to StorageDrive interface

2010-11-07 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5770/#review8545 --- trunk/KDE/kdelibs/solid/solid/storagedrive.h

Review Request: Allow kdelibs compilation with QT_USE_FAST_CONCATENATION & QT_USE_FAST_OPERATOR_PLUS flags...

2010-11-07 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5795/ --- Review request for kdelibs. Summary --- The attached patch makes it pos

Re: Changing my mind: reverting my menubar, toolbars and statusbar changes

2010-11-07 Thread Johannes Sixt
Am 11/7/2010 20:12, schrieb Ingo Klöcker: > Quite frankly, I cannot image the number of users which grasp "[ ] Show > Toolbar" but not "[ ] Toolbar" to be significant. Surely, there are a > lot of not that computer literate people (like my parents) who > understand neither one nor the other. But

Review Request: Few minor improvments for UDisks solid backend manager...

2010-11-07 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5797/ --- Review request for kdelibs. Summary --- The attached patch does the fol

Re: Review Request: Few minor improvments for UDisks solid backend manager...

2010-11-07 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5797/#review8547 --- Please resubmit on the solid group. Thanks in advance. - Kevin

Re: Review Request: Allow kdelibs compilation with QT_USE_FAST_CONCATENATION & QT_USE_FAST_OPERATOR_PLUS flags...

2010-11-07 Thread Stephen Kelly
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5795/#review8548 --- trunk/KDE/kdelibs/kate/plugins/exporter/htmlexporter.cpp