Re: More about kdelibs unittests

2010-12-13 Thread Aurélien Gâteau
On 10/12/2010 00:44, David Faure wrote: Yes, this will crash with QT_FATAL_WARNINGS. So? It's good to have a unit test test border conditions too, even if these conditions lead to warnings from Qt. One could try to use QTest::ignoreMessage() [1] to skip expected error messages. Does not

Re: Review Request: In System Settings in French the icon's description is badly cut when there is a single quote

2010-12-13 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6106/#review9226 --- Ship it! A new unittest for a string handling method == great!

Review Request: Adjust the kde fake mimetype fonts/package so desktop-file-utils/shared-mime-info do not complain

2010-12-13 Thread Rex Dieter
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6111/ --- Review request for kdelibs. Summary --- This patch adjusts the kde

Re: Review Request: Adjust the kde fake mimetype fonts/package so desktop-file-utils/shared-mime-info do not complain

2010-12-13 Thread Ingo Klöcker
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6111/#review9232 --- How about using vnd.kde.fontspackage instead of

Re: Review Request: Adjust the kde fake mimetype fonts/package so desktop-file-utils/shared-mime-info do not complain

2010-12-13 Thread Rex Dieter
On 2010-12-13 16:48:31, Ingo Klöcker wrote: How about using vnd.kde.fontspackage instead of x-kde-fontspackage? I only used x-kde-fontspackage at aaron's suggestion in one of the aforementioned bugs, I'm not attached to it. vnd.kde.fontspackage is fine with me too. - Rex

Re: Review Request: Adjust the kde fake mimetype fonts/package so desktop-file-utils/shared-mime-info do not complain

2010-12-13 Thread Christopher Yeleighton
On 2010-12-13 16:48:31, Ingo Klöcker wrote: How about using vnd.kde.fontspackage instead of x-kde-fontspackage? Rex Dieter wrote: I only used x-kde-fontspackage at aaron's suggestion in one of the aforementioned bugs, I'm not attached to it. vnd.kde.fontspackage is fine with me

Action icons in menus

2010-12-13 Thread Miha Čančula
I have recently come across an idea on KDE Brainstorm. [1] The proposal is to change the common actions in menus (cut, copy and paste) from text lines to icons, like in application toolbars. It is currently the most popular idea there. Someone posted a proof-of-concept example of how this can

Re: Action icons in menus

2010-12-13 Thread Albert Astals Cid
A Dilluns, 13 de desembre de 2010, Miha Čančula va escriure: I have recently come across an idea on KDE Brainstorm. [1] The proposal is to change the common actions in menus (cut, copy and paste) from text lines to icons, like in application toolbars. It is currently the most popular idea

Re: Action icons in menus

2010-12-13 Thread Miha Čančula
Dne ponedeljek 13 decembra 2010 ob 21:32:30 je Albert Astals Cid napisal(a): Does this break keyboard navigation in the menu? Yes, unfortunately it does, I just tried. The elements displayed this way are not selectable by keyboard, even thought other actions in the same menu are.

Re: Action icons in menus

2010-12-13 Thread Albert Astals Cid
A Dilluns, 13 de desembre de 2010, Miha Čančula va escriure: Dne ponedeljek 13 decembra 2010 ob 21:32:30 je Albert Astals Cid napisal(a): Does this break keyboard navigation in the menu? Yes, unfortunately it does, I just tried. The elements displayed this way are not selectable by

Re: Action icons in menus

2010-12-13 Thread Albert Astals Cid
A Dilluns, 13 de desembre de 2010, Miha Čančula va escriure: 2010/12/13 Albert Astals Cid aa...@kde.org A Dilluns, 13 de desembre de 2010, Miha Čančula va escriure: Dne ponedeljek 13 decembra 2010 ob 21:32:30 je Albert Astals Cid napisal(a): Does this break keyboard navigation in

Re: Action icons in menus

2010-12-13 Thread Parker Coates
On Mon, Dec 13, 2010 at 16:26, Miha Čančula wrote: 2010/12/13 Albert Astals Cid aa...@kde.org A Dilluns, 13 de desembre de 2010, Miha Čančula va escriure: Dne ponedeljek 13 decembra 2010 ob 21:32:30 je Albert Astals Cid napisal(a): Does this break keyboard navigation in the menu? Yes,

Re: Action icons in menus

2010-12-13 Thread Aaron J. Seigo
On Monday, December 13, 2010, Dan Meltzer wrote: If common actions were all handled in this way, then it might actually lead to more consistancy, consistency with what? certainly not with the menus, where we will now have items that behave differently. (as a side note: this will break with

Re: Action icons in menus

2010-12-13 Thread Markus Slopianka
Am Dienstag 14 Dezember 2010, 00:01:54 schrieb Aaron J. Seigo: (as a side note: this will break with dbusmenu; so it can't find its way easily into the system tray icon menus, for instance) If it breaks dbusmenu, all the work on the Global Menu Bar front would go to waste as well.

Re: Action icons in menus

2010-12-13 Thread Markus Slopianka
In principle I like the idea. But can the execution also work in other areas? How many items can be grouped together in a feasible way? Currently I have KWrite open. When I look at the Edit menu, I see: Find, Find Next, Find Previous, Replace, Find Selected, Find Selected Backwards. Those are six