Re: Action icons in menus

2010-12-14 Thread Ingo Klöcker
On Tuesday 14 December 2010, David Jarvie wrote: > On Tue, December 14, 2010 2:52 pm, Ingo Klöcker wrote: > > On Tuesday 14 December 2010, David Jarvie wrote: > >> On Monday 13 December 2010 20:32:30 Albert Astals Cid wrote: > >> > 5. There is no space to show the shortcut (i.e. Ctrl+C for Copy) >

Re: Advice needed on BIC

2010-12-14 Thread Thiago Macieira
Em Terça-feira, 14 de Dezembro de 2010, às 20:53:50, Alexander Neundorf escreveu: > A private function cannot be called by anybody outside the class, it can > only be called from within the class, so private symbols should not make > it into any user of the class, so removing private functions sho

Re: Advice needed on BIC

2010-12-14 Thread Alexander Neundorf
On Tuesday 14 December 2010, John Layt wrote: > Hi, > > I'm been reading the BIC techbase pages again to make sure the api changes > I've done in 4.6 won't cause problems. > > I had always thought it was BIC safe to 'promote' api to less restricted > access levels, however I notice now that this do

Re: Advice needed on BIC

2010-12-14 Thread Aaron J. Seigo
On Tuesday, December 14, 2010, John Layt wrote: > Now, I've introduced some private functions in the 4.5. and 4.6 that may that's the problem right there, really: never, ever introduce private functions in public libraries. that's what we have dptrs for: add them to the private class and access

Re: kdebase-workspace and kdebase-runtime git repos to validate

2010-12-14 Thread Ian Monroe
On Mon, Dec 13, 2010 at 18:22, Ian Monroe wrote: > So kdelibs and kdebase are switching to Git, probably not Dec 20/21 as > was previously thought, but at the release of 4.6.0. > > Whether its next week or next month though, its pretty soon. :) > > I have three work-in-progress repos, the first tw

Advice needed on BIC

2010-12-14 Thread John Layt
Hi, I'm been reading the BIC techbase pages again to make sure the api changes I've done in 4.6 won't cause problems. I had always thought it was BIC safe to 'promote' api to less restricted access levels, however I notice now that this doesn't work under Windows and so is now considered BIC

Re: Action icons in menus

2010-12-14 Thread Miha Čančula
Dne torek 14 decembra 2010 ob 16:08:42 je David Jarvie napisal(a): > On Tue, December 14, 2010 2:52 pm, Ingo Klöcker wrote: > > On Tuesday 14 December 2010, David Jarvie wrote: > >> On Monday 13 December 2010 20:32:30 Albert Astals Cid wrote: > >> > 5. There is no space to show the shortcut (i.e. C

Re: Review Request: Adjust the kde "fake" mimetype fonts/package so desktop-file-utils/shared-mime-info do not complain

2010-12-14 Thread Rex Dieter
> On 2010-12-14 12:59:34, David Faure wrote: > > The real question is whether this mimetype is used for files, or only for > > internal "fake" purposes. If for files, then it should be added to > > shared-mime-info (Pino or I can help with that). > > But if I remember correctly in this case it'

Re: Action icons in menus

2010-12-14 Thread Andreas Pakulat
On 14.12.10 15:52:39, Ingo Klöcker wrote: > On Tuesday 14 December 2010, David Jarvie wrote: > > On Monday 13 December 2010 20:32:30 Albert Astals Cid wrote: > > > 5. There is no space to show the shortcut (i.e. Ctrl+C for Copy) > > > > IMO, this is a very important drawback. There would then be n

Re: Action icons in menus

2010-12-14 Thread David Jarvie
On Tue, December 14, 2010 2:52 pm, Ingo Klöcker wrote: > On Tuesday 14 December 2010, David Jarvie wrote: >> On Monday 13 December 2010 20:32:30 Albert Astals Cid wrote: >> > 5. There is no space to show the shortcut (i.e. Ctrl+C for Copy) >> >> IMO, this is a very important drawback. There would t

Re: Action icons in menus

2010-12-14 Thread Ingo Klöcker
On Tuesday 14 December 2010, David Jarvie wrote: > On Monday 13 December 2010 20:32:30 Albert Astals Cid wrote: > > 5. There is no space to show the shortcut (i.e. Ctrl+C for Copy) > > IMO, this is a very important drawback. There would then be no easy > way for users who didn't know the keyboard

Re: Review Request: Adjust the kde "fake" mimetype fonts/package so desktop-file-utils/shared-mime-info do not complain

2010-12-14 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6111/#review9248 --- The real question is whether this mimetype is used for files, or o

Re: Action icons in menus

2010-12-14 Thread Hans Meine
Am Montag 13 Dezember 2010, 23:42:37 schrieb Dan Meltzer: > If common actions were all handled in this way, then it might > actually lead to more consistancy, and ease of access. I don't know.. how do I know whether I need to look for a large toolbar button at the top or for a regular menu entry

Re: Review Request: Adjust the kde "fake" mimetype fonts/package so desktop-file-utils/shared-mime-info do not complain

2010-12-14 Thread Christopher Yeleighton
> On 2010-12-13 16:48:31, Ingo Klöcker wrote: > > How about using vnd.kde.fontspackage instead of x-kde-fontspackage? > > Rex Dieter wrote: > I only used x-kde-fontspackage at aaron's suggestion in one of the > aforementioned bugs, I'm not attached to it. vnd.kde.fontspackage is fine > wi

Re: Action icons in menus

2010-12-14 Thread Nuno Pinheiro
A Segunda, 13 de Dezembro de 2010 23:48:54 Markus Slopianka você escreveu: > In principle I like the idea. > But can the execution also work in other areas? > How many items can be grouped together in a feasible way? > > Currently I have KWrite open. When I look at the Edit menu, I see: > Find, Fi