Re: Review Request: Fix a VLC crash by delaying object deletion to avoid invalid access by QtDBus...

2011-04-12 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100577/ --- (Updated April 12, 2011, 10:22 p.m.) Review request for kdelibs and Thiago

Re: Review Request: Add missing KAuthorize "hooks" on KFileItemActions

2011-04-12 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101082/#review2598 --- Ship it! looks good; other code using this might Do The Right T

Re: Review Request: Fix directory navigation in Dolphin::Terminal.

2011-04-12 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101096/#review2589 --- This review has been submitted with commit 5f78219e18073e475ed1

Re: Review Request: Patch for "FTP ioslave unnecessarily asks for password"

2011-04-12 Thread Dawit Alemayehu
> On April 12, 2011, 9:22 a.m., David Faure wrote: > > Thanks, looks good to me. I do think that if I have a stored login/password > > for an ftp site, then I don't want to get an anonymous login when I go back > > there again, typically one can access more stuff with authenticated login. > >

Re: Review Request: Patch for "FTP ioslave unnecessarily asks for password"

2011-04-12 Thread Rolf Eike Beer
> This raises the question of how to test anonymous > login on a site with cached auth though -- well, there's always the option > of renaming stuff in kwalletmanager ;) ftp://ftp@site usually works, ftp://anonymous@site may also work. Eike

Re: Review Request: Patch for "FTP ioslave unnecessarily asks for password"

2011-04-12 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100873/#review2573 --- Ship it! Thanks, looks good to me. I do think that if I have a

Re: MIME type selection and priorities

2011-04-12 Thread David Faure
On Wednesday 06 April 2011, Fabian Aichele wrote: > Hence my question: Is it possible to override the MIME type priorities > so that my custom-generated MIME types are used instead of those > KMimeTypeTrader would select by default (even if that selection is a > better match than solely by the file