Regarding kdelibs/kio

2011-06-05 Thread tushar mehta
Hi all, I am currently trying to understand how kde applications uses kio for doing file related operations. I am currently working on kget and as part of my summer of code project task I need to figure out how we can have speed limit on transfer using kio protocols like http/ftp. Do have we have

Review Request: Fix GUI thread blocking caused by KFilePreviewGenerator when disablingpreview

2011-06-05 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101512/ --- Review request for kdelibs and Peter Penz. Summary --- The attached s

Re: Review Request: Fix GUI thread blocking caused by KFilePreviewGenerator when disabling preview

2011-06-05 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101512/ --- (Updated June 5, 2011, 7:07 p.m.) Review request for kdelibs and Peter Pen

Re: Review Request: Do not emit KLineEdit::textEdited when a user scrolls through the popup completion list

2011-06-05 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101498/#review3692 --- This review has been submitted with commit 8db60a2fe40fc00cbf27

Re: Review Request: Do not emit KLineEdit::textEdited when a user scrolls through the popup completion list

2011-06-05 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101498/#review3693 --- This review has been submitted with commit 26c378fe5cf0da01b641

Re: Review Request: Fix GUI thread blocking caused by KFilePreviewGenerator when disabling preview

2011-06-05 Thread Peter Penz
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101512/#review3694 --- > The attached single line patch... I think you forgot to attac

Re: Review Request: Fix GUI thread blocking caused by KFilePreviewGenerator when disabling preview

2011-06-05 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101512/ --- (Updated June 5, 2011, 10:13 p.m.) Review request for kdelibs and Peter Pe

Re: Review Request: Do not emit KLineEdit::textEdited when a user scrolls through the popup completion list

2011-06-05 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101498/#review3696 --- Ship it! Reviewed (not this patch, but the committed 26c378fe5c

Re: Review Request: remove functions *Command::name() which are not used

2011-06-05 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101343/#review3698 --- OK, that's one solution. The other solution would be to fix the

Re: Review Request: a very little fix

2011-06-05 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101433/#review3699 --- Ship it! Such trivial fixes don't even need to go through revie

Re: Review Request: Rebuild fake locale as soon as possible

2011-06-05 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101509/#review3700 --- Ship it! Looks good. - David On June 5, 2011, 12:23 a.m., Al

Re: Review Request: Fix compile of KIO with KDE_ENABLE_FINAL enabled.

2011-06-05 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101277/#review3701 --- Ship it! Go for it, my friend. - David On May 2, 2011, 9:34

Re: Review Request: KMainWindow::parseGeometry() fails to position with positive coordinates

2011-06-05 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101492/#review3702 --- Looks good overall, but I think I found a bug with negative coor

Re: Review Request: startkde.cmake should treat font dpi like kcontrol/krdb/krdb.cpp does

2011-06-05 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101410/#review3703 --- Ship it! Looks good. Do you want me to commit this for you, or

Re: Review Request: Fix keypress stealing issue

2011-06-05 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101491/#review3704 --- Ship it! Patch is okay, I didn't realize the issue was that sim

Re: Review Request: Fix GUI thread blocking caused by KFilePreviewGenerator when disabling preview

2011-06-05 Thread Peter Penz
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101512/#review3706 --- Ship it! Thanks, please just go ahead and push the patch! Rega

Re: Review Request: kcm-grub2

2011-06-05 Thread Konstantinos Smanis
Raphael Kubo da Costa gmail.com> writes: > > Konstantinos Smanis gmail.com> writes: > > > I have talked with Alberto Mattea (the maintainer of kcmgrub2) and he > > has agreed to give up his request for inclusion in extragear. > > > > Our conversation has been over plain e-mails, so I cannot prove