Re: Review Request: kio_http: fix keepalive timeout parsing

2011-10-12 Thread Andreas Hartmetz
> On Oct. 12, 2011, 10:58 p.m., Andreas Hartmetz wrote: > > kioslave/http/http.cpp, line 3107 > > > > > > I guess the parser just lowercases the key ("keep-alive"), not the > > values. Lowercasing the keys is okay

Re: Review Request: kio_http: fix keepalive timeout parsing

2011-10-12 Thread Andreas Hartmetz
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102822/#review7283 --- Ship it! kioslave/http/http.cpp

Re: Review Request: Cleanup the use of HTTPProtocol::httpClose

2011-10-12 Thread Andreas Hartmetz
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102801/#review7282 --- This changeset changes some important parts without obvious (to

Re: Screensaver to be or not to be (was: Re: Security Audit Request for Screenlocker Branch)

2011-10-12 Thread Michael Pyne
On Wednesday, October 12, 2011 20:43:41 Thomas Lübking wrote: > Am Tue, 11 Oct 2011 21:46:40 -0400 schrieb Michael Pyne : > > Yes. KDE asciiquarium (feel free to look at the copyright headers for > > that in kdeartwork someday... ;) > > Errr... rather not. The author, *cough* who ever he might be *

Re: Security Audit Request for Screenlocker Branch

2011-10-12 Thread Thomas Lübking
Am Wed, 12 Oct 2011 09:10:40 +0200 schrieb Oswald Buddenhagen : > that's not a response to my question. the old lock engine offers the > option to start a saver which only after a few seconds requires a > password to make it go away. I think it was, because the idea is that the locker, unlike today

Re: Screensaver to be or not to be (was: Re: Security Audit Request for Screenlocker Branch)

2011-10-12 Thread Thomas Lübking
Am Tue, 11 Oct 2011 21:46:40 -0400 schrieb Michael Pyne : > Yes. KDE asciiquarium (feel free to look at the copyright headers for > that in kdeartwork someday... ;) Errr... rather not. The author, *cough* who ever he might be *cough* has apparently so far not found the time to implement the resize

Re: Screensaver to be or not to be (was: Re: Security Audit Request for Screenlocker Branch)

2011-10-12 Thread Alexander Neundorf
On Wednesday 12 October 2011, Martin Gräßlin wrote: > On Wednesday 12 October 2011 08:26:20 Torgny Nyblom wrote: > > On Tuesday 11 October 2011 20.54.42 Thomas Lübking wrote: > > > Am Tue, 11 Oct 2011 18:02:32 +0200 > > > > > > schrieb Torgny Nyblom : > > > > Screensaver is bling only > > > > > >

Re: Re: Re: Security Audit Request for Screenlocker Branch

2011-10-12 Thread Oswald Buddenhagen
On Wed, Oct 12, 2011 at 04:47:54PM +0200, Dario Freddi wrote: > 2011/10/12 Martin Gräßlin : > > ok I have been thinking about it and have a new proposal: > > * writing a kded module to only handle the screen locking (grab keyboard and > > mouse) > > TBH, if you really care about not making the thi

Re: Re: Re: Security Audit Request for Screenlocker Branch

2011-10-12 Thread Dario Freddi
2011/10/12 Martin Gräßlin : > On Wednesday 12 October 2011 09:10:40 Oswald Buddenhagen wrote: >> > Of course KWin is a more complex application than others, but given >> > what we need in a screen locker the difference becomes marginal IMHO. >> >> yes. one should consider decoupling the greeter fro

Re: Re: Re: Security Audit Request for Screenlocker Branch

2011-10-12 Thread Martin Gräßlin
On Wednesday 12 October 2011 09:10:40 Oswald Buddenhagen wrote: > > Of course KWin is a more complex application than others, but given > > what we need in a screen locker the difference becomes marginal IMHO. > > yes. one should consider decoupling the greeter from the core engine. > > > > > I m

Re: Re: Security Audit Request for Screenlocker Branch

2011-10-12 Thread Oswald Buddenhagen
On Tue, Oct 11, 2011 at 06:30:40PM +0200, Martin Gräßlin wrote: > On Tuesday 11 October 2011 17:34:10 Oswald Buddenhagen wrote: > > on a more serious note, [h]ow do you handle the lock grace time? > > this is actually not affected by the changes. Dim Display and turning off the > screen are decoup

Re: Re: Screensaver to be or not to be (was: Re: Security Audit Request for Screenlocker Branch)

2011-10-12 Thread Martin Gräßlin
On Wednesday 12 October 2011 08:26:20 Torgny Nyblom wrote: > On Tuesday 11 October 2011 20.54.42 Thomas Lübking wrote: > > Am Tue, 11 Oct 2011 18:02:32 +0200 > > > > schrieb Torgny Nyblom : > > > Screensaver is bling only > > > > No, "screensaver hacks are bling only", a "screensaver" is a > > soft