Review Request: Fix crash with --waitforwm

2011-12-19 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103478/ --- Review request for kdelibs. Description --- KApplication references a

Re: Review Request: Make KGlobalSettings reread locale settings before calling settingsChanged().

2011-12-19 Thread Lamarque Vieira Souza
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103469/ --- (Updated Dec. 19, 2011, 10:15 p.m.) Review request for kdelibs and Plasma.

Re: Review Request: Rework kdebugdialog --fullmode ui

2011-12-19 Thread Aurélien Gâteau
> On Dec. 19, 2011, 6:45 p.m., David Faure wrote: > > Ah! OK, sorry, I mixed the proposal and the comment on the proposal. > > > > So this patch does not merge them, it only makes fullmode more usable - no > > objections. Thanks, merged. - Aurélien -

Re: Review Request: Make KGlobalSettings reread locale settings before calling settingsChanged().

2011-12-19 Thread Lamarque V. Souza
Em Monday 19 December 2011, David Faure escreveu: > On Monday 19 December 2011 15:01:51 Lamarque V. Souza wrote: > > Em Monday 19 December 2011, David Faure escreveu: > > > On Monday 19 December 2011 15:46:14 Lamarque Vieira Souza wrote: > > > > > On Dec. 19, 2011, 2:35 p.m., David Faure wrote: > >

Re: Review Request: Fix KStatusNotifierItem not updating its icon when set by pixmap

2011-12-19 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103425/#review9100 --- This review has been submitted with commit 0e6bff7eda907d065f48

Re: Review Request: Do not prevent favicons from being shown for local HTML pages

2011-12-19 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103474/#review9099 --- This review has been submitted with commit acbaff6a08873534f3d6

Re: Review Request: Rework kdebugdialog --fullmode ui

2011-12-19 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103403/#review9093 --- Ship it! Ah! OK, sorry, I mixed the proposal and the comment on

Re: Review Request: Make KGlobalSettings reread locale settings before calling settingsChanged().

2011-12-19 Thread David Faure
On Monday 19 December 2011 15:01:51 Lamarque V. Souza wrote: > Em Monday 19 December 2011, David Faure escreveu: > > On Monday 19 December 2011 15:46:14 Lamarque Vieira Souza wrote: > > > > On Dec. 19, 2011, 2:35 p.m., David Faure wrote: > > > > > kdeui/kernel/kglobalsettings.cpp, line 886 > > > >

Re: Review Request: Rework kdebugdialog --fullmode ui

2011-12-19 Thread Aurélien Gâteau
> On Dec. 18, 2011, 9:02 a.m., David Faure wrote: > > How does one simply enable/disable individual areas? Using the comboboxes? > > I think the fast-mode-checkbox should stay, in the list widget. Other than > > that, it looks good. What do you mean with "fast-mode-checkbox"? If you are referr

Re: Review Request: Do not prevent favicons from being shown for local HTML pages

2011-12-19 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103474/#review9090 --- Ship it! Ah I see, this code is called when a new favicon is av

Re: Review Request: Make KGlobalSettings reread locale settings before calling settingsChanged().

2011-12-19 Thread Lamarque V. Souza
Em Monday 19 December 2011, David Faure escreveu: > On Monday 19 December 2011 15:46:14 Lamarque Vieira Souza wrote: > > > On Dec. 19, 2011, 2:35 p.m., David Faure wrote: > > > > kdeui/kernel/kglobalsettings.cpp, line 886 > > > >

Review Request: Do not prevent favicons from being shown for local HTML pages

2011-12-19 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103474/ --- Review request for KDE Base Apps and David Faure. Description --- The

Re: Review Request: Make KGlobalSettings reread locale settings before calling settingsChanged().

2011-12-19 Thread David Faure
On Monday 19 December 2011 15:46:14 Lamarque Vieira Souza wrote: > > On Dec. 19, 2011, 2:35 p.m., David Faure wrote: > > > kdeui/kernel/kglobalsettings.cpp, line 886 > > > > > e886>> > > > > I like the idea (KGlobalSett

Re: Review Request: Make KGlobalSettings reread locale settings before calling settingsChanged().

2011-12-19 Thread Lamarque Vieira Souza
> On Dec. 19, 2011, 2:35 p.m., David Faure wrote: > > kdeui/kernel/kglobalsettings.cpp, line 886 > > > > > > I like the idea (KGlobalSettings reparsing configuration), but not the > > implementation (setLanguage(la

Re: Review Request: Make KGlobalSettings reread locale settings before calling settingsChanged().

2011-12-19 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103469/#review9078 --- kdeui/kernel/kglobalsettings.cpp

Re: Review Request: Reset time format upon user request

2011-12-19 Thread Lamarque Vieira Souza
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103434/ --- (Updated Dec. 19, 2011, 2:03 p.m.) Review request for kdelibs and Plasma.

Review Request: Make KGlobalSettings reread locale settings before calling settingsChanged().

2011-12-19 Thread Lamarque Vieira Souza
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103469/ --- Review request for kdelibs and Plasma. Description --- This is patch

FOSDEM 2012 - CrossDesktop DevRoom Call for Talks

2011-12-19 Thread Pau Garcia i Quiles
Hi, Deadline is quickly approaching! Please submit your proposals ASAP -- Forwarded message -- From: Pau Garcia i Quiles Date: Fri, Nov 18, 2011 at 12:50 AM Subject: FOSDEM 2012 - CrossDesktop DevRoom Call for Talks Hi, FOSDEM is one of the largest gatherings of Free Software

Re: Review Request: Reset time format upon user request

2011-12-19 Thread David Faure
On Sunday 18 December 2011 20:26:42 Lamarque V. Souza wrote: > Em Sunday 18 December 2011, David Faure escreveu: > > On Sunday 18 December 2011 12:51:25 Lamarque Vieira Souza wrote: > > > Another problem with this approach is that we cannot prevent anybody > > > else > > > from listening to > > > K