Re: Can we please have an updated and confirmed working "build KDE from source as separate user"?

On Monday, January 02, 2012 18:37:43 Mark wrote: > Oke, i don't get it.. > https://wiki.archlinux.org/index.php/Bash#.profile > > .profile gets sources in interactive login shell (kdm?) > .bashrc gets sourced in shells. > > I have my environment edits in .profile yet it still tried to run program

Re: Review Request: Factor out and reuse the code that guesses mime-type from filename

> On Jan. 2, 2012, 10:50 p.m., David Faure wrote: > > kparts/browseropenorsavequestion.cpp, line 287 > > > > > > I don't get what this call changes, here (with no filename passed to > > the method). It resolves al

Re: Review Request: Factor out and reuse the code that guesses mime-type from filename

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103617/#review9492 --- kparts/browseropenorsavequestion.cpp

Re: Review Request: Factor out and reuse the code that guesses mime-type from filename

> On Jan. 2, 2012, 10:50 p.m., David Faure wrote: > > kparts/browseropenorsavequestion.cpp, line 287 > > > > > > I don't get what this call changes, here (with no filename passed to > > the method). It resolves al

Re: Review Request: Factor out and reuse the code that guesses mime-type from filename

> On Jan. 3, 2012, 9:47 a.m., David Faure wrote: > > kparts/browseropenorsavequestion.cpp, line 340 > > > > > > So, this is passing the default mimetype as first argument, knowing > > very well that it won't be use

Re: Review Request: Factor out and reuse the code that guesses mime-type from filename

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103617/ --- (Updated Jan. 3, 2012, 2:34 p.m.) Review request for kdelibs. Changes --

Re: Review Request: Factor out and reuse the code that guesses mime-type from filename

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103617/#review9499 --- kparts/browseropenorsavequestion.cpp

Re: Review Request: Factor out and reuse the code that guesses mime-type from filename

> On Jan. 3, 2012, 2:51 p.m., Milian Wolff wrote: > > kparts/browseropenorsavequestion.cpp, line 105 > > > > > > am I misreading this, or will mime->comment() be called if !mime ? and > > hence result in a crash?

Review Request: Port shutdown dialog to QML

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103621/ --- Review request for KDE Base Apps and KDE Runtime. Description --- Por

Re: Review Request: Port shutdown dialog to QML

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103621/ --- (Updated Jan. 3, 2012, 5:20 p.m.) Review request for KDE Base Apps and KDE

Re: Review Request: Port shutdown dialog to QML

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103621/ --- (Updated Jan. 3, 2012, 5:34 p.m.) Review request for KDE Base Apps and KDE

Re: Review Request: Port shutdown dialog to QML

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103621/#review9516 --- Some of your QtQuick imports are 1.0 and some others 1.1, i gues

ktouchpadenabler moved to kdereview

My little kded daemon that listens to XF86XK_TouchpadToggle and enables disables the touchpad accordingly has been moved to kdereview. My plan is moving it to extragear, not really sure if -base or -utils. The code doesn't have a kcm or any kind of configuration since it is designed to "just wo

Re: Review Request: Port shutdown dialog to QML

> On Jan. 3, 2012, 9:38 p.m., Albert Astals Cid wrote: > > Some of your QtQuick imports are 1.0 and some others 1.1, i guess some > > consistency there would be nice > > > > You need to extract the i18n messages from the qml files > > > > And having the keyboard not working seems like a huge r

Re: Review Request: Port shutdown dialog to QML

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103621/#review9521 --- Very nice work, one of the things where QML makes sense. Are th

Re: Review Request: Port shutdown dialog to QML

> On Jan. 3, 2012, 9:38 p.m., Albert Astals Cid wrote: > > Some of your QtQuick imports are 1.0 and some others 1.1, i guess some > > consistency there would be nice > > > > You need to extract the i18n messages from the qml files > > > > And having the keyboard not working seems like a huge r

Re: ktouchpadenabler moved to kdereview

On Wednesday 04 January 2012 00:28:11 Albert Astals Cid wrote: > My little kded daemon that listens to XF86XK_TouchpadToggle and > enables disables the touchpad accordingly has been moved to > kdereview. > > My plan is moving it to extragear, not really sure if -base or > -utils. > > The code doe