Review Request: Add flock()/lockf()-based locking mechanizm to KSharedDataCache

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106237/ --- Review request for kdelibs and Michael Pyne. Description --- This pat

Re: Review Request: Move checks for locking primitives in KSharedDataCache to CMake

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106174/ --- (Updated Aug. 27, 2012, 6:54 p.m.) Review request for kdelibs and Michael

Re: Review Request: Move checks for locking primitives in KSharedDataCache to CMake

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106174/ --- (Updated Aug. 27, 2012, 5:10 p.m.) Review request for kdelibs and Michael

Re: Review Request: Move checks for locking primitives in KSharedDataCache to CMake

> On Aug. 27, 2012, 3:57 p.m., Alexander Neundorf wrote: > > Why do you want to do this ? > > > > Beside that, you are using CMakePushCheckState.cmake, which is part of > > cmake only since version 2.8.6. > > trunk still requires cmake 2.6.4, so this is not allowed, use > > MacroPushrequiredVa

Re: [RFC] Merging LightDM into KDE Workspaces (forwarded from plasma-devel)

On Mon, Aug 27, 2012 at 10:02 PM, Martin Sandsmark wrote: > Now I'm really confused, isn't the wallpaper just set in /etc/kde4/kdm/kdmrc? not if you're in themed mode. in which case the theme specifies it, afik -- Shaun Reich, KDE Software Developer (kde.org)

Re: Review Request: Add spinlocks lock type, based on GCC intrisincs

On Monday, August 27, 2012 20:18:34 Michael Pyne wrote: > On Tuesday, August 28, 2012 00:41:16 Thiago Macieira wrote: > > On segunda-feira, 27 de agosto de 2012 18.20.15, Michael Pyne wrote: > > > > Please use the Qt atomic types. Until GCC 4.7, they generate better > > > > code. > > > > > > I agr

Review Request: Make Sonnet::Speller::setLanguage threadsafe, fixing segfaults in krunner

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106242/ --- Review request for kdelibs and Plasma. Description --- Krunner's spel

Re: [RFC] Merging LightDM into KDE Workspaces (forwarded from plasma-devel)

On Tue, Aug 28, 2012 at 01:17:03AM +0200, Thomas Lübking wrote: > To me it sounds as if the package contains a postinstall script to > "useradd guest" for a pwdless login. > I cannot say to really appreciate such "feature" :-\ Uh, that sounds kind of bad for a DM, yes. > He's talking about the x

Re: Review Request: Add spinlocks lock type, based on GCC intrisincs

On Tuesday, August 28, 2012 00:41:16 Thiago Macieira wrote: > On segunda-feira, 27 de agosto de 2012 18.20.15, Michael Pyne wrote: > > > Please use the Qt atomic types. Until GCC 4.7, they generate better > > > code. > > > > I agree, the reason it wasn't that way initially is mentioned in the > >

Re: KCM Authorization (was: Re: Review Request: print-manager on kdereview)

2012/8/27 Thomas Lübking : > Am 27.08.2012, 22:53 Uhr, schrieb Daniel Nicoletti : > > >> So to avoid the application quiting modules that need to perform >> async tasks like talking to polkit or installing packages (Apper), >> they need to create an event loop so that current module accept() >> doe

Re: KCM Authorization (was: Re: Review Request: print-manager on kdereview)

Am 27.08.2012, 22:53 Uhr, schrieb Daniel Nicoletti : So to avoid the application quiting modules that need to perform async tasks like talking to polkit or installing packages (Apper), they need to create an event loop so that current module accept() doesn't return (if it does quit() will be cal

Re: [RFC] Merging LightDM into KDE Workspaces (forwarded from plasma-devel)

Am 28.08.2012, 00:25 Uhr, schrieb Martin Sandsmark : On Wed, Aug 22, 2012 at 01:58:57PM +0100, David Edmundson wrote: Features LightDM-KDE has that KDM does not: - Guest support login What does the DM have to do with this? David Edmundson schrieb On Thu, Aug 23, 2012 at 2:04 PM, Thomas

Re: Review Request: Add spinlocks lock type, based on GCC intrisincs

On segunda-feira, 27 de agosto de 2012 18.20.15, Michael Pyne wrote: > > Please use the Qt atomic types. Until GCC 4.7, they generate better code. > > I agree, the reason it wasn't that way initially is mentioned in the > discussion on the bug (but basically because you can't simply put > QBasic

Re: [RFC] Merging LightDM into KDE Workspaces (forwarded from plasma-devel)

On Wed, Aug 22, 2012 at 01:58:57PM +0100, David Edmundson wrote: > Features LightDM-KDE has that KDM does not: > - Guest support login What does the DM have to do with this? > - Ability to make customisations such as changing the background > without having to edit XML Isn't the kdm config fi

Re: Review Request: Add spinlocks lock type, based on GCC intrisincs

On Monday, August 27, 2012 09:17:43 Thiago Macieira wrote: > On domingo, 26 de agosto de 2012 19.09.15, Vadim Zhukov wrote: > > --- > > This is an automatically generated e-mail. To reply, visit: > > http://git.reviewboard.kde.org/r/106224/ >

Re: KCM Authorization (was: Re: Review Request: print-manager on kdereview)

2012/8/27 Christoph Feck : > On Monday 27 August 2012 22:15:18 Daniel Nicoletti wrote: >> 2012/8/27 Christoph Feck : >> > I am talking about whatever design mistake is responsible for bug >> > 242648, which isn't about CUPS at all. Sorry for side-tracking >> > this thread. I was just thinking that

KCM Authorization (was: Re: Review Request: print-manager on kdereview)

On Monday 27 August 2012 22:15:18 Daniel Nicoletti wrote: > 2012/8/27 Christoph Feck : > > I am talking about whatever design mistake is responsible for bug > > 242648, which isn't about CUPS at all. Sorry for side-tracking > > this thread. I was just thinking that with your expertise on the > > au

Re: Review Request: print-manager on kdereview

2012/8/27 Christoph Feck : > On Sunday 26 August 2012 06:34:30 Daniel Nicoletti wrote: >> 2012/8/25 Christoph Feck : >> > On Saturday 25 August 2012 04:29:19 Daniel Nicoletti wrote: >> >> 2012/8/23 Christoph Feck : >> >> > On Wednesday 22 August 2012 21:39:11 Daniel Nicoletti wrote: >> >> Well CUPS

Re: Review Request: print-manager on kdereview

On Sunday 26 August 2012 06:34:30 Daniel Nicoletti wrote: > 2012/8/25 Christoph Feck : > > On Saturday 25 August 2012 04:29:19 Daniel Nicoletti wrote: > >> 2012/8/23 Christoph Feck : > >> > On Wednesday 22 August 2012 21:39:11 Daniel Nicoletti wrote: > >> Well CUPS has it's own API for authorizatio

Re: Review Request: print-manager on kdereview

On Monday 27 August 2012 19:37:52 Albert Astals Cid wrote: > El Divendres, 24 d'agost de 2012, a les 23:29:19, Daniel Nicoletti > > Since the idea is to replace s-c-p-kde it would reside where it > > is now, so these repos would maybe go to unmaintained: > > git.kde.org:printer-applet > > http://we

Re: Review Request: print-manager on kdereview

On Mon, Aug 27, 2012 at 07:37:52PM +0200, Albert Astals Cid wrote: > > Since the idea is to replace s-c-p-kde it would reside where it is now, > > so these repos would maybe go to unmaintained: > > git.kde.org:printer-applet > > http://websvn.kde.org/trunk/KDE/kdeadmin/system-config-printer-kde/?vi

Re: Review Request: print-manager on kdereview

El Divendres, 24 d'agost de 2012, a les 23:29:19, Daniel Nicoletti va escriure: > Sorry forgot to reply to all.. > > 2012/8/23 Christoph Feck : > > On Wednesday 22 August 2012 21:39:11 Daniel Nicoletti wrote: > >> two years ago I started print-manager, at that time > >> I was using Debian which i

Re: Review Request: Move checks for locking primitives in KSharedDataCache to CMake

> On Aug. 26, 2012, 9:35 p.m., Michael Pyne wrote: > > I've looked over everything and didn't see anything I didn't like. I'd like > > to apply and and compile and run what little test cases do exist, but > > git-apply won't run as kdecore/util/{ConfigureChecks,config-util.h}.cmake > > don't e

Re: Review Request: Mutex cleanup in KSharedDataCache

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106221/ --- (Updated Aug. 27, 2012, 8:50 a.m.) Review request for kdelibs and Michael

Re: Review Request: Only show the screen config changed message once.

> On Aug. 26, 2012, 11:42 a.m., Kai Uwe Broulik wrote: > > That warning is there to remind the maintainer to re-factor that code and > > get rid of that message ;-) > > I’d vote for using a KNotify notification: 1. the user can configure it in > > a way he wants to (ie. show message? play sound

Re: Review Request: Move checks for locking primitives in KSharedDataCache to CMake

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106174/#review18113 --- Why do you want to do this ? Beside that, you are using CMakeP

Re: Review Request: Use a qml based screen locker in place of the screensaver

> On Aug. 25, 2012, 9:02 a.m., Oswald Buddenhagen wrote: > > ksmserver/screenlocker/greeter/greeterapp.cpp, line 199 > > > > > > looks anything between pointless and harmful. care to explain? was a misunderstanding

Re: Re: [RFC] Merging LightDM into KDE Workspaces (forwarded from plasma-devel)

On Thursday 23 August 2012 12:57:43 Harald Sitter wrote: > FWIW, last I talked to Robert about Canonical's involvement (which I > believe was at UDS in May last year) only the greeters were to be > covered by the CLA. Only the greeters created by Canonical, not all of them.

Re: Review Request: Add spinlocks lock type, based on GCC intrisincs

On domingo, 26 de agosto de 2012 19.09.15, Vadim Zhukov wrote: > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/106224/ > --- > > Re

Re: Review Request: Config cleanup on removeActivity

> On Aug. 27, 2012, 12:42 a.m., Lamarque Vieira Souza wrote: > > Ship It! > > Ivan Čukić wrote: > Which branch is this, since it is not master as specified? (in master, VD switcher is moved into a separate plugin) - Ivan --- This i