Re: Review Request: Make Sonnet::Speller::setLanguage threadsafe, fixing segfaults in krunner

2012-09-10 Thread Thomas Lübking
> On Sept. 6, 2012, 12:29 p.m., David Faure wrote: > > A number of comments on the implementation, but also a more general > > comment: does it even make sense to use a Speller in multiple threads, and > > to change the language from one thread while another one is using the > > speller for s

Re: Review Request: add kimgio WebP image format plugin

2012-09-10 Thread Allan Sandfeld Jensen
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106300/#review18829 --- Looks good. I started writing such a plugin myself sometime bac

Re: SLC for all 4.10 workspaces (was: Re: How Can I change wallpaper from CLI?)

2012-09-10 Thread Mario Fux
Am Sonntag 09 September 2012, 23.18:09 schrieb Albert Astals Cid: Morning > > As I'm sold to the SLC concept > > Maybe you could explain to us mere mortals what's the difference between > Share, Like and Connect. First here is a link to some more information about SLC: http://community.kde.org/

Re: Review Request: Make Sonnet::Speller::setLanguage threadsafe, fixing segfaults in krunner

2012-09-10 Thread Thomas Lübking
> On Sept. 6, 2012, 12:29 p.m., David Faure wrote: > > A number of comments on the implementation, but also a more general > > comment: does it even make sense to use a Speller in multiple threads, and > > to change the language from one thread while another one is using the > > speller for s

Re: Review Request: Make Sonnet::Speller::setLanguage threadsafe, fixing segfaults in krunner

2012-09-10 Thread David Faure
> On Sept. 6, 2012, 12:29 p.m., David Faure wrote: > > A number of comments on the implementation, but also a more general > > comment: does it even make sense to use a Speller in multiple threads, and > > to change the language from one thread while another one is using the > > speller for s

Re: Review Request: Make Sonnet::Speller::setLanguage threadsafe, fixing segfaults in krunner

2012-09-10 Thread Thomas Lübking
> On Sept. 6, 2012, 12:29 p.m., David Faure wrote: > > A number of comments on the implementation, but also a more general > > comment: does it even make sense to use a Speller in multiple threads, and > > to change the language from one thread while another one is using the > > speller for s

Re: Review Request: Make Sonnet::Speller::setLanguage threadsafe, fixing segfaults in krunner

2012-09-10 Thread Simeon Bird
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106242/ --- (Updated Sept. 9, 2012, 10:06 p.m.) Review request for kdelibs and Plasma.

Re: Review Request: Make Sonnet::Speller::setLanguage threadsafe, fixing segfaults in krunner

2012-09-10 Thread Simeon Bird
> On Sept. 6, 2012, 12:29 p.m., David Faure wrote: > > A number of comments on the implementation, but also a more general > > comment: does it even make sense to use a Speller in multiple threads, and > > to change the language from one thread while another one is using the > > speller for s