Re: Review Request 110390: Do not set Phonon KCM as changed at startup when using PulseAudio

2013-05-13 Thread Casian Andrei
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110390/#review32419 --- Looks ok to me, but I can't test since I don't have pulse

Re: Review Request 110390: Do not set Phonon KCM as changed at startup when using PulseAudio

2013-05-13 Thread Jan Grulich
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110390/ --- (Updated May 13, 2013, 8:10 a.m.) Review request for KDE Runtime, Casian

R: Re: R: Re: kde review kartesio

2013-05-13 Thread LucaTringali
Hi, no, build.sh is not needed. Since I'm kinda lazy, I prepared a shell script to run the following commands: mkdir build cd build sudo make uninstall make clean rm CMakeCache.txt cmake .. -DCMAKE_INSTALL_PREFIX=`kde4-config --prefix` make sudo make install so I don't have to type all those

R: Re: kde review kartesio

2013-05-13 Thread LucaTringali
Yes, I also think adding new features now is not a good idea in this moment. This is the reason why the new version of Kartesio I uploaded to git (about 45 minutes ago) contains basically all the corrctions you suggested, but no new features. Luca Tringali Messaggio originale Da:

R: Re: R: [kartesio] src: Fix some strings

2013-05-13 Thread LucaTringali
Hi, there is a little misunderstanding: those two settings are not global settings. This is how it works: if you check BackProp, the neural network will be trained using back propagation. If you check GenAlg, the network will be trained with genetic algorithms. If you check both them, the

Re: Review Request 108802: Switch Delete/Move To Trash actions when Shift key is pressed in Konqueror context menu

2013-05-13 Thread Frank Reininghaus
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108802/#review32426 --- Thanks for the patch, this is greatly appreciated! I could not

Re: Review Request 108802: Switch Delete/Move To Trash actions when Shift key is pressed in Konqueror context menu

2013-05-13 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108802/#review32428 --- Thanks for the refactoring. A few comments.

Re: Review Request 108802: Switch Delete/Move To Trash actions when Shift key is pressed in Konqueror context menu

2013-05-13 Thread Dawit Alemayehu
On May 13, 2013, 9:16 a.m., Frank Reininghaus wrote: dolphin/src/dolphinpart.cpp, line 463 http://git.reviewboard.kde.org/r/108802/diff/4/?file=143452#file143452line463 I could not test it yet, but this looks like we have a dangling pointer m_removeAction after this and might get

Re: Review Request 108802: Switch Delete/Move To Trash actions when Shift key is pressed in Konqueror context menu

2013-05-13 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108802/ --- (Updated May 13, 2013, 1:02 p.m.) Review request for KDE Base Apps, David

Re: Review Request 110277: Fix broken web shortcuts

2013-05-13 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110277/#review32446 --- This review has been submitted with commit

Re: Review Request 110277: Fix broken web shortcuts

2013-05-13 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110277/#review32447 --- This review has been submitted with commit

Re: Review Request 110277: Fix broken web shortcuts

2013-05-13 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110277/#review32448 --- This review has been submitted with commit

Re: Review Request 110277: Fix broken web shortcuts

2013-05-13 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110277/ --- (Updated May 13, 2013, 2:23 p.m.) Status -- This change has been

Re: Crashes with libQtUiTools.a if linked multiple times into the same process (with Bsymbolic-functions flag)

2013-05-13 Thread Friedrich W. H. Kossebau
Hi Thiago, Am Sonntag, 12. Mai 2013, 14:21:10 schrieb Thiago Macieira: On domingo, 12 de maio de 2013 22.47.35, Friedrich W. H. Kossebau wrote: + # Do not export QtUiTools internal symbols + set_target_properties(krossmoduleforms PROPERTIES LINK_FLAGS -Wl,-- exclude-libs

Re: Crashes with libQtUiTools.a if linked multiple times into the same process (with Bsymbolic-functions flag)

2013-05-13 Thread Thiago Macieira
On segunda-feira, 13 de maio de 2013 17.41.58, Friedrich W. H. Kossebau wrote: Interesting problem still: so any public symbol from a static lib can potentially appear multiple times in a process, if coming with different libs/modules, and then the first instance of that symbol shadows all

Re: R: Re: R: Re: R: Re: kde review kartesio

2013-05-13 Thread Albert Astals Cid
El Dissabte, 11 de maig de 2013, a les 14:37:06, LucaTringali va escriure: Ooops: I thought I already corrected this problem, for some reason I did not upload to git this correction. On my system the build goes fine also with that line, but I decide to remove it because it can cause problems

Re: Crashes with libQtUiTools.a if linked multiple times into the same process (with Bsymbolic-functions flag)

2013-05-13 Thread Friedrich W. H. Kossebau
Am Montag, 13. Mai 2013, 10:06:59 schrieb Thiago Macieira: On segunda-feira, 13 de maio de 2013 17.41.58, Friedrich W. H. Kossebau wrote: Interesting problem still: so any public symbol from a static lib can potentially appear multiple times in a process, if coming with different

Re: Review Request 108802: Switch Delete/Move To Trash actions when Shift key is pressed in Konqueror context menu

2013-05-13 Thread Frank Reininghaus
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108802/#review32458 --- Thanks for the new patch! This is really very nice work, looks

Re: Crashes with libQtUiTools.a if linked multiple times into the same process (with Bsymbolic-functions flag)

2013-05-13 Thread Thiago Macieira
On segunda-feira, 13 de maio de 2013 19.05.54, Friedrich W. H. Kossebau wrote: Am Montag, 13. Mai 2013, 10:06:59 schrieb Thiago Macieira: On segunda-feira, 13 de maio de 2013 17.41.58, Friedrich W. H. Kossebau wrote: Interesting problem still: so any public symbol from a static lib can

Re: Review Request 110277: Fix broken web shortcuts

2013-05-13 Thread Hrvoje Senjan
On May 13, 2013, 2:23 p.m., Commit Hook wrote: This review has been submitted with commit 56e93089160557805f17863b848ac178bb8975a8 by Maarten De Meyer to branch master. @Maarten, maybe the part about fixing query URL's could also go to KDE/4.10 branch? - Hrvoje

Re: Review Request 108802: Switch Delete/Move To Trash actions when Shift key is pressed in Konqueror context menu

2013-05-13 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108802/#review32467 --- dolphin/src/dolphinpart.cpp

Re: Review Request 110420: Bugfix for bug #311364

2013-05-13 Thread Romário Rios
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110420/ --- (Updated May 14, 2013, 1:22 a.m.) Review request for kde-workspace and

Re: Review Request 108802: Switch Delete/Move To Trash actions when Shift key is pressed in Konqueror context menu

2013-05-13 Thread Dawit Alemayehu
On May 13, 2013, 10:47 p.m., David Faure wrote: dolphin/src/dolphinpart.cpp, line 463 http://git.reviewboard.kde.org/r/108802/diff/5/?file=143487#file143487line463 I don't understand the use of QPointer. Wouldn't it be enough to add m_removeAction = 0; after this line?

Re: Review Request 108802: Switch Delete/Move To Trash actions when Shift key is pressed in Konqueror context menu

2013-05-13 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108802/ --- (Updated May 14, 2013, 1:56 a.m.) Review request for KDE Base Apps, David

Re: Review Request 110420: Bugfix for bug #311364

2013-05-13 Thread Romário Rios
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110420/ --- (Updated May 14, 2013, 1:56 a.m.) Status -- This change has been

Review Request 110421: Fix Konqueror's midnight commander profile

2013-05-13 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110421/ --- Review request for KDE Base Apps and David Faure. Description ---

Re: Review Request 110421: Fix Konqueror's midnight commander profile

2013-05-13 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110421/ --- (Updated May 14, 2013, 2:08 a.m.) Review request for KDE Base Apps and