Re: Review Request 111261: [KDE-Workspace]: Possible NULL ptr. deref. in KDM and KCheckPass

2013-06-28 Thread Oswald Buddenhagen
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111261/#review35196 --- kcheckpass/checkpass_osfc2passwd.c

Re: Review Request 111261: [KDE-Workspace]: Possible NULL ptr. deref. in KDM and KCheckPass

2013-06-28 Thread mancha mancha
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111261/ --- (Updated June 28, 2013, 7:12 a.m.) Review request for kde-workspace.

Re: Review Request 110755: Fix two small memory leaks in kded_keyboard

2013-06-28 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110755/#review35201 --- This review has been submitted with commit

Re: Review Request 110043: Proposed fix/workaround for legacy encoded filename handling

2013-06-28 Thread Róbert Szókovács
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110043/ --- (Updated June 28, 2013, 9:28 a.m.) Status -- This change has been

Re: Review Request 111261: [KDE-Workspace]: Possible NULL ptr. deref. in KDM and KCheckPass

2013-06-28 Thread mancha mancha
On June 28, 2013, 6:20 a.m., Oswald Buddenhagen wrote: kdm/backend/client.c, line 545 http://git.reviewboard.kde.org/r/111261/diff/2/?file=166173#file166173line545 i really meant line 543. ;) just as the code using it, it must be in the else branch of PAM and AIX. This should

Re: Review Request 110043: Proposed fix/workaround for legacy encoded filename handling

2013-06-28 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110043/#review35221 --- Have you committed this yet? I do not see it in git master.

Re: Review Request 110331: Sync kwalletmanager settings UI to kwalletd changes proposed in review 110330

2013-06-28 Thread Àlex Fiestas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110331/#review35222 --- Ship it! Once https://git.reviewboard.kde.org/r/110330/ is

Re: Review Request 110043: Proposed fix/workaround for legacy encoded filename handling

2013-06-28 Thread Róbert Szókovács
On June 28, 2013, 12:44 p.m., Dawit Alemayehu wrote: Have you committed this yet? I do not see it in git master. Anyhow, can you please add BUG: 159241 to your commit message when you do push it in? That bug report is the original one for the encoding issue you were trying to

Re: Review Request 110043: Proposed fix/workaround for legacy encoded filename handling

2013-06-28 Thread Thiago Macieira
On June 28, 2013, 2:53 p.m., David Faure wrote: Independently from this patch, I was thinking of a completely different approach to solve non-utf8 encodings in file:/// urls: using KRemoteEncoding in kio_file, just like we do in other slaves like kio_ftp. I.e. letting the user select

Re: Review Request 111171: Deprecate (in)active(Title/Text)Color in favor of KColorScheme

2013-06-28 Thread Àlex Fiestas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/71/ --- (Updated June 28, 2013, 5:10 p.m.) Review request for KDE Frameworks and

Re: Review Request 111171: Deprecate (in)active(Title/Text)Color in favor of KColorScheme

2013-06-28 Thread Thomas Lübking
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/71/#review35246 --- kdeui/util/kglobalsettings.h

Re: Review Request 111291: New Windows solid backend

2013-06-28 Thread Patrick von Reth
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111291/ --- (Updated June 28, 2013, 6:05 p.m.) Review request for kdelibs, kdewin and

Re: Review Request 111291: New Windows solid backend

2013-06-28 Thread Boudewijn Rempt
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111291/#review35251 --- I am not competent to judge the code, but krita users are